From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IB4dO0J2xWPBTQAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 17:07:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4HQzO0J2xWM+gwAAauVa8A (envelope-from ) for ; Mon, 16 Jan 2023 17:07:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBF741741D for ; Mon, 16 Jan 2023 17:07:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHS0t-0004pX-1M; Mon, 16 Jan 2023 11:07:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHS0r-0004pI-Jl for help-guix@gnu.org; Mon, 16 Jan 2023 11:07:09 -0500 Received: from mx1.riseup.net ([198.252.153.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHS0p-0006pc-Ry for help-guix@gnu.org; Mon, 16 Jan 2023 11:07:09 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4NwcNV4M16zDrC5; Mon, 16 Jan 2023 16:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1673885226; bh=bVyHt7E8/0agWhSVgZ1O3/KCIUlEIwKGS+0pUa6tbZ4=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=BwibdN/m5M7y+wjWWc6ncju6U42QFdry6NbqHIZ7Q2D36DuzJ9dwuS4oXH+EZ873Q gqgPWejmfbmuNGeCMhGbEJA57t7mpUrIlvNzlKrt2HFtDEAp2CihKVYznJebClLTgf 0pkmZQkRAHedBX7CDEadTGUBNxeefNbXtkvdtnrU= X-Riseup-User-ID: 6FC837C6DBE803AF2D2D57EEFF3B677A7E91BCB50048EC9AD156536451CF83ED Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4NwcNT6MlQz1yBV; Mon, 16 Jan 2023 16:07:05 +0000 (UTC) References: <86v8l8yrqp.fsf@riseup.net> <87tu0qu2sl.fsf@gmail.com> From: Csepp To: Simon Tournier Cc: Csepp , phodina via Subject: Re: libgit2 shallow clone (was Re: Packaging Grafana) Date: Mon, 16 Jan 2023 17:02:12 +0100 In-reply-to: <87tu0qu2sl.fsf@gmail.com> Message-ID: <87wn5mzcnu.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: help-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b="BwibdN/m"; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=riseup.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673885250; a=rsa-sha256; cv=none; b=WL8tP2Ci9c18hvYJLj354GxNMSILIRwsNrtBOO//uRmDcjfoHlGxlH9xg5VQ31c4xaA/Ls j35qh2wJYWrNvIJB3Q1MoJ1lL/OEJ0xln1et8LYs+/g8z8Weqbfr2qA7DiN5aU1a7WUq+m +FXlhHFdIe2sqUV7qUUbEXjEJ8cD/mM5geGKvHYtakS1KAm1Szo4L8Ewaxg8l9f/oF6YY5 PEt9cUYYKh4WKC3uGgS++Ag5+hY6mLFBFlMt5EaZ8/LATGRVDlAHFNiy9qBFl4AMzSyWdI wePyU/nWH5wKWS6HfdCBTxk/oV8ilJawAkFANdBXjjqycbNoPgGAP3pqjd2zMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673885250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iheUnlllN4hIJToF5JWFwpCltiMzMoCsbHsIv0m0Xp0=; b=ZSyiFNg7YK1TQcAJiMRBAqToya6kq5eug0OpBgudQQ9l17Nko3LnSTnObLzUwJjuf7QlOF I/Aim53HYumWzeQE+8MJA3zTYBRj66rarc/2ANhHCWPXoaAqHUSUX1dCRRXPh+hvmwSBSS MqBOo1XzhWyKyMxdAsesXmEBtIsrHttmHMiuSVvqNMbETgK2ZpW7CaWy2iCaI/olH1md8n GwzMWbENKkLglbQ5cmT92ak54MHX0j+rdH4pexr7UVYbCuFVHq6zEOeGmeHmhJJRuTTaFN mLSe/FU2VhyLNyk+NA3zQ1aU+2R9epOutd50tYq7b3HGOGAkrIDsqM0Tqy7MNA== X-Migadu-Queue-Id: CBF741741D X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b="BwibdN/m"; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=riseup.net X-Migadu-Spam-Score: -9.85 X-Spam-Score: -9.85 X-TUID: aZHUsrYhMWHC Simon Tournier writes: > Hi, > > On dim., 15 janv. 2023 at 12:12, Csepp wrote: > >> Honestly, I think our Go importer needs to be rewritten to just use Go's >> libraries instead of trying to replicate all functionality in Guile. It >> does a lot of... let's say sub-optimal things currently, like cloning >> full git repos, when Go is smart enough to only clone what it needs for >> dependency resolution. > > About cloning, the core of the issue is not Guile but libgit2. Guix > relies on guile-git which is just libgit2. And sadly, libgit2 does not > support shallow clone or depth fetch option. See libgit2 issue#3058. > > If I read correctly, Go relies on plain Git, instead. > > Therefore, sadly we cannot do better than full Git repository clone. > > It would be difficult switch from libgit2 to plain Git; as discussed in > this thread [2]. > > > 1: > 2: > > Cheers, > simon It would be worth it for importers. If I remember correctly, the reasoning for writing importers as Guile modules is reducing Guix's closure size, but that's nonsense when it comes to importing packages, because 99.9999% of the time you are going to be using the language's tooling anyways, because you will want to actually compile those imported packages. The Rust importer already loads guile-json or whatever at runtime, there is nothing wrong with having a similar runtime-only dependency on the Go compiler.