From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oOn3Mp5LlmIiawAAbAwnHQ (envelope-from ) for ; Tue, 31 May 2022 19:08:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EIT3Mp5LlmJ18AAA9RJhRA (envelope-from ) for ; Tue, 31 May 2022 19:08:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C2FD2985D for ; Tue, 31 May 2022 19:08:46 +0200 (CEST) Received: from localhost ([::1]:60988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nw5ML-0003ms-H6 for larch@yhetil.org; Tue, 31 May 2022 13:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw5LI-0003kx-Dg for help-guix@gnu.org; Tue, 31 May 2022 13:07:40 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw5LC-0003IP-Qg; Tue, 31 May 2022 13:07:40 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1654016846; cv=none; d=zohomail.com; s=zohoarc; b=REgn1XqHW5U45PPSAsMrYK37nAvQIYBSaXiSXMGouDV4ndEHOt/9pPHNRu8UC+5ml2R55Iu1EYGsGWj1q5YTjX2NdDohXxEmjLskMD2pZ8SapmF+gMfXNUqyHJfiu/V2VuIdwVNma4oSuKhfkQfx5DGQryNGYIEq2jD5zzSV8a0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654016846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=QYVoDkf7A4iHB4G+TNcJNDtRs9+KVvAOl7dF5YkZCZo=; b=fYcRyC5VErjYNM/9dKDXVWF+4GxCLC+YWIcpUyT5sZbv1v46MCQQ5EAmdUJO2n7gHP1P/kFaFIWfipo4VPg6QKfF3OCUS9u2asGEcBqhoPYGOyqs+B4r7HUuWLblGtwKbct+pyHQPPT8a4MJ7WfJIOf3A+gAYa9e4SVGMVs8VvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654016846; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=QYVoDkf7A4iHB4G+TNcJNDtRs9+KVvAOl7dF5YkZCZo=; b=X4qMvHipEbpm24OLVJtlDa1ngUYf6n+/yXQwlxtIY9PAouB2AqXpvFYTFBv+ckkc Y0K255rZNOUbjLbIsrYYuCtrBhfH42+VK88hzxePJrH/pKJY0dBbXpPq9NeQzIx5hGI pQujZz1b4MKFmzfICkOM3FHkwydTz/Jvbv9yrsz0= Received: from schwarzy (lfbn-idf3-1-598-152.w86-252.abo.wanadoo.fr [86.252.175.152]) by mx.zohomail.com with SMTPS id 1654016843808787.2304397554389; Tue, 31 May 2022 10:07:23 -0700 (PDT) References: <87tu9xum2c.fsf@rdklein.fr> <87r150o6zj.fsf@gmail.com> <87ee0gfj4z.fsf@gnu.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Edouard Klein To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Oleg Pykhalov , 55359@debbugs.gnu.org, help-guix@gnu.org Subject: Re: bug#55359: How do I extend openssh-service-type ? Date: Tue, 31 May 2022 19:05:41 +0200 In-reply-to: <87ee0gfj4z.fsf@gnu.org> Message-ID: <87v8tl7hrz.fsf@rdklein.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.11; envelope-from=edou@rdklein.fr; helo=sender4-op-o11.zoho.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654016926; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=QYVoDkf7A4iHB4G+TNcJNDtRs9+KVvAOl7dF5YkZCZo=; b=Rd1typiUKnEvOvsktuQd6Fvf7Kf1OZzvLcr+nLBO0gyOR4Y9ee9yYosAV4J81Fb2LyP81K c0JdHZk3zz3MH5DRpSxtTtFilRzd3U3XSnkpNq0aaht6YKDuCmbD2rfxM7+nU6Pnkxv17X X7gmBZ0Deymdcdo3DtT9faaarMdk2GYUuMmMI2lcmzR9gjP5VCb67cjFqqptibENe0wJ5W 0IWBfN1lrTL8p2NzY+/yJEzXKpclbKR6/KyM60Biyc2TjVnnQ4E/TzJRxflsFimB55nyBu QkY1YXVAlWMbBMPOW0TYRe6Fj3tCzM4XjFIYVSunynYp1cMJgWcd4OA5sDE23A== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1654016926; a=rsa-sha256; cv=pass; b=TwP+bVtkf+ekqp2yiB9tUimzyaFZ7AfCQOJDg8yLTy2k7YzbF8IxtBI3+cymqSHLGbVhFl 95k00liN90vJq2hmZf1JEK+hdllsl+rp1HEDHER9LNYTmDchcfJPIdNW7YMC92OFWbADAc twYcvhYrvGxCQiL0/qAHEyponnJEnoNRqk6qyhKIHiBTnZqr7M1AkRWUjJVG7CAkhwKKGx fzh9cTPqFFzApZnaljk24BULJ+Tv79JidwELd56aoXHH0FN/5ZkT9T1eeDflG7CqnZdZHQ 4IA8Ew5lHsnP9jVCQNeirEgbVPp6nREAqS60SfkB9hcqB9A1FPN21uGcMbjoBA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=rdklein.fr header.s=zoho header.b=X4qMvHip; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=rdklein.fr header.s=zoho header.b=X4qMvHip; arc=pass ("zohomail.com:s=zohoarc:i=1"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6C2FD2985D X-Spam-Score: -1.84 X-Migadu-Scanner: scn1.migadu.com X-TUID: NTmOJA/LvqtU Thank you both for solving this. I used a workaround for a while (rsyncing the keys to /home/user/.ssh/authorized_keys). Now I can confirm that the fixes work and I'm back to a declarative configuration of my server, which is awesome ! Cheers, Edouard. Ludovic Court=C3=A8s writes: > Hi, > > Oleg Pykhalov skribis: > >>> (service-extension openssh-service-type >>> (const `(("charlie" >>> ,(local-file "charlie.pub"))))) >>> #+end_quote >> >> [=E2=80=A6] >> >> Seems like extend-openssh-authorized-keys procedure does not use keys >> argument. We could fix it like: > > For the record, this bug (dismissing the =E2=80=98keys=E2=80=99 argument)= was introduced > in b4b2bbf4fb74c9f3e93d64863ab9b38957494b49 (Oct. 2021). > > How come nobody noticed then? > > The reason is that starting from > b4b2bbf4fb74c9f3e93d64863ab9b38957494b49, =E2=80=98authorized-key-directo= ry=E2=80=99 > would create an empty directory. That directory would then be copied by > =E2=80=98openssh-activation=E2=80=99 to /etc/ssh/authorized_keys.d; since > /etc/ssh/authorized_keys.d would typically already contain the relevant > keys, nothing bad would happen. > > Oleg=E2=80=99s commit 1f29ed4a812f86c45e2d9c37fd9f80f6d0418293 introduced > another bug though: we=E2=80=99d create an authorized-key directory that > included keys brought by extensions, but each of these files would be > empty (because =E2=80=98extend-openssh-authorized-keys=E2=80=99 would dis= miss key files > associated with user names), which could lock yourself out. > > Fixed in 0dc63ce519c5f98b2186d1871176e2fac3a6926b. Reconfiguration > recommended before you=E2=80=99re locked out! > > Thanks, > Ludo=E2=80=99.