From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mJcjApjJ8mJhtQAAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 22:54:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wCpBAZjJ8mKbogAAG6o9tA (envelope-from ) for ; Tue, 09 Aug 2022 22:54:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41157131CE for ; Tue, 9 Aug 2022 22:54:47 +0200 (CEST) Received: from localhost ([::1]:60622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLWFS-0001Ff-FM for larch@yhetil.org; Tue, 09 Aug 2022 16:54:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLWF3-0001FK-VE for help-guix@gnu.org; Tue, 09 Aug 2022 16:54:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLWF1-0004Sf-NK; Tue, 09 Aug 2022 16:54:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=aiD75dotxagtbzOrHwOnvEmwl59wTpB+FvAVtQyeS38=; b=c/tf79B8pABmBNpauGgI MQVCiMK0AbgqSVjM1FkDXsN1jEqWzfmpEt1YwzP6/3hdXiKNG0Ztn5azKbeDq+ktifAJZqHgE0ogi EQr0hR8a97riIsTB3M8uC2wABLrAUYrBVBWunQZjOf1PS6T/qcwcpaFKK1xTggcby/lzKX2LNS6Un rZxEpQndAzdZOkMgGlKj86o9ES3u59mEapke0WHbxa+hfKmac1pec5FcTJzeVR0AEQAdpEtpNj/qk TX/LS3xQ7HlXOq9qzcVzp7fs6NwEh6INW6OhZdQ91evf19KYvfI35VszM+W2IxPORe1sqHzf1ulLN IzSyGz5dLfepRA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55456 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLWF0-0001gl-6n; Tue, 09 Aug 2022 16:54:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Nicolas Graves via Cc: Nicolas Graves Subject: Re: managing waiting patches References: <87a68lorw8.fsf@ngraves.fr> Mail-Followup-To: guix-devel@gnu.org X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 22 Thermidor an 230 de la =?utf-8?Q?R=C3=A9vol?= =?utf-8?Q?ution=2C?= jour du =?utf-8?Q?C=C3=A2prier?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 09 Aug 2022 22:54:15 +0200 In-Reply-To: <87a68lorw8.fsf@ngraves.fr> (Nicolas Graves via's message of "Thu, 04 Aug 2022 00:59:19 +0200") Message-ID: <87tu6l2l54.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660078487; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=aiD75dotxagtbzOrHwOnvEmwl59wTpB+FvAVtQyeS38=; b=rGnN9Ac6Ab2u8mQTCkS7A0Ho0Tq4raI7c9TQqZ6RaxjdglYo8M32z8BVAE0Z6SNTEemkgA SvZEBmTsag2unMF/1XprRsik4UDn3sgT2LBDzBVyun+o19jG0B2p1itHjnrHPxSdpVokRn gVy6w0kEsATja8yqNdAd9/fU6N53+BTSUDbwK+ILiu3H9AyXuCqrg6kqOanG0cWkEgWw3p LpwgCqUZy82jLWjFG/v3fjSrAHdZu8nizSKSSTo3NcSzKw4AoxCkEWVwN97WOIZ7gNgPA3 auYpb8wG3bQpVGtPPMJ+gfvGjoJxkA2RIwRR+/tCNW7+2s313my5Zcb/ll6Zgw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660078487; a=rsa-sha256; cv=none; b=cF3QPuyjpdocWK9EqhNQvRRheDcfsNDm++jvDS53O1IVJEXa+xrMT8tbO9VeaS2hIyp+jx 2J1JZkBhgStps/ApH9B9SAoR6/yNe1qMmqOKj/4n8lYKj9GZJVwp9Sh3o2F54kRm0tnZt1 hjYgwif5eJE4zu07mVhZHvXxp0YTe5MJPl9NFspMt5RWEt2Iak21PXg1H+7Vbn0kJdccO6 SBQIvizNs/W7p3HhYfzq8WvyxcA6q6iZXoVIcuqIfu2E+DsmiV50zwxuBe/NC6Lp0QWzbJ 7L3Na8T6gnZgg0m1Nk/1f5kQ1+szL6/bhu7taWCgYAjkvjxoXlFdTSaRO+oL3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b="c/tf79B8"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.09 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b="c/tf79B8"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 41157131CE X-Spam-Score: -5.09 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZZq0fC4jZKHz Hello Nicolas, Thanks for your message. Patch review is overall rather slow due to a mixture of Guix being a victim of its success and (perhaps more importantly) having too few people devoting time to patch review, and too few committers committing. This was discussed recently on guix-devel and I hope we can collectively improve on that. The new teams that we devised (see =E2=80=98etc/teams.scm= =E2=80=99) should help, though we have yet to document them and publicize them. Nicolas Graves via skribis: > 1) how to manage and track series of patches one makes in his local repo > copy. > > For that, I will take a practical example. > > I made some rust patches a few days ago. The final goal of these first > patches would have been to add the package swayr@0.20, which is huge > when imported with recursive guix import (~2k lines). So I did split the > task in a few subgoals, by trying to first update packages that are > already present. By only doing that, I already had a stack of ~15 > commits. I couldn't contribute more at that moment, so I sent them in > the hope that they would get merged before a next partial goal. I don=E2=80=99t have any great suggestion here=E2=80=94you already seem to = be doing things rationally. In general, short, to-the-point patch series are more likely to be reviewed quickly, so that=E2=80=99s one strategy you can = adopt here. And then you can locally keep branches for each part of the broader patch series, possibly rebasing them until they=E2=80=99re applied. > 2) how to get one's patches to pass. > > Another problematic I encounter is having to wait for a patch series to > pass to send another one. Another example. > > I'm developing in my free time for an organisation using wagtail CMS for > its website. I thought that it would be a great occasion to send some > packages for guix, and get some experience with packaging. So I worked > on that and send some patches (55476 55475 55474 55473). They are pretty > clean (almost all tests enabled, tested as a user) (except maybe for > descriptions, I'm not sure I remember for that). > > At some point, wagtail made an upgrade to version 3.0.1, and I started > to update my packages locally, but don't want to make a totally new > series of patches while the previous was not accepted. In the meantime, > I send patches 56296 which would have been useful for later and actually > fixes some failing packages. I'm now stuck on this contributing task > because of this. I can sympathize. :-/ You could send an updated patch series with the new version as v2; that would also serve as a reminder for reviewers. Using ./etc/teams.scm you can also look for people working in this area that you could ping. Last, if you=E2=80=99re on IRC, you=E2=80=99re welcome to occasionally ping= people there. [...] > What should I do in this case? Should I try to become a committer > myself? Have a "committer buddy" that can merge my sent packages? Keep > working in a personal channel or a channel like guixrus and rely on that > additionally to relying on guix? Other options? > > Thanks a lot for your answer, sorry if I don't have very acute developer > workflows, I'm only doing this in my free time ;) Understood! You can always keep your work in a channel of yours until it=E2=80=99s merged. I do encourage you to work to get it in Guix proper though, because in the end everyone benefits. I hope we can all work to reduce the bottleneck. Thanks, Ludo=E2=80=99.