unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Mortimer Cladwell <mbcladwell@gmail.com>, help-guix <help-guix@gnu.org>
Subject: Re: How to use guix hash --serializer?
Date: Tue, 04 Jan 2022 14:09:00 -0500	[thread overview]
Message-ID: <87k0ff1foz.fsf@ngyro.com> (raw)
In-Reply-To: <CAJ3okZ15xP05Jm4m49HSp1TUmLLF4sgS7ORReQmhdrLoJHHYng@mail.gmail.com> (zimoun's message of "Tue, 4 Jan 2022 17:53:55 +0100")

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi zimoun,

zimoun <zimon.toutoune@gmail.com> writes:

> Indeed,
>
>     $ guix hash -S git foo -x
>     0czq9304mdv9f2j6a8cdi9855sl8w595p06c1m8bn9pg391lhcal
>     $ guix hash -S git foo
>     0czq9304mdv9f2j6a8cdi9855sl8w595p06c1m8bn9pg391lhcal
>
> Hum, I will check if it is expected.

I’m pretty sure it’s a bug.  Fortunately, with Disarchive 0.4.0, the
following (untested) patch should fix it:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: git-hash-select.patch --]
[-- Type: text/x-patch, Size: 414 bytes --]

diff --git a/guix/scripts/hash.scm b/guix/scripts/hash.scm
index d73e3d13dd..c44a4de9a4 100644
--- a/guix/scripts/hash.scm
+++ b/guix/scripts/hash.scm
@@ -69,7 +69,7 @@ (define* (git-hash file #:optional
       ((directory) #t)
       (else #f)))
   (if directory?
-      (git-hash-directory file algorithm)
+      (git-hash-directory file algorithm #:select? select?)
       (git-hash-file file algorithm)))
 
 \f

[-- Attachment #3: Type: text/plain, Size: 27 bytes --]


Hope that helps!


-- Tim

  reply	other threads:[~2022-01-04 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 16:32 How to use guix hash --serializer? Mortimer Cladwell
2022-01-04 16:53 ` zimoun
2022-01-04 19:09   ` Timothy Sample [this message]
2022-01-04 19:48     ` Mortimer Cladwell
2022-01-04 19:57       ` Tobias Geerinckx-Rice
2022-01-04 19:58       ` Mortimer Cladwell
2022-01-04 20:17       ` zimoun
2022-01-04 20:44         ` Mortimer Cladwell
2022-01-04 20:57           ` Tobias Geerinckx-Rice
2022-01-04 21:02           ` zimoun
2022-01-04 21:16             ` Mortimer Cladwell
2022-01-04 20:54     ` zimoun
2022-01-05  1:44       ` Timothy Sample
2022-01-05  7:43         ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0ff1foz.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=help-guix@gnu.org \
    --cc=mbcladwell@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).