From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MCGiEUGNBWAzXgAA0tVLHw (envelope-from ) for ; Mon, 18 Jan 2021 13:29:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WFRkDUGNBWAQWwAAbx9fmQ (envelope-from ) for ; Mon, 18 Jan 2021 13:29:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF3629404E8 for ; Mon, 18 Jan 2021 13:29:35 +0000 (UTC) Received: from localhost ([::1]:43192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1Ub7-0007CL-51 for larch@yhetil.org; Mon, 18 Jan 2021 08:29:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1Uaz-0007Bb-87 for help-guix@gnu.org; Mon, 18 Jan 2021 08:29:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55847) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1Uay-0002PY-6u; Mon, 18 Jan 2021 08:29:24 -0500 Received: from [2a01:e0a:19b:d9a0:1538:87ab:3a95:7600] (port=56964 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1Uaw-0004gH-CB; Mon, 18 Jan 2021 08:29:23 -0500 From: Mathieu Othacehe To: Joshua Branson Subject: Re: [PATCH] * doc/guix-cookbook.texi (Guix System Image API): new section References: <87sg73xuks.fsf@dismail.de> <20210117131053.32763-1-jbranso@dismail.de> Date: Mon, 18 Jan 2021 14:29:20 +0100 In-Reply-To: <20210117131053.32763-1-jbranso@dismail.de> (Joshua Branson's message of "Sun, 17 Jan 2021 08:10:53 -0500") Message-ID: <87h7nepe4v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: help-guix@gnu.org Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: EF3629404E8 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: W+LzteJP+3iv Hello, Thanks for this contribution! You should submit patches to "guix-patches@gnu.org" instead of this mailing list. There's also a small issue with the commit message which is placed as title of this email. > +* Guix System Image API:: Customizing the disk-image to target specific platforms. Customizing disk images to target specific platforms, maybe? > +@itemize @bullet > +@item > +- @file{gnu/system/images/hurd.scm} You can remove the dash here. > +@example > +guix system disk-image my-os.scm > +@end example I have a pending patchset renaming "disk-image" command to "image". We will need to update it accordingly. Otherwise, it looks nice to me, but I may be biased here. It would be nice if someone else could have a look. Thanks, Mathieu