unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Joshua Branson <jbranso@dismail.de>
Cc: help-guix@gnu.org
Subject: Re: [PATCH] * doc/guix-cookbook.texi (Guix System Image API): new section
Date: Mon, 18 Jan 2021 14:29:20 +0100	[thread overview]
Message-ID: <87h7nepe4v.fsf@gnu.org> (raw)
In-Reply-To: <20210117131053.32763-1-jbranso@dismail.de> (Joshua Branson's message of "Sun, 17 Jan 2021 08:10:53 -0500")


Hello,

Thanks for this contribution! You should submit patches to
"guix-patches@gnu.org" instead of this mailing list.

There's also a small issue with the commit message which is placed as
title of this email.

> +* Guix System Image API::        Customizing the disk-image to target specific platforms.

Customizing disk images to target specific platforms, maybe?

> +@itemize @bullet
> +@item
> +- @file{gnu/system/images/hurd.scm}

You can remove the dash here.

> +@example
> +guix system disk-image my-os.scm
> +@end example

I have a pending patchset renaming "disk-image" command to "image". We
will need to update it accordingly.

Otherwise, it looks nice to me, but I may be biased here. It would be
nice if someone else could have a look.

Thanks,

Mathieu


  reply	other threads:[~2021-01-18 13:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 14:33 Single-board-computer approach: don't make an installer, make the install? Christopher Lemmer Webber
2021-01-13 14:51 ` Mathieu Othacehe
2021-01-13 15:53   ` Christopher Lemmer Webber
2021-01-13 19:55   ` Joshua Branson via
2021-01-14  3:42     ` Christopher Lemmer Webber
2021-01-14  8:54     ` Mathieu Othacehe
2021-01-14 18:05       ` Joshua Branson via
2021-01-17 13:10         ` [PATCH] * doc/guix-cookbook.texi (Guix System Image API): new section Joshua Branson
2021-01-18 13:29           ` Mathieu Othacehe [this message]
2021-01-18 16:08             ` Joshua Branson
2021-01-18 16:38             ` jbranso--- via
2021-01-21 20:39       ` Single-board-computer approach: don't make an installer, make the install? Joshua Branson
2021-01-22 13:32         ` Mathieu Othacehe
2021-03-21 13:51           ` Joshua Branson
2021-03-29  7:39             ` Mathieu Othacehe
2021-03-31 16:40               ` Joshua Branson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7nepe4v.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=help-guix@gnu.org \
    --cc=jbranso@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).