From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: Output of guix build --check foo is not part of store deduplication Date: Fri, 10 Aug 2018 02:16:13 -0700 Message-ID: <87eff6k2ea.fsf@gmail.com> References: <20180809114555.33f21652@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo3Wv-0008P0-Tl for help-guix@gnu.org; Fri, 10 Aug 2018 05:16:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fo3Wu-000254-RZ for help-guix@gnu.org; Fri, 10 Aug 2018 05:16:21 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:43450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fo3Wu-00024C-JV for help-guix@gnu.org; Fri, 10 Aug 2018 05:16:20 -0400 Received: by mail-pf1-x42c.google.com with SMTP id j26-v6so4235074pfi.10 for ; Fri, 10 Aug 2018 02:16:20 -0700 (PDT) In-Reply-To: <20180809114555.33f21652@alma-ubu> (=?utf-8?Q?=22Bj=C3=B6rn?= =?utf-8?Q?_H=C3=B6fling=22's?= message of "Thu, 9 Aug 2018 11:45:55 +0200") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+gcggh-help-guix=m.gmane.org@gnu.org Sender: "Help-Guix" To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= Cc: Guix-Help --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Bj=C3=B6rn, In registerOutputs from nix/libstore/build.cc, it seems that if a check was requested (i.e., buildMode =3D=3D bmCheck), an exception is thrown when the build is found to be non-deterministic. In addition, it looks like that would prevent execution from reaching the line farther down where we call worker.store.optimisePath(path), which does the deduplication when deduplication is enabled (i.e., when settings.autoOptimiseStore evaluates to true). The current Nix source code seems to have the same structure, which suggests that perhaps the current version of the nix-daemon behaves the same way. Perhaps you could reproduce the issue in Nix and ask about it upstream? Maybe there is a good reason why Eelco changed diffoscope to ignore the links instead of changing the build.cc code to perform the deduplication. For example, maybe the work to ensure that deduplication occurs even when a check fails is more complicated and error-prone than simply updating diffoscope to ignore link counts. It couldn't hurt to ask! =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlttV90ACgkQ3UCaFdgi Rp2/kA/+KWYDrfsEV2idhZlaakCSdV/BFPn0PYHs+3IngzwkO3iMb8pcAV5YcVIY Er2qdMLL1PTJWt6bLaDM1hgZ8lb9fjSbMjGw5xhRjZ5lYBANZlmydBDiiYMNoGXp la/pX5aQlOelw4ZQrG1hLReV8X5/vl8bwNQbQXXoA65GJXlMW0fKeIDPUZI4WlDa 9NGkpKhHdiCuZo5Ld7R9OVhmEHgcdLtuIdH2ACJJWzIw2Cpbf+PLyoj7OxIWfZe7 cdj1XPGVeqmS4+FyxEWrFGPh+c3IAf9/fPJ+J6Q81JsZivKI0KbOjHex4F6/NG7y 08+A7NHMB0BevtOUoIz6eZbZlSmPgHi3PbEQnen1fyZJNT7E4bwCs3i/kTYqj6q1 9o81bCLtdP/7NOqPDsOjy8q+vMqrJmuGkizFQmkWgGWx8WIEDJXCecn/2MsgJC7u v6DqGKt/G4xckr8Rek3DA8NnCx/8paK7pOd2oyB2E42bZeef1MDqg5PJbcGIFVos EBHuyelu0Rfm570VRDHifXbIbA4KjwSAqWknvk5g5ST+9ZC9FEYckLPaQCEgpwoB SWuqvq2rSJMy0jN6OSmutTkPZjGiclJj0VznQUXBiI+6hmIcOVcGjNoewsZvxggr 7kyUpIJOlGc8whcKPpGbVuhH92b7Kqwan+lxU0hRTNoV+KN0Kbg= =YTIw -----END PGP SIGNATURE----- --=-=-=--