chromaprint: fpcalc missing

chromaprint: fpcalc missing

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]


The chromaprint commandline tool "fpcalc" to compute fingerprints is
missing.

I believe passing the CMAKE argument

	-DBUILD_TOOLS=ON

would be enough.

I guess it would be a nice fit for a separate output.

-- 
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: chromaprint: fpcalc missing

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

2018-04-03 8:24 GMT+02:00 Pierre Neidhardt <ambrevar@gmail.com>:

>
> The chromaprint commandline tool "fpcalc" to compute fingerprints is
> missing.
>
> I believe passing the CMAKE argument
>
>         -DBUILD_TOOLS=ON
>
> would be enough.
>
> I guess it would be a nice fit for a separate output.
>
> --
> Pierre Neidhardt
>


which package are you talking about ?

Anyway, you can submit a patch ☺

[-- Attachment #2: Type: text/html, Size: 892 bytes --]

Re: chromaprint: fpcalc missing

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]


Catonano <catonano@gmail.com> writes:

> which package are you talking about ?
>
> Anyway, you can submit a patch ☺

The chromaprint package.

I'll submit a patch but I wanted to ask, maybe the original author of
the recipe has an opinion about it.

--
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: chromaprint: fpcalc missing

[Ludovic Courtès]

Hello,

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> Catonano <catonano@gmail.com> writes:
>
>> which package are you talking about ?
>>
>> Anyway, you can submit a patch ☺
>
> The chromaprint package.
>
> I'll submit a patch but I wanted to ask, maybe the original author of
> the recipe has an opinion about it.

The best way to know that is by sending a patch.  ;-)

A common criterion in deciding whether or not to enable an optional
feature is how widely used it is vs. how much it adds to the size of the
package closure.  If you can provide that kind of info in your patch
submission, that’ll make it easier to decide what to do.

Thanks,
Ludo’.

Re: chromaprint: fpcalc missing

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> The best way to know that is by sending a patch.  ;-)
>
> A common criterion in deciding whether or not to enable an optional
> feature is how widely used it is vs. how much it adds to the size of the
> package closure.  If you can provide that kind of info in your patch
> submission, that’ll make it easier to decide what to do.

Done: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31046

-- 
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]