unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Felix Lechner <felix.lechner@lease-up.com>
Cc: Suhail <suhail@bayesians.ca>,
	 Felix Lechner via <help-guix@gnu.org>,
	Julien Lepiller <julien@lepiller.eu>,
	 Simon Tournier <zimon.toutoune@gmail.com>
Subject: Re: Turning off tests leads to a different store item
Date: Wed, 08 Nov 2023 09:45:53 -0500	[thread overview]
Message-ID: <878r78gv6m.fsf@gmail.com> (raw)
In-Reply-To: <871qd19cqn.fsf@lease-up.com> (Felix Lechner's message of "Tue, 07 Nov 2023 18:53:52 -0800")

Hi Felix,

Felix Lechner <felix.lechner@lease-up.com> writes:

> Hi,
>
> On Tue, Nov 07 2023, Maxim Cournoyer wrote:
>
>>> Felix Lechner via <help-guix@gnu.org> writes:
>>>
>>>> Those shortfalls are a consequence of our packaging habits. In an ideal
>>>> world, would running a test suite ever build a different derivation?
>>
>> You seem to be confusing 'derivation', which is the build recipe
>> description that a package "compiles" to, with the package output, the
>> result of executing the derivation.

[...]

> A source tree should produce the same derivation regardless of whether
> build-time tests ran or didn't. It should also pull the same substitute.

A source tree doesn't produce a derivation.  A derivation is the
complete build recipe that captures the source and the package
definition, that when built by the daemon produces a store item.

Earlier in the thread, I've mentioned that running a test suite can have
side effects such as happened in the past in Python with timestamps
being written to the loaded .pyc files when running test suites; we
can't ensure the test suite has no side-effects on the rest of the
package, so we can't simply assume building with #:tests? #f produces
the same as when building with #:tests? #t.

And to come back to the original idea: building with the tests run makes
sense for a distribution -- it's one of the rare things we have at our
disposal to ensure things are properly integrated and keep working.

-- 
Thanks,
Maxim


  reply	other threads:[~2023-11-08 14:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <65429087.0c0a0220.5908c.4d60SMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-07 18:58 ` Turning off tests leads to a different store item Maxim Cournoyer
2023-11-07 21:58   ` Csepp
2023-11-08  2:53   ` Felix Lechner via
2023-11-08 14:45     ` Maxim Cournoyer [this message]
2023-11-08 17:07       ` Felix Lechner via
2023-11-08 18:18         ` Vagrant Cascadian
2023-11-08 19:20           ` Saku Laesvuori
2023-11-08 22:21             ` Simon Tournier
2023-11-09  3:17               ` Maxim Cournoyer
2023-11-09  7:37                 ` Simon Tournier
2023-11-09 15:04                   ` Maxim Cournoyer
2023-11-16  9:31                     ` Simon Tournier
2023-11-18  4:38                       ` Maxim Cournoyer
2023-11-03 14:13 Suhail
2023-11-05 12:07 ` Simon Tournier
  -- strict thread matches above, loose matches on Subject: below --
2023-11-02 18:54 Suhail
2023-11-03  9:33 ` Simon Tournier
2023-11-02 17:25 Suhail
     [not found] <6543bf92.d40a0220.bbcd0.1118SMTPIN_ADDED_BROKEN@mx.google.com>
2023-11-02 16:03 ` Greg Hogan
2023-11-02 15:25 Suhail
2023-11-02 17:02 ` Simon Tournier
2023-11-02 17:46   ` Simon Tournier
2023-11-03 13:08 ` Tomas Volf
2023-11-03 20:44   ` Suhail

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r78gv6m.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=felix.lechner@lease-up.com \
    --cc=help-guix@gnu.org \
    --cc=julien@lepiller.eu \
    --cc=suhail@bayesians.ca \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).