packages won't pass white space linting -- what am I doing wrong?

packages won't pass white space linting -- what am I doing wrong?

[Blake Shaw]

hiya guix,

I have a set of packages ready to send upstream, but I can't seem to
to get them to pass tabulation tests in the linter. as an example, I
here is the package notcurses which builds and installs fine, yet while
I wrote it using `guix-devel-mode` in emacs and its thus indented
accordingly, when I lint it I get:

```bash
error: TODO:: unbound variable
hint: Did you forget a `use-modules' form?

~/src/rml/unguix/notcurses.scm:31:0: notcurses@2.4.9: tabulation on line 31, column 0
~/src/rml/unguix/notcurses.scm:32:0: notcurses@2.4.9: tabulation on line 32, column 0
[...] ;;and so on for each line until the end of the file.
```
the package definition is available here:
https://git.sr.ht/~cybersyn/rml/tree/devel/item/unguix/notcurses.scm

while it appears to look like other package definitions, I can't seem to
figure out what the issue is. I tried disabling lispy-mode, a paredit
like emacs mode, re-tabulating and linting again, but it produce the
same result.

could this perhaps be a bug in the linter?

best,
blake

-- 
“In girum imus nocte et consumimur igni”

Re: packages won't pass white space linting -- what am I doing wrong?

[Julien Lepiller]

Hi, it looks like the linter is correct: there is a tab at the beginning of the lines 31, 32 and following. We don't use tabs for identation, please replace them with spaces as suggested by the linter :)

Le 12 novembre 2021 02:02:17 GMT-05:00, Blake Shaw <blake@nonconstructivism.com> a écrit :
>
>hiya guix,
>
>I have a set of packages ready to send upstream, but I can't seem to
>to get them to pass tabulation tests in the linter. as an example, I
>here is the package notcurses which builds and installs fine, yet while
>I wrote it using `guix-devel-mode` in emacs and its thus indented
>accordingly, when I lint it I get:
>
>```bash
>error: TODO:: unbound variable
>hint: Did you forget a `use-modules' form?
>
>~/src/rml/unguix/notcurses.scm:31:0: notcurses@2.4.9: tabulation on line 31, column 0
>~/src/rml/unguix/notcurses.scm:32:0: notcurses@2.4.9: tabulation on line 32, column 0
>[...] ;;and so on for each line until the end of the file.
>```
>the package definition is available here:
>https://git.sr.ht/~cybersyn/rml/tree/devel/item/unguix/notcurses.scm
>
>while it appears to look like other package definitions, I can't seem to
>figure out what the issue is. I tried disabling lispy-mode, a paredit
>like emacs mode, re-tabulating and linting again, but it produce the
>same result.
>
>could this perhaps be a bug in the linter?
>
>best,
>blake
>
>-- 
>“In girum imus nocte et consumimur igni”
>

Re: packages won't pass white space linting -- what am I doing wrong?

[Daniel Meißner]

Hi Blake,

Blake Shaw writes:
> while it appears to look like other package definitions, I can't seem
> to figure out what the issue is. I tried disabling lispy-mode, a
> paredit like emacs mode, re-tabulating and linting again, but it
> produce the same result.

As Julien notes, you have tabs at the beginning of the lines 31, 32, ...
To get rid of the tabs you could evaluate this in your notcurses.scm
buffer:

--8<---------------cut here---------------start------------->8---
(setq indent-tabs-mode nil)
(untabify)
--8<---------------cut here---------------end--------------->8---

Then save and run the linter again.

Best
Daniel