From: Suhail <suhail@bayesians.ca>
To: Steve George <steve@futurile.net>
Cc: Edouard Klein <edou@rdklein.fr>, guix-devel@gnu.org, help-guix@gnu.org
Subject: Re: Guix Days: Patch flow discussion
Date: Tue, 06 Feb 2024 19:42:39 +0000 [thread overview]
Message-ID: <8734u5js5w.fsf@> (raw)
Steve George <steve@futurile.net> writes:
> elsewhere in the thread someone mentions some tags we could use
> consistently so maintainers can find patches that have been reviewed
> easily.
It seems on the [dev manual] we already have "reviewed-looks-good"
documented. Thus, I'd like to propose the below *mutually exclusive*
Debbugs tag set:
- "not-yet-reviewed" :: automatically set for all submissions
- "reviewed-needs-fix" :: set explicitly by the reviewer
- "needs-another-review" :: automatically set if there's a revised
patch, unless "not-yet-reviewed" (in which case no change)
- "reviewed-looks-good" :: set explicitly by the reviewer
In addition to the above, it might also help for there to be an
additional tag of "might-not-need-review" (or simpler,
"review-not-needed") which gets automatically set, provided we implement
a way to label some changes (for some packages) as being "trivial enough
that they're okay as long as build succeeds".
On a related note, is it possible for a reviewer who isn't a committer
to set debbugs tags?
[dev manual]: <https://guix.gnu.org/en/manual/devel/en/html_node/Debbugs-Usertags.html>
> It would be great to agree those - try them for a bit - and document
> them in a 'howto' so that everyone uses the same process.
In addition to documenting the tags in the "Debbugs Usertags" section of
the manual, it would help for there to be a "howto" which focuses more
on the transition between the tags (i.e., the contribution workflow).
--
Suhail
next reply other threads:[~2024-02-06 19:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 19:42 Suhail [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-18 2:31 Guix Days: Patch flow discussion Suhail
[not found] <35786.5440238797$1707248619@news.gmane.org>
2024-02-16 10:56 ` Clément Lassieur
2024-02-16 11:03 ` Andreas Enge
2024-02-16 11:28 ` Clément Lassieur
2024-02-16 12:06 ` Christopher Baines
2024-02-06 19:47 Suhail
[not found] <65c12e7e.0c0a0220.d7729.823cSMTPIN_ADDED_BROKEN@mx.google.com>
2024-02-05 19:52 ` Felix Lechner via
2024-02-05 18:51 Suhail
2024-02-06 16:51 ` Steve George
2024-02-05 9:39 Steve George
2024-02-05 15:57 ` Clément Lassieur
2024-02-05 17:10 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-02-05 17:28 ` Clément Lassieur
2024-02-05 18:27 ` Felix Lechner via
2024-02-05 18:50 ` Clément Lassieur
2024-02-05 22:10 ` Steve George
2024-02-06 13:27 ` Edouard Klein
2024-02-06 13:39 ` Steve George
2024-02-08 19:56 ` Skyler Ferris
2024-02-09 16:35 ` Edouard Klein
2024-02-09 16:46 ` Andreas Enge
2024-02-11 10:03 ` Steve George
2024-02-14 21:40 ` Simon Tournier
2024-02-28 17:51 ` Giovanni Biscuolo
2024-02-28 19:21 ` Matt
2024-02-29 15:41 ` Daniel Littlewood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734u5js5w.fsf@ \
--to=suhail@bayesians.ca \
--cc=edou@rdklein.fr \
--cc=guix-devel@gnu.org \
--cc=help-guix@gnu.org \
--cc=steve@futurile.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).