From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IAj4JYqNAGBnPQAA0tVLHw (envelope-from ) for ; Thu, 14 Jan 2021 18:29:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +EisIYqNAGARTAAAbx9fmQ (envelope-from ) for ; Thu, 14 Jan 2021 18:29:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 006469402AF for ; Thu, 14 Jan 2021 18:29:29 +0000 (UTC) Received: from localhost ([::1]:48268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l07NA-0008OX-Qj for larch@yhetil.org; Thu, 14 Jan 2021 13:29:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06fq-0000Gu-Ie for help-guix@gnu.org; Thu, 14 Jan 2021 12:44:43 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]:58678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06fl-0005cJ-Gq for help-guix@gnu.org; Thu, 14 Jan 2021 12:44:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=6nH/tR9xIMwryUOYodCBC3M7N0EXKOKuFRfYWLxqEGk=; h=date:in-reply-to: references:subject:cc:to:from; b=AfI1uZCFONs6q/DAKzDSKLfpzemmgBAOsVWlm 7Ce5GnFrQGgQCD1QWwKxnV8phySihcV9tAnutpLfytVAy49mXR/pQdRPw2aC/iaib0J9iS 9MU/+n/X5Ad4jl43m4ojsk2jVodYoic5YgxLCd31rDt3tJjq+zYg1kdko4PfKQhaEkvzDz fniCWVCjJm80r9gygvMoPPSol3+vd0w5swdNgMwklx5l4UoeEZZzaCES2BX3kXDOw530my oKjsKgzoCUjRcMf+vkBtglyuB4LgufCCmHfRfqO4wjG8WAMtH1kGqxTjnnEAbdSrJNOmyX S+Uwbv5Ncfllr9J7jfyS+iG9A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id b69b93c3 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Thu, 14 Jan 2021 17:45:08 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Maxim Cournoyer Subject: Re: Behaviour change when closing laptop lid: it no longer suspends References: <87wnxfkzub.fsf@ambrevar.xyz> <87r1nnus9a.fsf@nckx> <87r1nnkuf1.fsf@ambrevar.xyz> <87a6ubf7ai.fsf@ambrevar.xyz> <87y2hunbvm.fsf@nckx> <877dpd6hph.fsf@nckx> <87turjlbzw.fsf@gmail.com> In-reply-to: <87turjlbzw.fsf@gmail.com> Date: Thu, 14 Jan 2021 18:44:37 +0100 Message-ID: <871rens9a2.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tobias Geerinckx-Rice via Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.66 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=AfI1uZCF; dmarc=pass (policy=reject) header.from=tobias.gr; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: 006469402AF X-Spam-Score: -4.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: /aacjYlMGRmO --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxim, Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > Shouldn't that be the default behavior though? That's subjective. I don't think we should ever editorialise if=20 that's what you mean: Guix service configuration wrappers should=20 strictly wrap, not tweak defaults on a (majority) whim. However, here our wrapping is wrong. Thanks for making me look=20 into it. From=20upstream's change log: The action that elogind takes when the lid is closed and the machine is connected to external power can now be configured using HandleLidSwitchExternalPower=3D in logind.conf. Previously, this action was determined by HandleLidSwitch=3D, and, for backwards compatibility, is still is, if HandleLidSwitchExternalPower=3D is not explicitly set. Whilst we: ("HandleLidSwitchExternalPower" (handle-action elogind-handle-lid-switch-external-power)) always =E2=80=98explicitly set=E2=80=99 HandleLidSwitchExternalPower, by de= fault=20 to =E2=80=98ignore=E2=80=99, breaking that intention. elogind-handle-lid-switch-external-power should not emit a=20 directive if unset. In fact, all directives and all services=20 should do that by default, *not* hard-code upstream's default at=20 an arbitrary point in time. Unfortunately most do, making subtle bugs like these more likely. > Like Pierre, I'm also certain that the default behavior was=20 > changed at > some point. I didn't find any evidence for this in the commit log but didn't=20 search exhaustively. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYACDBQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15kpcA+gM4bzRm7cq7JtZ5uq9mJtWebk1OmAB++gjBrD3l MU/TAP9PBtiSLtS3VpCpFvbmfzRBKEenT9OnI4TjSzehDu7wCw== =55Rx -----END PGP SIGNATURE----- --=-=-=--