From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ABAlKqpRiF9FegAA0tVLHw (envelope-from ) for ; Thu, 15 Oct 2020 13:42:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iBMWJqpRiF9vUAAAB5/wlQ (envelope-from ) for ; Thu, 15 Oct 2020 13:42:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3701E9404C2 for ; Thu, 15 Oct 2020 13:42:02 +0000 (UTC) Received: from localhost ([::1]:46558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT3W4-0007F4-SH for larch@yhetil.org; Thu, 15 Oct 2020 09:42:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT3Tk-0005Iz-Ab for help-guix@gnu.org; Thu, 15 Oct 2020 09:39:36 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:38847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT3Ti-0000Kv-Ee for help-guix@gnu.org; Thu, 15 Oct 2020 09:39:35 -0400 Received: by mail-wr1-x42f.google.com with SMTP id n18so3541924wrs.5 for ; Thu, 15 Oct 2020 06:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=E0nv7LOVZWQ0khjy76NqS8ocxRxrwqxSDp0HSRE2X/M=; b=StazRVCW00ER9eh6rK1GgeBPw7M7E3ikNLO5C8h8HQpLwZ7fA1FIMdiRkiaJjAGpyg CsMrG2T/SGpmxC9WuwU/a1+5YbffKcTUszAGESXSebw/HB/55n3TkMburo4oTTh4Gjdl tqtJDJ7Me8RyMPUeK4Cwz9LmAM8H7rox0wvQ5I0v3FZIQ7Z1rBarjDJGNiyeeNCc+gf8 Cd/CXcU+RTU1Nygs6B3arO89u+XPR9dWgGCa41+Pddv4wdLGd17mLNBnSjHa1JDrKunB RrJ/VaP8LJztxIsfZarzn9CWMlllLVYAn+dS0m5VUGn56KHbSvSHiOpaIC5S9nASlLrw NN2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=E0nv7LOVZWQ0khjy76NqS8ocxRxrwqxSDp0HSRE2X/M=; b=BpwmJiGmnZyw7Clei/zVL9GRoc+t6rqzttl/ZZG0yU8rvW7HoQvUphIsTUvROWW6n6 ZIPnPljuxiW60S72cA6dVBLYvEjPyvagxlzZ9tcNAmg2XjwEkJLhG4YArQH5HRU4f+XW rcIZP3yd3rdZuMsHNkDeTU24ooZxZx51X48rlQEfMq1OEJ0+un/7TsiLAlhTnNmZ15lv GEnr1djsWyX2gXAPoNDXrNh+4hDdfGDrk3DSHgiMpyu94w0d6AetGt2MvcvO2gbA9BmE jRRhkw1498ydYFft8ukPdMDS7Td2OTBsL0LxUxkRl4Hv/dJQTt9Hz5bVzlmLC2VfJoRS MBMQ== X-Gm-Message-State: AOAM533/qO1T0Pqci4TFP2ThLmkA9CECM8C2Gu0hw4szV59Keus0MyEL cfurv+1VpKFN9D5kjrHjh3OoBGBAI3I= X-Google-Smtp-Source: ABdhPJxsfaCeVHhBVC4sp8PT1Tsu4uShS6nxgbxGSaC920x1KpyFTOddWHF9V8nnIKokz38Jhv25HQ== X-Received: by 2002:adf:9461:: with SMTP id 88mr4428059wrq.307.1602769172257; Thu, 15 Oct 2020 06:39:32 -0700 (PDT) Received: from lili ([88.126.110.68]) by smtp.gmail.com with ESMTPSA id p4sm4728433wrf.67.2020.10.15.06.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 06:39:30 -0700 (PDT) From: zimoun To: Aniket Patil , help-guix@gnu.org Subject: Re: Confused while submitting patch In-Reply-To: References: Date: Thu, 15 Oct 2020 15:39:28 +0200 Message-ID: <86k0vr1ucv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=StazRVCW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: 5vcF5M0fzgWS Hi, On Thu, 15 Oct 2020 at 13:21, Aniket Patil wrot= e: > Hi all, > I am new when it comes to submitting patches through email. For my first > patch, I copied all the body from the .path file and pasted in mail. Also > from the subject line, I copied the subject and pasted it in the subject = of > my email. To be on the safer side I also attached a patch file to the > email. What is the write way? I thought submitting through email is the > easier way than submitting it to git email. Well, it depends on the tools you are working on. Let describe the workflow with plain git commands, then using Magit (the emacs porcelaine) is let as an exercise. You need =E2=80=9Cguix install guix:send-email=E2=80=9D and please read the= section Example in [1] for an easy setup. Now, you are in the fresh cloned repo and you created one branch with some new commits in. You simply do: git format-patch - --base=3Dmaster where is the number of commit you did. For example, =E2=80=99-1=E2=80= =99 for one commit, =E2=80=99-2=E2=80=99 for 2 commits, etc.. You can omit the =E2=80= =99--base=E2=80=99 but it is useful to know on which commit your commit applies. I also recommend to use the option =E2=80=99--cover-letter=E2=80=99, which allows you to descri= be your change. Please read =E2=80=9Cgit format-patch --help=E2=80=9D. Well, the =E2=80=99format-patch=E2=80=99 command should produce: 0000-cover-letter.patch 0001-blabla.patch Then, it is easy: git send-email --to=3Dguix-patches@gnu.org 0000-cover-letter.patch assuming you used the =E2=80=99--cover-letter=E2=80=99 option. :-) Then yo= u wait a bit that the robot assigns a Patch number. Check your inbox; if everything is correctly setup-ed. You can send your patch with: git send-email --to=3D123456@debbugs.gnu.org 0001-blabla.patch Done! For patch set (several commits), you replace the last command by: git send-email --to=3D123456@debbugs.gnu.org 000?-*.patch So good, so far. After the review, you will have modification to do, so you =E2=80=9Crebase interactively=E2=80=9D (git rebase -i) and you tweak. Once it is ready to = send the new version of your patch, you have to generate a new one: git format-patch - -v2 here, you can omit =E2=80=99--cover-letter=E2=80=99. This will produce: v2-0001-blabla.patch and let send it: git send-email --to=3D123456@debbugs.gnu.org v2-0001-blabla.patch It is important to keep the same patch number. Please give a look at for all the patches. Does that help? All the best, simon 1: