Re: Packaging Proton Bridge: Progress Report #1

["Marek Paśnikowski" <marek@marekpasnikowski.pl>]

[-- Attachment #1: Type: text/plain, Size: 9001 bytes --]

On poniedziałek, 9 grudnia 2024 17:52:36 CET you wrote:
> Hi Marek,
> 
> On Mon, Dec 9, 2024, at 4:47 PM, Marek Paśnikowski wrote:
> > Does this mean I will have to `make` the project before `building go`?
> 
> I'm not sure how the go-build-system interacts with stuff like this, or what
> complexity the Makefile may bring.  Probably the simplest thing is to add a
> build phase which executes the utility script at the corresponding point in
> your build, but this is ultimately your judgement call.
> 
>   -- Ian

I copied and extended the invocation of "make" from the gnu-build-system:
(arguments
  (list
    #:phases '(modify-phases
               %standard-phases
               (add-before
                 'build
                 'make-project
                 (lambda*
                   (#:key (make-flags (list "build-nogui"))
                          (parallel-build? #t)
                    #:allow-other-keys)
                   (invoke "find"
                           "."
                           "-name"
                           "Makefile")
                   (invoke "ls"
                           "-al"
                           "./src/github.com/ProtonMail/proton-bridge/v3")
                   (apply invoke
                          "make"
                          "-e"
                          "-C"
                          "./src/github.com/ProtonMail/proton-bridge/v3"
                          "--debug=basic"
                          `(,@(if parallel-build?
                                `("-j" ,(number->string (parallel-job-count)))
                                '())
                           ,@make-flags)))))
    #:embed-files '(list "children" "nodes" "text")
    #:unpack-path "github.com/ProtonMail/proton-bridge/v3"
    #:import-path "github.com/ProtonMail/proton-bridge/v3/cmd/Desktop-
Bridge"))

I am getting some kind of progress, pasted below.  Before continuing, I would 
appreciate confirmation whether I am on the right track.  Some lines in the 
output state that some files do not exist.  Having no experience actually 
working with make files, I am not sure if this is expected.

Should I not worry about the "file does not exist" message class?
Should I change anything in my invocation of "make"?

starting phase `make-project'
./src/github.com/flynn-archive/go-shlex/Makefile
./src/github.com/chzyer/logex/Makefile
./src/github.com/yuin/goldmark/Makefile
./src/github.com/yuin/goldmark/_benchmark/cmark/Makefile
./src/github.com/hashicorp/go-multierror/Makefile
./src/github.com/cpuguy83/go-md2man/Makefile
./src/github.com/vmihailenco/tagparser/v2/Makefile
./src/github.com/vmihailenco/msgpack/v5/Makefile
./src/github.com/getsentry/sentry-go/Makefile
./src/github.com/mattn/go-sqlite3/_example/mod_vtable/Makefile
./src/github.com/mattn/go-sqlite3/_example/custom_driver_name/Makefile
./src/github.com/mattn/go-sqlite3/_example/mod_regexp/Makefile
./src/github.com/prometheus/procfs/Makefile
./src/github.com/Masterminds/semver/v3/Makefile
./src/github.com/elastic/go-sysinfo/Makefile
./src/github.com/cloudflare/circl/Makefile
./src/github.com/pkg/errors/Makefile
./src/github.com/ProtonMail/proton-bridge/v3/Makefile
./src/google.golang.org/grpc/Makefile
./src/golang.org/x/text/collate/tools/colcmp/Makefile
total 368
drwxr-xr-x 12 nixbld nixbld   4096 Jan  1  1970 .
drwxr-xr-x  3 nixbld nixbld   4096 Dec  9 18:55 ..
-r--r--r--  1 nixbld nixbld     26 Jan  1  1970 .gitattributes
drwxr-xr-x  3 nixbld nixbld   4096 Jan  1  1970 .github
-r--r--r--  1 nixbld nixbld    576 Jan  1  1970 .gitignore
-r--r--r--  1 nixbld nixbld   1469 Jan  1  1970 .gitlab-ci.yml
-r--r--r--  1 nixbld nixbld     98 Jan  1  1970 .gitmodules
-r--r--r--  1 nixbld nixbld  10074 Jan  1  1970 .golangci.yml
-r--r--r--  1 nixbld nixbld    131 Jan  1  1970 .grype.yaml
-r--r--r--  1 nixbld nixbld   3052 Jan  1  1970 BUILDS.md
-r--r--r--  1 nixbld nixbld    498 Jan  1  1970 CONTRIBUTING.md
-r--r--r--  1 nixbld nixbld  18002 Jan  1  1970 COPYING_NOTES.md
-r--r--r--  1 nixbld nixbld 118347 Jan  1  1970 Changelog.md
-r--r--r--  1 nixbld nixbld  32473 Jan  1  1970 LICENSE
-r--r--r--  1 nixbld nixbld  16157 Jan  1  1970 Makefile
-r--r--r--  1 nixbld nixbld   4695 Jan  1  1970 README.md
-r--r--r--  1 nixbld nixbld    141 Jan  1  1970 TODO.md
drwxr-xr-x  2 nixbld nixbld   4096 Jan  1  1970 ci
drwxr-xr-x  4 nixbld nixbld   4096 Jan  1  1970 cmd
drwxr-xr-x  3 nixbld nixbld   4096 Jan  1  1970 dist
drwxr-xr-x  3 nixbld nixbld   4096 Jan  1  1970 extern
-r--r--r--  1 nixbld nixbld   6641 Jan  1  1970 go.mod
-r--r--r--  1 nixbld nixbld  74635 Jan  1  1970 go.sum
drwxr-xr-x 35 nixbld nixbld   4096 Jan  1  1970 internal
drwxr-xr-x 14 nixbld nixbld   4096 Jan  1  1970 pkg
drwxr-xr-x  2 nixbld nixbld   4096 Jan  1  1970 release-notes
drwxr-xr-x  7 nixbld nixbld   4096 Jan  1  1970 tests
drwxr-xr-x 14 nixbld nixbld   4096 Dec  9 18:55 utils
GNU Make 4.4.1
Built for x86_64-unknown-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
make: Entering directory '/tmp/guix-build-go-github-com-protonmail-proton-
bridge-3.15.1.drv-0/src/github.com/ProtonMail/proton-bridge/v3'
Updating makefiles....
Updating goal targets....
 File 'build-nogui' does not exist.
  File 'proton-bridge' does not exist.
   File 'gofiles' does not exist.
    File 'internal/bridge/credits.go' does not exist.
   Must remake target 'internal/bridge/credits.go'.
cd ./utils/ && ./credits.sh bridge
  File 'build-launcher' does not exist.
 Must remake target 'build-launcher'.
go build -tags='' -ldflags '-X github.com/ProtonMail/proton-bridge/v3/
internal/constants.Version=3.15.1+git -X github.com/ProtonMail/proton-bridge/
v3/internal/constants.Revision=NOGIT -X github.com/ProtonMail/proton-bridge/
v3/internal/constants.Tag=NOGIT -X github.com/ProtonMail/proton-bridge/v3/
internal/constants.BuildTime=2024-12-09T18:55:33+0000 -X "github.com/
ProtonMail/proton-bridge/v3/internal/constants.FullAppName=Proton Mail Bridge" 
-X github.com/ProtonMail/proton-bridge/v3/internal/constants.BuildEnv=dev' -o 
"proton-bridge" "/tmp/guix-build-go-github-com-protonmail-proton-
bridge-3.15.1.drv-0/src/github.com/ProtonMail/proton-bridge/v3/cmd/launcher/"
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
 File 'build-nogui' does not exist.
  File 'proton-bridge' does not exist.
   File 'gofiles' does not exist.
  Must remake target 'gofiles'.
  Successfully remade target file 'gofiles'.
 Must remake target 'proton-bridge'.
go build -tags='' -ldflags '-X github.com/ProtonMail/proton-bridge/v3/
internal/constants.Version=3.15.1+git -X github.com/ProtonMail/proton-bridge/
v3/internal/constants.Revision=NOGIT -X github.com/ProtonMail/proton-bridge/
v3/internal/constants.Tag=NOGIT -X github.com/ProtonMail/proton-bridge/v3/
internal/constants.BuildTime=2024-12-09T18:55:33+0000 -X "github.com/
ProtonMail/proton-bridge/v3/internal/constants.FullAppName=Proton Mail Bridge" 
-X github.com/ProtonMail/proton-bridge/v3/internal/constants.BuildEnv=dev' -o 
"proton-bridge" "./cmd/Desktop-Bridge/"
 File 'build-nogui' does not exist.
# github.com/ProtonMail/proton-bridge/v3/internal/app
internal/app/app.go:105:2: unknown field DisableDefaultText in struct literal 
of type "github.com/urfave/cli/v2".BoolFlag
internal/app/app.go:113:2: unknown field DisableDefaultText in struct literal 
of type "github.com/urfave/cli/v2".BoolFlag
internal/app/app.go:170:4: unknown field DisableDefaultText in struct literal 
of type "github.com/urfave/cli/v2".BoolFlag
internal/app/app.go:176:4: unknown field DisableDefaultText in struct literal 
of type "github.com/urfave/cli/v2".BoolFlag
internal/app/app.go:182:4: unknown field DisableDefaultText in struct literal 
of type "github.com/urfave/cli/v2".BoolFlag
internal/app/app.go:212:3: unknown field DisableDefaultText in struct literal 
of type "github.com/urfave/cli/v2".BoolFlag
make: *** [Makefile:111: proton-bridge] Error 1
make: Leaving directory '/tmp/guix-build-go-github-com-protonmail-proton-
bridge-3.15.1.drv-0/src/github.com/ProtonMail/proton-bridge/v3'
error: in phase 'make-project': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("-e" "-C" "./src/
github.com/ProtonMail/proton-bridge/v3" "--debug=basic" "-j" "4" "build-
nogui") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `make-project' failed after 74.2 seconds
command "make" "-e" "-C" "./src/github.com/ProtonMail/proton-bridge/v3" "--
debug=basic" "-j" "4" "build-nogui" failed with status 2

-- Marek Pasnikowski

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]