From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id bO5cJzkY82DlvgAAgWs5BA (envelope-from ) for ; Sat, 17 Jul 2021 19:49:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id e0t4IjkY82DVOAAAB5/wlQ (envelope-from ) for ; Sat, 17 Jul 2021 17:49:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 244C319F92 for ; Sat, 17 Jul 2021 19:49:45 +0200 (CEST) Received: from localhost ([::1]:40708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4oRc-0004VO-8C for larch@yhetil.org; Sat, 17 Jul 2021 13:49:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4oRT-0004V0-8q for help-guix@gnu.org; Sat, 17 Jul 2021 13:49:35 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:50863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4oRQ-0006u9-LR for help-guix@gnu.org; Sat, 17 Jul 2021 13:49:35 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 53617240003; Sat, 17 Jul 2021 17:49:27 +0000 (UTC) From: brice@waegenei.re In-Reply-To: <87pmvglyag.fsf@latte.josefsson.org> Content-Type: text/plain; charset="utf-8" X-Forward: 127.0.0.1 Date: Sat, 17 Jul 2021 19:49:27 +0200 To: "Simon Josefsson" MIME-Version: 1.0 Message-ID: <3987-60f31800-ed-3bd98f40@168269356> Subject: =?utf-8?q?Re=3A?= 'guix reconfigure' fail to build 'rsnapshot' User-Agent: SOGoMail 5.1.1 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.178.230; envelope-from=brice@waegenei.re; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: help-guix@gnu.org Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626544185; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=kvoaIlDK/vN4fTQ12bUr1ozN1LQqAj//SCJw6nXDvWY=; b=BOJHEWWqiapG4guwP6n51aZKUwONKokL3SjVaOBOv7iToYFZFzgMLkmrNjaBGQ5J+CJ2Ep YVx5SR2k1fZNcYfBRYZiE3c9uXfErzhORrwOIg7c7kw3NhwHARZINggT3IJFwyoEvXpU3B dqdUS0Jnu0ILJCNMoEl/4Y9afkYQO7+OjyJwasugzWQNcVdqu6+HqPBDjBdHzglJ5Xeqpk ZNnQQjjg55hDhCrllMBCe9RNSj92JkmTkQQWRsJ1KgKI3GjGaqbDqnBKoB70xA2itfSGQp LIbH+39NVmaJbUGsQrjHq4uGKRFKmtMSGPz3dD+AyX71VYNHUg5Znh34boim1g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626544185; a=rsa-sha256; cv=none; b=TSuIjl2WuV7ljQINwXMBDXBJxi61A6+n/wQKxr9DA4dv7ngyh1ipHrK+yHkMkMYRB+n4JS FZbAUebK5e4PzKdoJOoBqyPo/GzPmV7iAXCYGWXrUE7gQMgym9UkzYy7KDzwjTtIEtWqUu iEtJY9RHeTFetS+ytLwSt8W2Gz1YVEAHFnQU9ot3+ygb/ZApwjdTfEw0cfhrzuCSRtc3Ma gOPQW2+pGL9qSQ5VXjJLkZdjff3RMEHYx2wHKKj6UTmqYFJhZhnFJp80JZxeKCxPUzHNx0 khTun8QEqsTgi6vGPnVTWV7s+a7LIo4Bad0+7DmDnu692voRnOZKkGVnkpVGug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Spam-Score: -0.71 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: 244C319F92 X-Spam-Score: -0.71 X-Migadu-Scanner: scn0.migadu.com X-TUID: +vFZ7D+SSEnk Hello Simon, On 17 July, 2021 18:07 CEST, Simon Josefsson via wr= ote: > How can I fix this? Is this something unique on my machine, or does = it > indicate a bug in the packaging of 'rsnapshot'? I'm not sure how to > proceed with debugging. Let's see, Cuirass says this packaged failed to build since the 20th of= June=C2=B9 on the branch master for all the systems. So it's not just y= ou that aren't able to build it. The build for x86=5F64=5Flinux=C2=B2, is for the version 1.4.4 of rsnap= shot and we also see that the previous successfully build (and the only one) date f= rom March 11 for version 1.4.3 and dependencies haven't changed between tho= se tow build. So an update of the package from 1.4.3 to 1.4.4 probably cau= sed that. If we want to find that specific commit, this build is part of the evaluation #50819=E2=81=B4for the commit d027858e70c4a37aca90b1d4ecb2f0= 421a95d987=E2=81=B5. The great-father of that commit is the one updating rsnapshot =E2=80=9C= gnu: rsnapshot: Update to 1.4.4.=E2=80=9D=E2=81=B6. Now that we know what br= oke the package, just a plain update, we can start trying to fix the failing build. First we go back to our failing build=C2=B2 and have a look in its log=E2= =81=B7. At the end of it there is 2 failing tests t/backup=5Fexec/backup=5Fexec.t and t/cmd-post=5Fpre-exec/cmd-post=5Fpre-exec.t. That's what we need to rep= air or disable. Now we need to build it locally and inspect it more in depth, = we do that with =E2=80=9Cguix build rsnapshot --keep-failed --no-offload=E2= =80=9D and obviously it fail as expected and guix guide us to the build directory =E2=80=9C/tmp/guix-build-rsnapshot-1.4.4.drv-1=E2=80=9D. To find out why thoses 2 tests ae failing we are gonna run them manuall= y. We change directory to =E2=80=9C/tmp/guix-build-rsnapshot-1.4.4.drv-0/rsnapshot-1.4.4=E2=80=9D= the failed build and find the build =E2=80=9Crsnapshot=E2=80=9C program in it but it's n= ot executable, so we make it so =E2=80=9Cchmod +x rsnapshot=E2=80=9D. Then we inspect the bu= ild tests --8<---------------cut here---------------start------------->8--- $ cat t/backup=5Fexec/backup=5Fexec.t #!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl use strict; use Test::More tests =3D> 2; use SysWrap; # Ensure passing behavior ok(2 =3D=3D rsnapshot("-c /tmp/guix-build-rsnapshot-1.4.4.drv-0/rsnapsh= ot-1.4.4//t//backup=5Fexec/conf/backup=5Fexec.conf hourly")); # Ensure failing behavior ok(1 =3D=3D rsnapshot("-c /tmp/guix-build-rsnapshot-1.4.4.drv-0/rsnapsh= ot-1.4.4//t//backup=5Fexec/conf/backup=5Fexec=5Ffail.conf hourly")); --8<---------------cut here---------------end--------------->8--- Seems that it just call rsnapshot with some argument, let's do it manua= lly: --8<---------------cut here---------------start------------->8--- $ ./rsnapshot -c /tmp/guix-build-rsnapshot-1.4.4.drv-0/rsnapshot-1.4.4/= /t//backup=5Fexec/conf/backup=5Fexec.conf hourly drwxr-xr-x 1 root root 16 06-05 15:11 /usr hello world! hello world! Can't exec "/gnu/store/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/= gnu/store/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/bin/true": No= such file or directory at ./rsnapshot line 4427. -----------------------------------------------------------------------= ----- rsnapshot encountered an error! The program was invoked with these opti= ons: ./rsnapshot -c \ /tmp/guix-build-rsnapshot-1.4.4.drv-0/rsnapshot-1.4.4//t//backup=5F= exec/conf/backup=5Fexec.conf \ hourly -----------------------------------------------------------------------= ----- ERROR: get=5Fretval() was passed -1, a number is required --8<---------------cut here---------------end--------------->8--- It is the path to "true" which is wrong, it contains =E2=80=9C/gun/stor= e=E2=80=9D twice: =C2=AB /gnu/store/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/gnu/s= tore/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/bin/true =C2=BB. The configure script did not build that path properly by itself, maybe = we can specify it directly. If we have a look to the rsnapshot definition=E2=81= =B8 we see the "check" phase modifying the path for those program; while the changelog= for 1.4.4=E2=81=B9 say the added option for setting their paths =C2=AB = - Minor tidy up rel configure options --with-test-(true|false). Refs #189 (#248) =C2=BB. Maybe removing our substitution will fix our build issue: --8<---------------cut here---------------start------------->8--- @@ -526,15 +526,6 @@ rdiff-backup is easy to use and settings have sens= ible defaults.") (modify-phases %standard-phases (replace 'check (lambda =5F - (substitute* '("t/cmd-post=5Fpre-exec/conf/pre-true-post-= true.conf" - "t/backup=5Fexec/conf/backup=5Fexec=5Ffail= .conf" - "t/backup=5Fexec/conf/backup=5Fexec.conf")= - (("/bin/true") (which "true")) - (("/bin/false") (which "false"))) - - ;; Disable a test that tries to connect to localhost on p= ort 22. - (delete-file "t/ssh=5Fargs/ssh=5Fargs.t.in") - (invoke "make" "test")))))) (inputs `(("perl" ,perl) --8<---------------cut here---------------end--------------->8--- Oh! It worked, nice! I'll push it later. On 17 July, 2021 18:07 CEST, Simon Josefsson via wr= ote: > How come others haven't noticed this, aren't all packages built > centrally to make sure things build? Guix's QA is a work in progress. I hope this long explanation can help = you do the same for the inevitable new failing build you will encounter. =C2=B9 http://ci.guix.gnu.org/search?query=3Drsnapshot =C2=B2 http://ci.guix.gnu.org/build/619949/details =C2=B3 http://ci.guix.gnu.org/build/44883/details =E2=81=B4http://ci.guix.gnu.org/eval/50819 =E2=81=B5 https://git.savannah.gnu.org/cgit/guix.git/log/?id=3Dd027858e= 70c4a37aca90b1d4ecb2f0421a95d987 =E2=81=B6 https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Ddf68e= 5c65ae015639566baf5cce1faf96a2d0ed4 =E2=81=B7 http://ci.guix.gnu.org/build/619949/log/raw =E2=81=B8 https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/= backup.scm#n527 =E2=81=B9 https://github.com/rsnapshot/rsnapshot/blob/master/ChangeLog#= L15 Cheers, - Brice