unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
* Nicest way to send and apply Guix patchsets via magit?
@ 2020-08-16 16:06 Christopher Lemmer Webber
  2020-08-16 16:34 ` John Soo
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Lemmer Webber @ 2020-08-16 16:06 UTC (permalink / raw)
  To: help-guix

I know a number of developers of guix here are also Magit fans.

When you have a patchset, how do you usually send it... and in the
reverse direction, how do you usually go about applying a patchset?  I'm
going to admit awkwardly that what I've done historically is generate
patches one by one and manually start a thread but it's obviously
suboptimal.

(I also use mu4e.)

Not urgent, just wondering!  There has to be a better way than what I've
done. ;)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Nicest way to send and apply Guix patchsets via magit?
  2020-08-16 16:06 Nicest way to send and apply Guix patchsets via magit? Christopher Lemmer Webber
@ 2020-08-16 16:34 ` John Soo
  2020-08-22 10:45   ` Pierre Neidhardt
  0 siblings, 1 reply; 4+ messages in thread
From: John Soo @ 2020-08-16 16:34 UTC (permalink / raw)
  To: Christopher Lemmer Webber; +Cc: help-guix

Hi Christopher,

I usually use the log in Magit, highlight the commits I want and then use W c c to create a patch set. I submit them as attachments on one email usually (I use dired and gnus for that). I know threading (one patch per email) works better with tools like patchwork but I don’t want to drop to git send-mail.

One caveat is that I’m not sure how well my patch sets are received. I will accept any criticism there. 

Curious to know how others work,

John

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Nicest way to send and apply Guix patchsets via magit?
  2020-08-16 16:34 ` John Soo
@ 2020-08-22 10:45   ` Pierre Neidhardt
  2020-08-22 12:12     ` Christopher Lemmer Webber
  0 siblings, 1 reply; 4+ messages in thread
From: Pierre Neidhardt @ 2020-08-22 10:45 UTC (permalink / raw)
  To: John Soo, Christopher Lemmer Webber; +Cc: help-guix

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

For me, "git send-email" unpredictably drops some patches without
notice.  I don't know if it's a bug with our package or with upstream.

About Magit, I'd also recommend to "insert base commit" when creating
the patchset.  Something like "W c C-m b ... c".

Cheers!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Nicest way to send and apply Guix patchsets via magit?
  2020-08-22 10:45   ` Pierre Neidhardt
@ 2020-08-22 12:12     ` Christopher Lemmer Webber
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Lemmer Webber @ 2020-08-22 12:12 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: help-guix

Thank you to both of you!  I will give these approaches a try.

Pierre Neidhardt writes:

> For me, "git send-email" unpredictably drops some patches without
> notice.  I don't know if it's a bug with our package or with upstream.
>
> About Magit, I'd also recommend to "insert base commit" when creating
> the patchset.  Something like "W c C-m b ... c".
>
> Cheers!



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-22 12:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16 16:06 Nicest way to send and apply Guix patchsets via magit? Christopher Lemmer Webber
2020-08-16 16:34 ` John Soo
2020-08-22 10:45   ` Pierre Neidhardt
2020-08-22 12:12     ` Christopher Lemmer Webber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).