unofficial mirror of help-guix@gnu.org 
 help / color / mirror / Atom feed
From: ison <ison@airmail.cc>
To: Tilman List <tilman.list@posteo.de>
Cc: help-guix@gnu.org
Subject: Re: Version of package fontforge
Date: Thu, 6 Jun 2019 22:53:12 -0600	[thread overview]
Message-ID: <20190607045311.2aiuulc5f6p6eibk@cf0> (raw)
In-Reply-To: <c0f3345fb1355e97b9989d9545e1fb7c1781176c.camel@posteo.de>

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

Here's a patch to set the version date based on the packages version string.
I also added a comment above the version to note that the version date depends
on its format, in case it ever changes in the future.

Does someone want to look it over and make sure it looks ok, and follows the
right conventions?

[-- Attachment #2: 0001-Fix-fontforge-source-date-epoch.patch --]
[-- Type: text/plain, Size: 1497 bytes --]

From e2fe29485a1f65d65fd7db5b6111d4cfe8ca1485 Mon Sep 17 00:00:00 2001
From: ison <ison@airmail.cc>
Date: Thu, 6 Jun 2019 22:46:12 -0600
Subject: [PATCH] Fix fontforge source date epoch

---
 gnu/packages/fontutils.scm | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index 1982d0bf4b..44107277cb 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -555,6 +555,8 @@ definitions.")
 (define-public fontforge
   (package
    (name "fontforge")
+   ;; SOURCE_DATE_EPOCH generated from version string
+   ;; expects format YYYYMMDD
    (version "20190317")
    (source (origin
             (method url-fetch)
@@ -592,7 +594,18 @@ definitions.")
              ("python"          ,python-2)
              ("zlib"            ,zlib)))
    (arguments
-    '(#:phases
+    `(#:modules ((guix build utils)
+                 (guix build gnu-build-system)
+                 (srfi srfi-19))
+      #:configure-flags
+      (list (format #f "SOURCE_DATE_EPOCH=~a"
+                    (time-second
+                      (date->time-utc
+                        (string->date
+                          (string-append ,version
+                                         "-0000")
+                          "~Y~m~d~z")))))
+      #:phases
       (modify-phases %standard-phases
         (add-after 'install 'set-library-path
           (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.21.0


  parent reply	other threads:[~2019-06-07  4:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 10:41 Version of package fontforge Tilman List
2019-06-05 10:07 ` Ricardo Wurmus
2019-06-06  5:51   ` ison
2019-06-07  4:53 ` ison [this message]
2019-06-11 10:20   ` Ludovic Courtès
2019-06-28 21:06   ` Tilman List

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607045311.2aiuulc5f6p6eibk@cf0 \
    --to=ison@airmail.cc \
    --cc=help-guix@gnu.org \
    --cc=tilman.list@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).