Moving packages over to new module

Moving packages over to new module

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hello,

I've added a new (gnu packages emulators) module. As a result a few
existing packages from (gnu packages games) should be moved over.

At first glance, this includes:
desmume
dosbox
emulation-station
higan
mgba
mupen64plus*
nestopia-ue  
retroarch

I'm a little unsure about how to handle the existing copyright notices
however. What's the usual procedure for moving packages over?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Moving packages over to new module

[ng0]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

Rutger Helling transcribed 1.1K bytes:
> Hello,
> 
> I've added a new (gnu packages emulators) module. As a result a few
> existing packages from (gnu packages games) should be moved over.
> 
> At first glance, this includes:
> desmume
> dosbox
> emulation-station
> higan
> mgba
> mupen64plus*
> nestopia-ue  
> retroarch
> 
> I'm a little unsure about how to handle the existing copyright notices
> however. What's the usual procedure for moving packages over?

The usual procedure to respect the people who contributed to the packages
is to move their copyright lines into the new module.

You can look at the output of git log for the module or use other tools
git provides for this.

-- 
ng0 :: https://crash.cx
A88C8ADD129828D7EAC02E52E22F9BBFEE348588 :: https://crash.cx/keys/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Moving packages over to new module

[Ricardo Wurmus]

Hi Rutger,

> I've added a new (gnu packages emulators) module. As a result a few
> existing packages from (gnu packages games) should be moved over.
>
> At first glance, this includes:
> desmume
> dosbox
> emulation-station
> higan
> mgba
> mupen64plus*
> nestopia-ue
> retroarch

Looks good to me.

> I'm a little unsure about how to handle the existing copyright notices
> however. What's the usual procedure for moving packages over?

We need to move the copyright notices as well.  For that I usually look
at the git log for the packages that should be moved.  Since we’re using
predictable commit messages this can easily be grep’ed from the git log.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Moving packages over to new module

[Andreas Enge]

On Thu, Feb 22, 2018 at 10:57:06AM +0100, Ricardo Wurmus wrote:
> We need to move the copyright notices as well.  For that I usually look
> at the git log for the packages that should be moved.  Since we’re using
> predictable commit messages this can easily be grep’ed from the git log.

This would require to also look at all the other packages in the module,
to decide whether the copyright notice should be moved or copied.
Maybe "git blame MODULE.scm" could also be helpful in that respect:
If used after the packages have been moved, it shows who has contributed
to the remaining packages.

Andreas

Re: Moving packages over to new module

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

I ended up using git log --grep=.... and have moved the packages. Using
'git blame' I found that a few copyright lines can be removed from
games.scm now. If a person has only imported a module ((gnu packages
base) for example), should I keep the copyright notice or lose it?

On Thu, 22 Feb 2018 11:43:51 +0100
Andreas Enge <andreas@enge.fr> wrote:

> On Thu, Feb 22, 2018 at 10:57:06AM +0100, Ricardo Wurmus wrote:
> > We need to move the copyright notices as well.  For that I usually
> > look at the git log for the packages that should be moved.  Since
> > we’re using predictable commit messages this can easily be grep’ed
> > from the git log.  
> 
> This would require to also look at all the other packages in the
> module, to decide whether the copyright notice should be moved or
> copied. Maybe "git blame MODULE.scm" could also be helpful in that
> respect: If used after the packages have been moved, it shows who has
> contributed to the remaining packages.
> 
> Andreas
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Moving packages over to new module

[Andreas Enge]

On Thu, Feb 22, 2018 at 12:33:22PM +0100, Rutger Helling wrote:
> I ended up using git log --grep=.... and have moved the packages. Using
> 'git blame' I found that a few copyright lines can be removed from
> games.scm now. If a person has only imported a module ((gnu packages
> base) for example), should I keep the copyright notice or lose it?

That is always a good question. I think importing a module is not copy-
rightable, so I would drop the line.

Personally I also do not add my copyright when simply updating a package
(new version and hash), unless more complex changes are required.

Andreas

Re: Moving packages over to new module

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

Alright, I've done so. The migration should now be complete. Thanks for
the help!

On Thu, 22 Feb 2018 12:51:43 +0100
Andreas Enge <andreas@enge.fr> wrote:

> On Thu, Feb 22, 2018 at 12:33:22PM +0100, Rutger Helling wrote:
> > I ended up using git log --grep=.... and have moved the packages.
> > Using 'git blame' I found that a few copyright lines can be removed
> > from games.scm now. If a person has only imported a module ((gnu
> > packages base) for example), should I keep the copyright notice or
> > lose it?  
> 
> That is always a good question. I think importing a module is not
> copy- rightable, so I would drop the line.
> 
> Personally I also do not add my copyright when simply updating a
> package (new version and hash), unless more complex changes are
> required.
> 
> Andreas
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]