From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id LJx7AKVR/mAvZQEAgWs5BA (envelope-from ) for ; Mon, 26 Jul 2021 08:09:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4N5jN6RR/mD8VAAAB5/wlQ (envelope-from ) for ; Mon, 26 Jul 2021 06:09:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C29F103B1 for ; Mon, 26 Jul 2021 08:09:40 +0200 (CEST) Received: from localhost ([::1]:50064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7to2-0000TC-2c for larch@yhetil.org; Mon, 26 Jul 2021 02:09:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7tns-0000Sp-RI for help-guix@gnu.org; Mon, 26 Jul 2021 02:09:29 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:39665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7tnq-0004js-4R for help-guix@gnu.org; Mon, 26 Jul 2021 02:09:28 -0400 Date: Mon, 26 Jul 2021 06:09:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1627279763; bh=pz6vy3wo2BhSfdFCefXew064YyWstkQha81Q7cnDWek=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=QvuO9eFPbkzx3gtv8v7+42h7B69NXrVMF8NGDwerXgtk5uuvxxzvFX+fN1T+CHEKO TTQdVCxePpCfFu/Kp0NDSnBP5gRbEeoe9em3nuoobPpUi3eLx8oZKCXo97hJXtjHpa tE9tIByJLlMClt7a2up/WUNpwMqzLCZKRGBDUcgw= To: help-guix@gnu.org From: phodina Cc: Tobias Geerinckx-Rice Subject: Re: Packaging hwinfo Message-ID: <2-Md908t7y8BnOI9frjjoPdQhb7Ho0zDnq6IQhMV7Evcx1pPPZODlbpwmALF9nWT7rqG50za8uOYej34ux-TpSwwNjnZrX6RXi7O3vVTcgI=@protonmail.com> In-Reply-To: <0ff93c0059ca0941f404b52409c19b2c@tobias.gr> References: <0ff93c0059ca0941f404b52409c19b2c@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.134; envelope-from=phodina@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627279780; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=pz6vy3wo2BhSfdFCefXew064YyWstkQha81Q7cnDWek=; b=jk1D+pHr28hblYd/ylEJVVAMV19W4RHdgg/cz7RU/xL3uuhQ0tcV2MGRhzolUjPEkhJ1VQ YrbV0B3+sK/HRhBcHERJzjhNpjAcUp/7GP9hQvT9KdRwuKY4VRrAvuhOO7nqV/0LKmI8Tp pBDCxur1BcNHu8qhSQIFnDUp0A/pWLs10v+cKGtptY0ytVyh9FxAXB23zl30V+azJe5JMt sF2xO4cfYrN0vLVXGVTFKq0R4QPA/Qe5uWsj2Q6DQObkbt1FTZciFDMA3nK5MbXwIDc8FJ ORNx/GG+PUDVkGswMXW3IMOmMGnFhoFiIFdLqddtLXdJMbZbFpNvVpBZTOO4Ag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627279780; a=rsa-sha256; cv=none; b=eUTsyyD3W3iiisxolX88gPgYyjMEWVjRf9sFTNmWc+9CUF+mk4Eqfn4IVWPKBEtkOzU3Pt eg1UQwofPeVsRlQWh10Si7tfz9szpRUDR5EzNgATyqdxJqw1LSNO6VaExYYmpUKzCLojh+ afYAw046ZIQsTpeXTFr1QKOhk618vPBjb3kTAnsfYSxgDEtJVBnkHpVvjLuHhqJnmMxRme snkKXIelqkYIqCRCzmzMuRdLZWu/OwP8Xk5FFnUe8E9LdplNGO0FNtS/ru/2dLFyswEpUp kLu6KN+sU07HcuOpvyYtJFqjkSYTYJKGjftzzUGNtjASaWbhhK07SSd7CYk7KQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=QvuO9eFP; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=QvuO9eFP; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: 2C29F103B1 X-Spam-Score: -3.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: 63n8Eqg+HeWj > Petr, > > > Besides I also opened an issue > > Thanks! A good reflex, whether or not upstream cares or notices. > Well my point here is that the issue concerning the project itself should b= e reported e.g. what are the instructions to build it by hand. However, when comes to the packaging then it's obvious not a problem of the= project itself and therefore I ask on this mailing list. > Please share packages in a form that can easily be built by others. I > > added missing module imports and changed a forgotten /usr/lib to /lib. > Good point and my apologizes for that. > Please also place {native-,}inputs after arguments. Phases need no > > longer return #t. > Thanks. Fixed. > > CFLAGS+=3D"-fPIC -I$srcdir/$pkgname/src/hd -w" > > This does not look relevant, so I didn't add it anywhere. > > > starting phase `build' > > > > gcc -c -O2 -Wall -Wno-pointer-sign -pipe -g > > > > -I/tmp/guix-build-hwinfo-21.75.drv-0/source/src/hd -Lsrc hwinfo.c > > > > make: *** No rule to make target > > > > '/tmp/guix-build-hwinfo-21.75.drv-0/source/src/libhd.a', needed by > > > > 'hwinfo'. Stop. > > > > The build continues > > And how: > > make: *** Waiting for unfinished jobs.... > > make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent > > make rule. > > make[1]: Entering directory > > '/tmp/guix-build-hwinfo-21.75.drv-0/source/src' > > make[2]: Entering directory > > '/tmp/guix-build-hwinfo-21.75.drv-0/source/src/hd' > > i.e.: "Oh no, you made some mistake, I can't make libhd! Anyway, before > > I perish dramatically, let's chdir into this here 'src/hd' directory and > > make whatever's there. =C2=AF\( =E3=83=84 )/=C2=AF I'm sure it won't be r= elevant lol." > > That's one bug that only upstream can fix. For now, set > > "#:parallel-build? #f" (with a detailed comment!) and you'll be on your Turning off the parallel build fixes the issue. But it's still a bug as the= target src/libhd.a is "not relevant". I'll update the ticket on upstream w= ith the findings. Thanks Tobias. > > merry, slow, way. Alas: > > > /gnu/store/74ldv6c74gslx5irsa0a8kn54yi4gc3h-hwinfo-21.75/bin/hwinfo: > > > > error: depends on 'libhd.so.21', which cannot be found in RUNPATH > > Weird, but (search for '-Wl,-rpath' in Guix) it happens. Let's--no, > > wait a minute, strange things are afoot: > > tree /gnu/store/74ldv6c74gslx5irsa0a8kn54yi4gc3h-hwinfo-21.75 > > =E2=94=9C=E2=94=80=E2=94=80 bin > > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 check_hd > > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 convert_hd > > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 getsysinfo > > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 hwinfo > > =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 mk_isdnhwdb > > =E2=94=9C=E2=94=80=E2=94=80 gnu > > =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 store > > =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 74ldv6c74gslx5irsa0a8kn= 54yi4gc3h-hwinfo-21.75 > > =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 lib > > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 libhd.so -> libhd.so.21 > > [...] > > Afootness intensifies: > > > (string-append "DESTDIR=3D" %output) > > Seeing DESTDIR=3D is never a good sign (I didn't check whether its use in > > libx86emu is warranted or not). Let's stick with hwinfo & peer into its Nope, but then again let's create a ticket upstream with the fix. > > Makefile again: > > > ULIBDIR =3D $(LIBDIR) > > > > [...] > > > > install -d -m 755 $(DESTDIR)/sbin $(DESTDIR)/usr/sbin \ > > > > $(DESTDIR)$(ULIBDIR) > > Really? No support for the standard $prefix variable? Cool. > > Making LIBDIR 'relative' works around that. Not the rpath issue, so: > > > "LIBDIR=3D/lib" > > > > (string-append "LDFLAGS=3D-Lsrc -Wl,-rpath=3D" %output "/lib") > > The "-Lsrc" is repeated from upstream, because VARIABLE+=3D on the make > > command line doesn't actually work. > > With that, it finally builds and runs. Some software just isn't fun to > > package. It's a tedious process that often overlooked in distros where all stuff is = already packaged. > > From hwinfo: > > > using /var/lib/hardware > > This might need fixing. There may be remaining issues with the > > package(s); I'm out of time. > Thanks for your time! I made the modification and now it builds. Time to pr= epare the patches. > From the build log: > > > info(FRITZ!Card PCMCIA): This card has multiple drivers, some functions > > > > are only available on the binonly driver > > We'll need to make sure this package doesn't include or 'promote' binary > > blobs in any way. > What do you mean by striping binary blobs? Don't know exactly how to spot them yet :-)