From: rdes via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 41181@debbugs.gnu.org
Subject: [bug#41181] adds emacs-interleave
Date: Fri, 22 May 2020 01:42:22 +0000 [thread overview]
Message-ID: <zF-leJAkclvDcMy9CGz-YtZBjCrIbcwPw215S7lniHkKR5LoA16vFNKtWpVNQ4xt1i9p-vz0uix1p14zS0EY6hbounKmwBbWpjp16hNJ0gs=@protonmail.com> (raw)
In-Reply-To: <87367ytbe6.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 2671 bytes --]
Hello Nicolas,
Thanks for the insight. Attached is a patch with the suggestions from the previous email.
-Ryan
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, May 17, 2020 7:00 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> rdes rdes@protonmail.com writes:
>
> > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New
> > variable.
>
> Thank you for the updated patch. Some comments follow.
>
> > +(define-public emacs-interleave
> >
> > - (package
> > - (name "emacs-interleave")
> > - (version "1.4.0")
> > - (source
> > - (origin
> >
> >
> > - (method git-fetch)
> >
> >
> > - (uri
> >
> >
> > - (git-reference
> >
> >
> > - (url "https://github.com/rudolfochrist/interleave")
> >
> >
> > - (commit (string-append "interleave-" version))))
> >
> >
> > - (file-name (git-file-name name version))
> >
> >
> > - (sha256
> >
> >
> > - (base32
> >
> >
> > - "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb"))))
> >
> >
>
> Could you move the hash on the line above?
>
> > - (build-system emacs-build-system)
> > - (home-page
> > - "https://github.com/rudolfochrist/interleave")
> >
> >
>
> Could you move the URI on the line above, too?
>
> > - (synopsis
> > - "A minor mode that presents a document buffer next to an orgmode buffer")
> >
> >
>
> A synopsis does not start with "A". You may want to use "guix lint" to
> spot this.
>
> You might use the summary from the home page:
>
> (synopsis "Emacs minor mode to interleave notes and text books")
>
> > - (description
> > - "Interleave is a minor mode that presents a document viewer side
> >
> >
> >
> > +by side to an orgmode buffer with your notes relevant to the current
> > page.")
>
> "orgmode buffer" -> "an Org buffer"
>
> Could you send an updated patch and merge this with the copyright line
> you sent?
>
> Regards,
>
> ---------------------------------------------------------------------------------------------
>
> Nicolas Goaziou
</mail@nicolasgoaziou.fr>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch --]
[-- Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch", Size: 1899 bytes --]
From 8997cb28bc694b0a614d691db592ccfc1f85b790 Mon Sep 17 00:00:00 2001
From: Ryan Desfosses <ryan@desfo.org>
Date: Fri, 15 May 2020 16:53:02 -0400
Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New
variable.
* gnu/packages/emacs-xyz.scm: Add copyright.
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 45ccced99e..1a25547508 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -70,6 +70,7 @@
;;; Copyright © 2020 Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx>
;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2020 pinoaffe <pinoaffe@airmail.cc>
+;;; Copyright © 2020 Ryan Desfosses <rdes@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -6052,6 +6053,28 @@ the Hydra very seamless; it's like a minor mode that disables itself
automatically.")
(license license:gpl3+)))
+(define-public emacs-interleave
+ (package
+ (name "emacs-interleave")
+ (version "1.4.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/rudolfochrist/interleave")
+ (commit (string-append "interleave-" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/rudolfochrist/interleave")
+ (synopsis "Emacs minor mode to interleave notes and text books")
+ (description
+ "Interleave is a minor mode that presents a document viewer side
+by side to an Org buffer with your notes relevant to the current page.")
+ (license license:gpl3+)))
+
(define-public emacs-ivy
(package
(name "emacs-ivy")
--
2.26.2
next prev parent reply other threads:[~2020-05-22 1:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 19:35 [bug#41181] adds emacs-interleave rdes via Guix-patches via
2020-05-11 7:10 ` Nicolas Goaziou
2020-05-15 20:56 ` rdes via Guix-patches via
2020-05-17 13:18 ` rdes via Guix-patches via
2020-05-17 23:00 ` Nicolas Goaziou
2020-05-22 1:42 ` rdes via Guix-patches via [this message]
2020-05-25 11:43 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='zF-leJAkclvDcMy9CGz-YtZBjCrIbcwPw215S7lniHkKR5LoA16vFNKtWpVNQ4xt1i9p-vz0uix1p14zS0EY6hbounKmwBbWpjp16hNJ0gs=@protonmail.com' \
--to=guix-patches@gnu.org \
--cc=41181@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=rdes@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).