unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59555] [PATCH] gnu: Add emacs-org-rainbow-tags.
@ 2022-11-25  1:20 Hilton Chain via Guix-patches via
  2022-11-26 10:42 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Hilton Chain via Guix-patches via @ 2022-11-25  1:20 UTC (permalink / raw)
  To: 59555; +Cc: Hilton Chain

* gnu/packages/emacs-xyz.scm (emacs-org-rainbow-tags): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a6002efa51..d7bb3213a4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6105,6 +6105,31 @@ (define-public emacs-org-inline-pdf
 inline PDF preview in Org buffers by using pdf2svg.")
     (license license:gpl3+)))
 
+(define-public emacs-org-rainbow-tags
+  ;; Upstream didn't tag version.
+  (let ((commit "c6040d228c5e8c5c6d33c7f81fc09d935ad1bcbd"))
+    (package
+      (name "emacs-org-rainbow-tags")
+      (version "0.1-pre")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/KaratasFurkan/org-rainbow-tags")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "006nx01sby8k0fc9lf63ldf0sl94ihldyrvqr9r18fb1gpzvivl6"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/KaratasFurkan/org-rainbow-tags")
+      (synopsis
+       "Colorize org tags automatically to make them visually distinguishable")
+      (description
+       "This package adds random colors to your org tags. In order to make
+colors random but consistent between same tags, colors are generated from the
+hash of the tag names.")
+      (license license:gpl3))))
+
 (define-public emacs-org-rich-yank
   (package
     (name "emacs-org-rich-yank")
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#59555] [PATCH] gnu: Add emacs-org-rainbow-tags.
  2022-11-25  1:20 [bug#59555] [PATCH] gnu: Add emacs-org-rainbow-tags Hilton Chain via Guix-patches via
@ 2022-11-26 10:42 ` Nicolas Goaziou
  2022-11-26 12:09   ` [bug#59555] [PATCH v2] " Hilton Chain via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2022-11-26 10:42 UTC (permalink / raw)
  To: 59555; +Cc: hako

Hello,

Hilton Chain via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-rainbow-tags): New variable.

Thank you.

> +      (synopsis
> +       "Colorize org tags automatically to make them visually distinguishable")

I think "Colorize Org tags automatically" is enough as a synopsis.

> +      (description
> +       "This package adds random colors to your org tags. In order to make
> +colors random but consistent between same tags, colors are generated from the
> +hash of the tag names.")

org -> Org

Also, you need to separate sentences with two spaces per Texinfo specifications.

> +      (license license:gpl3))))

License is actually gpl3+ because the main file mentions:

    either version 3 of the License, or ;; (at your option) any later
    version.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#59555] [PATCH v2] gnu: Add emacs-org-rainbow-tags.
  2022-11-26 10:42 ` Nicolas Goaziou
@ 2022-11-26 12:09   ` Hilton Chain via Guix-patches via
  2022-11-26 23:21     ` bug#59555: " Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Hilton Chain via Guix-patches via @ 2022-11-26 12:09 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 59555

* gnu/packages/emacs-xyz.scm (emacs-org-rainbow-tags): New variable.
---
Range-diff:
1:  f0cbfb8ff1 ! 1:  fc4fc395ed gnu: Add emacs-org-rainbow-tags.
    @@ gnu/packages/emacs-xyz.scm: (define-public emacs-org-inline-pdf
     +                  "006nx01sby8k0fc9lf63ldf0sl94ihldyrvqr9r18fb1gpzvivl6"))))
     +      (build-system emacs-build-system)
     +      (home-page "https://github.com/KaratasFurkan/org-rainbow-tags")
    -+      (synopsis
    -+       "Colorize org tags automatically to make them visually distinguishable")
    ++      (synopsis "Colorize Org tags automatically")
     +      (description
    -+       "This package adds random colors to your org tags. In order to make
    ++       "This package adds random colors to your Org tags.  In order to make
     +colors random but consistent between same tags, colors are generated from the
     +hash of the tag names.")
    -+      (license license:gpl3))))
    ++      (license license:gpl3+))))
     +
      (define-public emacs-org-rich-yank
        (package

 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8eb4dab077..d2ced38a53 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6100,6 +6100,30 @@ (define-public emacs-org-inline-pdf
 inline PDF preview in Org buffers by using pdf2svg.")
     (license license:gpl3+)))
 
+(define-public emacs-org-rainbow-tags
+  ;; Upstream didn't tag version.
+  (let ((commit "c6040d228c5e8c5c6d33c7f81fc09d935ad1bcbd"))
+    (package
+      (name "emacs-org-rainbow-tags")
+      (version "0.1-pre")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/KaratasFurkan/org-rainbow-tags")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "006nx01sby8k0fc9lf63ldf0sl94ihldyrvqr9r18fb1gpzvivl6"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/KaratasFurkan/org-rainbow-tags")
+      (synopsis "Colorize Org tags automatically")
+      (description
+       "This package adds random colors to your Org tags.  In order to make
+colors random but consistent between same tags, colors are generated from the
+hash of the tag names.")
+      (license license:gpl3+))))
+
 (define-public emacs-org-rich-yank
   (package
     (name "emacs-org-rich-yank")

base-commit: adf3eecedade19ce88d3df4325acef4559d05e8f
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#59555: [PATCH v2] gnu: Add emacs-org-rainbow-tags.
  2022-11-26 12:09   ` [bug#59555] [PATCH v2] " Hilton Chain via Guix-patches via
@ 2022-11-26 23:21     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2022-11-26 23:21 UTC (permalink / raw)
  To: Hilton Chain; +Cc: 59555-done

Hello,

Hilton Chain <hako@ultrarare.space> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-rainbow-tags): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-26 23:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-25  1:20 [bug#59555] [PATCH] gnu: Add emacs-org-rainbow-tags Hilton Chain via Guix-patches via
2022-11-26 10:42 ` Nicolas Goaziou
2022-11-26 12:09   ` [bug#59555] [PATCH v2] " Hilton Chain via Guix-patches via
2022-11-26 23:21     ` bug#59555: " Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).