unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: 57992@debbugs.gnu.org
Subject: [bug#57992] [PATCH] gnu: emacs-use-package: Emit deprecation messages.
Date: Thu, 22 Sep 2022 09:21:58 +0800	[thread overview]
Message-ID: <y76a66snqyx.wl-hako@ultrarare.space> (raw)

* gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch: New
file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/emacs-xyz.scm (emacs-use-package)[patches]: Add
emacs-use-package-avoid-positional-arguments.patch.
---
 gnu/local.mk                                  |  1 +
 gnu/packages/emacs-xyz.scm                    |  6 ++++-
 ...e-package-avoid-positional-arguments.patch | 26 +++++++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index ef1bae5f3c..731f64b053 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1054,6 +1054,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/emacs-source-date-epoch.patch		\
   %D%/packages/patches/emacs-telega-path-placeholder.patch	\
   %D%/packages/patches/emacs-telega-test-env.patch		\
+  %D%/packages/patches/emacs-use-package-avoid-positional-arguments.patch \
   %D%/packages/patches/emacs-wordnut-require-adaptive-wrap.patch	\
   %D%/packages/patches/emacs-yasnippet-fix-tests.patch	\
   %D%/packages/patches/emacs-kv-fix-tests.patch	\
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 32e4c33f16..762d11a776 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14994,7 +14994,11 @@ (define-public emacs-use-package
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "088kl3bml0rs5bkfymgzr15ram9qvy66h1kaisrbkynh0yxvf8g9"))))
+                "088kl3bml0rs5bkfymgzr15ram9qvy66h1kaisrbkynh0yxvf8g9"))
+              (patches
+               (search-patches
+                ;; NOTE: Cherry-picked from upstream commit.
+                "emacs-use-package-avoid-positional-arguments.patch"))))
     (build-system emacs-build-system)
     (native-inputs
      (list texinfo))
diff --git a/gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch b/gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch
new file mode 100644
index 0000000000..82b52b0400
--- /dev/null
+++ b/gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch
@@ -0,0 +1,26 @@
+From cb90d3fa4168d7e1b2f035f4fbb0d5d08db1fbec Mon Sep 17 00:00:00 2001
+From: Jonas Bernoulli <jonas@bernoul.li>
+Date: Tue, 18 May 2021 15:44:34 +0200
+Subject: [PATCH] Avoid positional arguments to define-minor-mode
+
+Back in Emacs-21.1, `define-minor-mode' grew keyword arguments to
+replace its old positional arguments.  Starting with Emacs-28.1
+a warning will be omitted if positional arguments are still used.
+---
+ bind-key.el | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/bind-key.el b/bind-key.el
+index 1d611c2..9a2ddcd 100644
+--- a/bind-key.el
++++ b/bind-key.el
+@@ -131,7 +131,8 @@
+ 
+ (define-minor-mode override-global-mode
+   "A minor mode so that keymap settings override other modes."
+-  t "")
++  :global t
++  :lighter "")
+ 
+ ;; the keymaps in `emulation-mode-map-alists' take precedence over
+ ;; `minor-mode-map-alist'

base-commit: 1a1ff7ed8fdaae58aff0e8625399cd7354038ca3
-- 
2.37.3





             reply	other threads:[~2022-09-22  1:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  1:21 Hilton Chain via Guix-patches via [this message]
2022-09-23 16:29 ` [bug#57992] Emit != omit Liliana Marie Prikler
2022-09-24 23:41   ` [bug#57993] " Hilton Chain via Guix-patches via
2022-09-24 17:42 ` [bug#57992] [PATCH] gnu: emacs-use-package: Emit deprecation messages Nicolas Goaziou
2022-09-24 23:45   ` Hilton Chain via Guix-patches via
2022-09-25 12:55     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y76a66snqyx.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=57992@debbugs.gnu.org \
    --cc=hako@ultrarare.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).