From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EDDuIciGU2AoWAAA0tVLHw (envelope-from ) for ; Thu, 18 Mar 2021 16:58:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eGPKHciGU2BUIgAA1q6Kng (envelope-from ) for ; Thu, 18 Mar 2021 16:58:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 216A11CA33 for ; Thu, 18 Mar 2021 17:58:48 +0100 (CET) Received: from localhost ([::1]:43106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMvyx-0001G7-5c for larch@yhetil.org; Thu, 18 Mar 2021 12:58:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMvvL-0006vN-NW for guix-patches@gnu.org; Thu, 18 Mar 2021 12:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMvvK-00024H-Az for guix-patches@gnu.org; Thu, 18 Mar 2021 12:55:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMvvK-0003Er-AS for guix-patches@gnu.org; Thu, 18 Mar 2021 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47187] [PATCH] gnu: Add c-lightning. Resent-From: ZmnSCPxj Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 18 Mar 2021 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47187 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Cc: "47187@debbugs.gnu.org" <47187@debbugs.gnu.org> Received: via spool by 47187-submit@debbugs.gnu.org id=B47187.161608645612380 (code B ref 47187); Thu, 18 Mar 2021 16:55:02 +0000 Received: (at 47187) by debbugs.gnu.org; 18 Mar 2021 16:54:16 +0000 Received: from localhost ([127.0.0.1]:47899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMvuZ-0003Dc-Pv for submit@debbugs.gnu.org; Thu, 18 Mar 2021 12:54:16 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:17992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMvuX-0003DP-RR for 47187@debbugs.gnu.org; Thu, 18 Mar 2021 12:54:15 -0400 Date: Thu, 18 Mar 2021 16:54:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1616086447; bh=0KDfqFaUQNPa9DcR/Us/n0KJUaYuK2X02IuoTs+wKaE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Hgv3GbPCmLRbvwaSnxQ2QKV1G+wFW+gUitOLskFuRwXTyEYXQjYSm1RY7C7hJZ2I4 O4kNb0QXHpGtfSwp+RA/RavtIUtR93irXpvlMrY5Nz41uF4nR87pRMvLDDKVMMUu8J O2Lo9lQ+w+hAuhYo5KBlRyh56F2aC+STWd1B/GZM= Message-ID: In-Reply-To: References: <81c654076d3c07c0f7d1657b4e44dce29a01eca2.camel@zaclys.net> <9436292ea880757cf47a5ce59879e6e7098ff195.camel@zaclys.net> <8f7d4c04d96fdf8cf1239c476c4c869f92446ada.camel@zaclys.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: ZmnSCPxj X-ACL-Warn: , ZmnSCPxj via Guix-patches From: ZmnSCPxj via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616086728; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0KDfqFaUQNPa9DcR/Us/n0KJUaYuK2X02IuoTs+wKaE=; b=rmi6Jye3JRaaBWsinnOC13fYSiQIj0XE6p04SyKUXqDoiifZknmfs3JSzrpCXWX4fv49pz 4YPi+SNIKjtjluNpp4G/uT96gT/fLP2+L4ycKlvchrSzJHa4gjYDPPJ+fj07Y1Ikt2e7S8 JLOlg9zy8WEF6VdjYrsr9ygaGo9Gm+Rx+Xe0B5oZEyQDf/OH+bS3GnTdBNgngSlH1+8NyK +2wuSsDZi5CQ2qYQjcVKxmOry2uTZjsM/Np0BDCW89rxCcl7/JuRN8b0KlqvgWTBqjibjx c0axNirELqiD9utzr0LliUCMccafVxeK78A3EQCk4IwsYMOdbRxszkxkYLA+oA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616086728; a=rsa-sha256; cv=none; b=XbKdgxn83YYQrVFNluR5gL0beLBfBO0V4MgZXdnPdIwqXoSSXOm6USwRjAUs/0BI2dgj/r KlvzKc9fQSmxEafW7vCDdL92OHY6G3j1xqzJntDgAKePaOPGBRh5TA2waQGSA9yOeDjfJj TchfbEaUFAU3MMLJqEEH5ZNhh7Cz26ymmvRJc7/Imo1PX+RAzqWhDyIu2Bp8ejjXPJ/FPu kN5q9RJDPaiumyULLaH77rYPv9UL7yMmfvvyjbo0b0KkJqRXEgvrXSl2It7f+DwQpmsP0w GKPdFnw/9fEcsIdw31Ij8rz4GRhVtWOUlcnnX5a9pl6KWy1sWuGQRi7Kns+ISQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=Hgv3GbPC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=Hgv3GbPC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 216A11CA33 X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8wL3rvh4YjV1 Good morning Leo, > On Wed, 2021-03-17 at 03:42 +0000, ZmnSCPxj wrote: > > > I understand. > > This will require a largish amount of work I think. > > Would this technique be acceptable? > > > > - `add-before 'configure 'unvendor-externals` > > - `rm -rf` the vendored externals. > > - `ln -s` the needed `.h` and `.la`/`.a`/`.so` files from the > > `inputs` to the expected paths within the `external/` directory= . > > > > > > ? > > Maybe simply add an option like --with-system-libbacktrace etc. in the > build system? That would not be simple I think, but let me see what can be done. For one, it would be fairly difficult to test it outside of a patched Guix,= as the packages are not usually available in most distros (which is why we= ship the source build with them); e.g. we do not know how to actually find= the "system" libbacktrace as no existing system I know of actually ships t= he libbacktrace we use (Debian ships a libbacktrace for android development= , and is not the same package as what we use). Of the external packages we use, only libsodium is available on Debian (and= older Debian/Ubuntu, as mentioned, have an older version that does not hav= e a functionality we require, which is why it is included in our source bui= ld as well), so that is the only external we have that we can plausibly say= "we can use the system version", because all the others are not available = on most systems. Also --- we would be somewhat wary of taking the "system" `libsecp256k1`, a= s this is very consensus-critical, and we know that our program works with = a very specific version, but cannot assure this to be true if the "system" = `libsecp256k1` is not the exact version. (Note that we cannot take the `libsecp256k1` from `bitcoin-core` because (1= ) the `bitcoin-core` package uses a vendored `libsecp256k1`, the separate G= uix `libsecp256k1` is actually only used by `electrum` and related projects= and (2) the interface `bitcoin-core` uses may be different from the interf= ace we use, it would require review before we would be able to assure that = the interfaces they use are exactly the same; this would be mitigated by ru= nning the full test suite as it also tests consensus-criticality.) Is there an easy way to ensure that any `libsecp256k1` that gets fed into t= he `c-lightning` build as an `inputs` is of a specific `git` commit? > And yes remove externals, I think that you should use a > snippet in the origin field instead of a phase for that. Hmm do you mean something like: (origin ; whatever... (snippet '(begin (delete-file-recursively "external/gheap") (delete-file-recursively "external/jsmn") (delete-file-recursively "external/libbacktrace") (delete-file-recursively "external/libsodium") (delete-file-recursively "external/libwally-core")))) ? > > Incidentally, we also install some Python modules. > > How do I "properly" export the Python modules within Guix? > > I will ask someone else here but you might have to mix the python- > build-system in. How do you mix in a build system? Would `python-pyqt` be a good example of such "mix in"? Regards, ZmnSCPxj