From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kIYmGPm1YWGROwEAgWs5BA (envelope-from ) for ; Sat, 09 Oct 2021 17:32:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YB6qE/m1YWFDFwAAbx9fmQ (envelope-from ) for ; Sat, 09 Oct 2021 15:32:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF978ECD8 for ; Sat, 9 Oct 2021 17:32:08 +0200 (CEST) Received: from localhost ([::1]:54910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZEKW-000845-2n for larch@yhetil.org; Sat, 09 Oct 2021 11:32:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZEKR-00083x-1G for guix-patches@gnu.org; Sat, 09 Oct 2021 11:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZEKQ-0004vQ-9m for guix-patches@gnu.org; Sat, 09 Oct 2021 11:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZEKQ-0000S6-7L for guix-patches@gnu.org; Sat, 09 Oct 2021 11:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50814] [PATCH] guix: git-authenticate: Also authenticate the channel intro commit. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Oct 2021 15:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 50814@debbugs.gnu.org Received: via spool by 50814-submit@debbugs.gnu.org id=B50814.16337934811681 (code B ref 50814); Sat, 09 Oct 2021 15:32:02 +0000 Received: (at 50814) by debbugs.gnu.org; 9 Oct 2021 15:31:21 +0000 Received: from localhost ([127.0.0.1]:54009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZEJk-0000R3-M0 for submit@debbugs.gnu.org; Sat, 09 Oct 2021 11:31:20 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:26470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZEJh-0000Qp-Uv for 50814@debbugs.gnu.org; Sat, 09 Oct 2021 11:31:19 -0400 Date: Sat, 09 Oct 2021 15:31:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail2; t=1633793471; bh=cWGe46mUxTt8gIBDDZ/4+8IOcnj3B/GSw34YCSH+2VY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=tGjUyAfButZus/sEMFtFYbCJa4Hp5/nIykXPewZa2ifJ1IW5xOJNSHKAyFTs4h453 01w3gSWIz5ZfWMClPZlkkIwCVTRUfxP00iDZbn1z10zCth0aZpsw7BmKlR/inB6vF7 q2w6/vq5c1Vm5DXzJeQj87+tDjF1tkU2fYmH4BuBaxdWKTSl6wjyLjRgTwyIdgtWDp zkBdZEzLu3NeIqogMHmV84x55ayhW0gQettLxkVS6WevXPjGQIwnTcdpchzXKJh+vF Er9Kvk/WVJczUuY36nNt64rQZnyujdsDukZR45ZavKYAuAZIU02/EGbMoM/Gsdz49G zMLjbcuCA8vZw== From: Attila Lendvai Message-ID: In-Reply-To: <878rz2xq23.fsf@gnu.org> References: <20210926101928.3877-1-attila@lendvai.name> <878rz2xq23.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633793529; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cWGe46mUxTt8gIBDDZ/4+8IOcnj3B/GSw34YCSH+2VY=; b=S7a3Bx03uspGDNmIsQ7VHH9+lcdEmrd7mXS1ifV/0yTGlxGrPidDHkmzzsvdacYrU33jwA Qw6/sMT2JbebVXcB+cZfUtXh/k4USXqd7v3fpDoONJQ0c0j5Extj2mLTW9/fz/WcmTLo83 zBFccUE/xhjfGf60uqzDwq8/lGBpAJwXIrFHEKH87yjR0T/gMawHWI1yOjYD5rAj8IuspR UlXfWJL2QO4OfeiboWv3oyoBXLum4slJWHfb8fGWHbqUmaXX7Lcdq5at3gEs2o+luRi28n i722zMXS04b+4f1/p3cj/nKrGXHVl8J1dYoU/s9RSkUqJWMAEVMbB8sdIvtQuA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633793529; a=rsa-sha256; cv=none; b=IxOGs+U3cpnV6xiuGByoYpESygB1sSH+tYomxfBYGcy9FWjYEGyucE+q+J+myuUwWPXMER A46eztQRI2B++zW9mAXkkDfMO4k9iz0jf8MMXN5GAyHjPcl/a4VJf38fpRKEwjGhd4+Twy 4OqxvHNgWrjWB8JCmjTfL+bV3RgrizayHPzmt9yeiONqXLajQMFYC3Cgv+0ex3YBqnn86X RwvIR1R1nH7Pstr/r7T706slDmVvjrHWaVBGOh3XqFB7TupTlaB5uP0uPHwHlgPySbyrjl Il9g4x3HunCTDX8L0mboQXAhWNKFYNPbkThLjXEsiK+APCCZlVMZEDc59Y4liQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=tGjUyAfB; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=tGjUyAfB; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EF978ECD8 X-Spam-Score: -1.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6cy/TfT8d7QD > Does that make sense? there are three main topics of this patchset: 1) adding a (hopefully helpful) warning. the primary goal. 2) general cleanups 3) IIRC, fixing some actual bugs in the process as for 1): what i did was fork guix master, and now i'm pulling my own authenticated branch from my own local git checkout, where every once in a while i merge my various topic branches into my branch, and guix pull it. when i added my second commit i have spent a disproportionate amount of time trying to figure out what was happening: the first commit was accepted, and i thought it's set up all fine. then who knows how much later, when i added my second commit, i was staring at the screen without a clue why pulling doesn't work anymore. then i ventured into quickly adding warning, so that others won't waste their time on this, and went down the rabbit hole, which resulted in fixing actual bugs, i believe. IIRC, they are exposed by the test that i have added when run on the current codebase. as for 3), any actual bugs: i'll investigate again later by running the test without the fix, and write up my results here, or better yet, in a better commit message. -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- It should be a grammatical if not legal offense to ascribe thoughts, opinio= ns and decisions to "we" without a signed power of attorney.