From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WL9fODRey2WJ7wAAe85BDQ:P1 (envelope-from ) for ; Tue, 13 Feb 2024 13:19:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id WL9fODRey2WJ7wAAe85BDQ (envelope-from ) for ; Tue, 13 Feb 2024 13:19:00 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b="K2+v31/j"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707826740; a=rsa-sha256; cv=none; b=aZT/UNSCydCkZSx2+Y4XozJsE2zVVPl15uCHPBJ9O0YWfvOBNUEvaO5VfycxqF0TrjIQ3x ahaAlD/TyORZEcGyAE69+wfePeBafJJQd0pt2jKAQT6lu7o++dvfSWWXX9Ft87bSq8j+GV /yUVXvoxhK3t7Uor070nSS6dm0Nr2srgfsCAAO8dH6Hk2c4pkNsUOw7jP1C1RpuyEiEtHm /YPNq200oBADSk8mqfHAifxuxaqoIIO90Dxe4dn55+22wJ+9nMO+wehhb57VfLs+xe8QZ1 SS5ZVjFWAeLGGzgKU/DWPToA5H8NuDGatmrlXDLNlJnyJV2KCW3muE6dei8v0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b="K2+v31/j"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707826740; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=806G8YXSrdyJkNPynnLhLECzHT+wDsG2HDXlzkkT+NE=; b=L6S7eLIpNia6qe4dYe36BBYK32iBMR+sbOOzbtO4d7qmxcIbElY+zU1x85IGU5W7cNRpUg CYbVr2c/Jh8DDsTqrpiwuRNKlRlK3Q95BCCS0UnianDpCv2hOMcFoVGdwY374w7T3eXMS6 RJk5MetxmOZNQQalQ+CfF9zZAzZ7L9NodW5qcwJuFz1dFLEkW8HyOXX7S2B/Ae9VGV8NeO ENAG6w1MR6DqpztgIzt023S441qadtoUa9JP47lTSH/UCe3ae/CPZ3fiXKi7F0kBaeqEVk u8jY2A4j/IHN2L6kii/VmwBt2KgJi37nWOA71T1i60rRdfwHWpae7iRGvbm0Fw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F9CF212E4 for ; Tue, 13 Feb 2024 13:19:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZrkT-00032G-KH; Tue, 13 Feb 2024 07:18:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZrkN-0002wh-Du for guix-patches@gnu.org; Tue, 13 Feb 2024 07:18:49 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZrkL-0005Ip-GN for guix-patches@gnu.org; Tue, 13 Feb 2024 07:18:46 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZrkc-000156-SP for guix-patches@gnu.org; Tue, 13 Feb 2024 07:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1 Resent-From: Saku Laesvuori Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Feb 2024 12:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69068 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 69068@debbugs.gnu.org X-Debbugs-Original-Cc: 69068@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 69068-submit@debbugs.gnu.org id=B69068.17078267004049 (code B ref 69068); Tue, 13 Feb 2024 12:19:02 +0000 Received: (at 69068) by debbugs.gnu.org; 13 Feb 2024 12:18:20 +0000 Received: from localhost ([127.0.0.1]:42542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrjw-00013E-Eh for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:18:20 -0500 Received: from vmi571514.contaboserver.net ([75.119.130.101]:44278 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrju-000133-Bo for 69068@debbugs.gnu.org; Tue, 13 Feb 2024 07:18:19 -0500 Received: from X-kone (unknown [130.233.144.187]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 0073F3400E1; Tue, 13 Feb 2024 13:18:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1707826716; bh=meAmSi/3IWG1SKzIUWcROlbYKpcngDwM+3mm573wXPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=K2+v31/jOXNZEZW475VtKhb7xm8NiPGwNiUxMPwUH7PA44AiM2YYyLDHNnxY+Gz8D 7m4DuvGz6hcw3XjIl7tiT2u6gTgNqoUCJosc3fcIiVj3s4enKCO5j48esECfsSXXva uogc/s89JpVlixZKzjS5pU0Q4peMl7BvdsGsxn68= Date: Tue, 13 Feb 2024 14:17:56 +0200 Message-ID: References: <87le7obnxl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3gdmtymtotssz4mx" Content-Disposition: inline In-Reply-To: <87le7obnxl.fsf@cbaines.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Saku Laesvuori X-ACL-Warn: , Saku Laesvuori via Guix-patches From: Saku Laesvuori via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -7.08 X-Migadu-Queue-Id: 6F9CF212E4 X-Migadu-Spam-Score: -7.08 X-TUID: qWQBYLcWQYMC --3gdmtymtotssz4mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 13, 2024 at 11:30:50AM +0000, Christopher Baines wrote: >=20 > Saku Laesvuori via Guix-patches via writes: >=20 > > * gnu/packages/finance.scm (kitsas): Update to 5.4.1. > > > > Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad > > --- > > gnu/packages/finance.scm | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > > index 98a220385b..96e2729dda 100644 > > --- a/gnu/packages/finance.scm > > +++ b/gnu/packages/finance.scm > > @@ -1307,7 +1307,7 @@ (define-public keepkey-agent > > (define-public kitsas > > (package > > (name "kitsas") > > - (version "4.0.3") > > + (version "5.4.1") > > (source (origin > > (method git-fetch) > > (uri (git-reference > > @@ -1316,17 +1316,24 @@ (define-public kitsas > > (file-name (git-file-name name version)) > > (sha256 > > (base32 > > - "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"= )))) > > + "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"= )))) > > (build-system qt-build-system) > > - (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5)) > > + (inputs (list libzip qtsvg qtwebengine qt5compat)) > > (arguments > > (list #:tests? #f ;XXX: some tests fail and others = segfault > > #:test-target "check" > > + #:qtbase qtbase > > #:phases > > #~(modify-phases %standard-phases > > (replace 'configure > > (lambda* _ > > (invoke "qmake" "kitsasproject.pro" "CONFIG+=3Drele= ase"))) > > + ;; The tests are not maintained and some don't even bui= ld > > + (add-before 'configure 'disable-broken-tests > > + (lambda _ > > + (substitute* "kitsasproject.pro" > > + ((" *(unittest|testit).*") "") > > + (("\\\\") "")))) > > (replace 'install > > (lambda* _ > > (install-file "kitsas/kitsas" > > > > base-commit: f2102cb5b9239be2ed2023b908b726af542e0124 >=20 > The commit message is missing information on the non-version changes to > the package. All the changes are part of updating the package. The new version is built against Qt6 and requires different inputs, which also makes compiling the tests fail as they are not maintained to work with those new inputs. Earlier just passing #:tests? #f was sufficient to bypass them because they compiled fine and only failed when ran. I can try to write a better commit message if you tell which parts require their own lines, or you can clarify it yourself when applying. > In particular, the removal of qtbase from inputs confuses me, is this > not needed? It is added implicitly by qt-build-system based on the #:qtbase argument. I don't know if qt-build-system worked like that when I submitted the first version of this package, but it probably did and I just didn't realize it. --3gdmtymtotssz4mx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmXLXfQACgkQJX0oSiod OjLB4Q//QHYlKGNx8asB0DpODqZ0CzbNL/i2QdPVetvNBolZVxlO397ag3u/tl4a qofXykQs2wzXmCshtYpijf0QHmxvopjn2gqow8qBy2q7WiDFk//yWMhu59HvxaFv WxGZfoFBJS6Y6Y5Kl9aaP2ktY9U/JUbZp+HEW5tyPeH+XYCr2zs19CHKzF1JYB1M vChj18itlktjcmdzsIcBgajOnh2mi4hGDcqTOYtMtH05ZDPiAvdoVNOjJqx3OpIp puzANaygK5rArD82LHwW4A7R4BfK6YtH5H/RxW/JKP8PpC2d7TDeVkLYb2xSvRHy 9oIqb3myI1OHSnmqdWJ0ZOr6wkFXtdO20j+LuCFrGDD1Dl4ifM4TH5Vb+MoTzSR9 uqjG6yLsYd3+v2rmsyYuaHisZvmuHwZtw/Wm2mUplj1lw/mxwLTMSp9YZtI9oZB0 TnWbr6ftfAiosTuyjLwL1MSDzD/5r4jhUHTQNrfeWhkugOljI36qYO5IheZ8ZoJ6 Cql5Dkgy4sRcN2Swpw7OKm8/io2YbZIU4F3CiE7Wx6dgWUpFEehGm+EgMYE8avvp R4TIPVzFazRDt+uFXYJD5JwMTCd8h8GXsPUxLeffRHh7sIMGUMdFvdGQL87IPNxc v9GZDW7LvmX4IIPUehIS3xyowRFZR1kVNx6h5KHVSTRxgFylTmw= =sqFZ -----END PGP SIGNATURE----- --3gdmtymtotssz4mx--