[bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1

[Saku Laesvuori via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 3195 bytes --]

On Tue, Feb 13, 2024 at 11:30:50AM +0000, Christopher Baines wrote:
> 
> Saku Laesvuori via Guix-patches via <guix-patches@gnu.org> writes:
> 
> > * gnu/packages/finance.scm (kitsas): Update to 5.4.1.
> >
> > Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
> > ---
> >  gnu/packages/finance.scm | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> > index 98a220385b..96e2729dda 100644
> > --- a/gnu/packages/finance.scm
> > +++ b/gnu/packages/finance.scm
> > @@ -1307,7 +1307,7 @@ (define-public keepkey-agent
> >  (define-public kitsas
> >    (package
> >      (name "kitsas")
> > -    (version "4.0.3")
> > +    (version "5.4.1")
> >      (source (origin
> >                (method git-fetch)
> >                (uri (git-reference
> > @@ -1316,17 +1316,24 @@ (define-public kitsas
> >                (file-name (git-file-name name version))
> >                (sha256
> >                 (base32
> > -                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"))))
> > +                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"))))
> >      (build-system qt-build-system)
> > -    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> > +    (inputs (list libzip qtsvg qtwebengine qt5compat))
> >      (arguments
> >       (list #:tests? #f               ;XXX: some tests fail and others segfault
> >             #:test-target "check"
> > +           #:qtbase qtbase
> >             #:phases
> >             #~(modify-phases %standard-phases
> >                 (replace 'configure
> >                   (lambda* _
> >                     (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
> > +               ;; The tests are not maintained and some don't even build
> > +               (add-before 'configure 'disable-broken-tests
> > +                 (lambda _
> > +                   (substitute* "kitsasproject.pro"
> > +                     ((" *(unittest|testit).*") "")
> > +                     (("\\\\") ""))))
> >                 (replace 'install
> >                   (lambda* _
> >                     (install-file "kitsas/kitsas"
> >
> > base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
> 
> The commit message is missing information on the non-version changes to
> the package.

All the changes are part of updating the package. The new version is
built against Qt6 and requires different inputs, which also makes
compiling the tests fail as they are not maintained to work with those
new inputs. Earlier just passing #:tests? #f was sufficient to bypass
them because they compiled fine and only failed when ran.

I can try to write a better commit message if you tell which parts
require their own lines, or you can clarify it yourself when applying.

> In particular, the removal of qtbase from inputs confuses me, is this
> not needed?

It is added implicitly by qt-build-system based on the #:qtbase
argument. I don't know if qt-build-system worked like that when I
submitted the first version of this package, but it probably did and I
just didn't realize it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]