From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mLihNbhs6GD5rAAAgWs5BA (envelope-from ) for ; Fri, 09 Jul 2021 17:35:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kFlTMbhs6GChIgAAbx9fmQ (envelope-from ) for ; Fri, 09 Jul 2021 15:35:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 25B5C88BE for ; Fri, 9 Jul 2021 17:35:20 +0200 (CEST) Received: from localhost ([::1]:48628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1sX8-0007wZ-Nv for larch@yhetil.org; Fri, 09 Jul 2021 11:35:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1sWs-0007tu-7V for guix-patches@gnu.org; Fri, 09 Jul 2021 11:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1sWr-0001EI-Uk for guix-patches@gnu.org; Fri, 09 Jul 2021 11:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1sWr-0003AQ-N2 for guix-patches@gnu.org; Fri, 09 Jul 2021 11:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49339] [PATCH core-updates] gnu: mesa: Update to 21.1.4. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Jul 2021 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49339 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: "49339@debbugs.gnu.org" <49339@debbugs.gnu.org> Received: via spool by 49339-submit@debbugs.gnu.org id=B49339.162584488212145 (code B ref 49339); Fri, 09 Jul 2021 15:35:01 +0000 Received: (at 49339) by debbugs.gnu.org; 9 Jul 2021 15:34:42 +0000 Received: from localhost ([127.0.0.1]:59536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1sWX-00039n-W1 for submit@debbugs.gnu.org; Fri, 09 Jul 2021 11:34:42 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:51900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1sWT-00039W-Kt for 49339@debbugs.gnu.org; Fri, 09 Jul 2021 11:34:40 -0400 Date: Fri, 09 Jul 2021 15:34:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625844870; bh=ZubnlNJN/JlfF6bpd4fUQSr8RA62ddTn8Ig5QieIddM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=OzB9Fp9YNpNAxfLebrwpv6UyCwaCyBmmpd0zLvp0DYCQjDRz8GMuvKEsoP1ZltIGn zb6rM+gtG8bl2m7WPcDdBvdvk4cWdhB3fJ17Bh+rpW6t8aCMqZIDXBWQwKXC+UbkS8 Lw6qZERRAacNs5VGhtjciGoW4dEjJmyufoQFFfs4= Message-ID: In-Reply-To: References: <1aa813b7dee2233dd82ae3d74d175fc68e28fdd5.camel@telenet.be> <_GQD4UBisH4wjKiOm3O6fzv8b1vdI890mQCX4gX6FQB7pXuDXpAU-mLiKMPRDMKu9vp_UFBUcOs6mlIKuKAbZ9W1lPQ5QnwhPBc2fra-Yow=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625844920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZubnlNJN/JlfF6bpd4fUQSr8RA62ddTn8Ig5QieIddM=; b=FvDaCDc2kBEXSPW/+YhSXrVl9TYeMU+3wivj/KqjsENj54gA+TcobMmTR+j4eXLO+PbYnh ba6wRLCNLt2adni5bPOtnFbN8PdKLT6Ww0C8S88EutCyHevQnRp2u9AuBWnKR+K3b9TF76 6TZ90eIP38BuGSyOXvoCkDks4NPHtiRtuCXz4dZ8XqSIs+2PDjeiHPYiCpvV6o+C5KTCeM aZeDw4Mh6MEUR6zqgRzi965Htdf5T6crXCCVDC3ch66rbtxjGLRFlp2tllxW4X7MqelOF5 6sxd87GZPY3J85tQcYBhn2ur37zJX576IRL+Euwvs7ebal1D6KaYZCd30QQqpQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625844920; a=rsa-sha256; cv=none; b=TUSVhZe+cXCySKPbPdW5gDUhZK+uysEjhrmq5LNzkO6LuezaqYC4nzdY9U/C7Y9/Y94r7y FBDsafx9aFMkC8h1XY5IuECvE0x6tzrg0tGPKzct220OhU9lIkTJJO5cWLTQy6giuaE0f+ FDJ45yXqSA4phHdGB8Do6LiMGtVg939N2cQH7n3QnA8JmPEcafwjSwywK9bCpvY2oLJtd8 9C/eexVtRb0zGM+G6KMzjAYqQixOKZ3h6Vpy87y4UqTAWQbzXGc28MbOvkgR2gU4DPwfYG 4rnHK6Jv06IaBkMuE7AUHZgcsiJfRbDEN81JoKTjHDqeSw+x/2hB0IXeJi7v7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=OzB9Fp9Y; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=OzB9Fp9Y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 25B5C88BE X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: t0GBZRjIMO91 =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, July 9th, 2021 at 8:48 AM, Maxime Devos wrote: > Warning: I've no idea how building mesa and libglvnd works, > > how linking against mesa and libglvnd works, and how mesa and libglvnd > > work, besides =E2=80=98you can use the GL_... functions to do GL stuff= =E2=80=99. > No worries, I also know very little here (just learning about libglvnd), so= I'm no expert. However, I think it will be a little more complicated becau= se libglvnd is meant to dispatch to a vendor's GL libraries at runtime. Mea= ning it will need to know where these libraries exist, which may require so= me changes for Guix. > That said, it appears some package definitions expect "libGL.so" to be in= mesa. > > (Search for "/lib/libGL" and "lib/libEGL" with 'git grep -F"'). > > I've found about twenty such occurences, including libepoxy. > > So it appears that adding libglvnd to the propagated-inputs and fixing > > these twenty package definitions should be doable. > > Looking at libepoxy in particular: > > (let ((python (assoc-ref inputs "python")) > > (mesa (assoc-ref inputs "mesa"))) > > (substitute* "src/gen_dispatch.py" > > (("/usr/bin/env python") python)) > > (substitute* (find-files "." "\\.[ch]$") > > (("libGL.so.1") (string-append mesa "/lib/libGL.so.1")) > > (("libEGL.so.1") (string-append mesa "/lib/libEGL.so.1"))) > > #t)))))) > > it seems like the test failure isn't a false positive, as libGL.so.1 is s= earched > > for in the wrong location. > While I think getting builds and tests to pass is not so bad, I don't know = that it will actually work the way it is supposed to (see above). I'm also = a bit limited in what I can test directly. (For one thing, I'm on a foreign= distro right now, which complicates GL testing. For example, Nix has https= ://github.com/guibou/nixGL for the "OpenGL problem" which may be something = we should look at for this as well.) > > Anyway, perhaps we want to tackle libglvnd separately? I don't think it= is specific to the Mesa version change, but more of how we want to handle = gl across packages. Still, it will involve changes to how we build Mesa as = well as possibly other packages. I'm not sure that the Mesa version change = will require other changes in dependent packages (I can only test a few on = my own). > > > > How do you think we should proceed? > > I'd suggest adding libglvnd to propagated-inputs > > and adjusting the twenty package definitions to refer > > to libglvnd, and testing some graphical applications. > > "mesa-utils" has "glxdemo" and "glxheads" and has few dependencies, > > maybe start with that? > The more I think about it, the more I think we should tackle a change to Gu= ix's GL system separately. The original patch enabled libglvnd in Mesa, but= that has been around for a while and is not new to 21.1.x. I worry doing t= hem at the same time would introduce two sources for anything breaking, tho= ugh I hope the move to 21.1.x doesn't require any big changes elsewhere. Personally, I'd like to see Mesa 21.1.x updated and make sure dependents ar= e okay. We can then have a separate patch series that enables libglvnd in M= esa and adjusts all packages. We would need some people who can test that a= ctually use different GL vendors to see that libglvnd does what it is suppo= sed to. Perhaps Irfan can weigh in, since in their original patch they did = have libglvnd and may have tested that it works. Any experts on Mesa/libglvnd here to chime in? Is the minimal Mesa version = update patch okay if we want to libglvnd separately? Thanks, John