unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: phodina via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 51774@debbugs.gnu.org
Subject: [bug#51774] [PATCH] gnu: Add font-source-code-pro.
Date: Mon, 15 Nov 2021 22:12:49 +0000	[thread overview]
Message-ID: <uCSje6GgDHrqGtaVy7H_PIeQkdIBzHZLuZMXxYd8dRGbc_kfsXlJrrxHWbBt9jGfx2rJb_QaIdPRj9irp5zfPj9AOzHU0q5ZMNThLcbkepY=@protonmail.com> (raw)
In-Reply-To: <dc9954eff77ad2058f1e4734f3871200b3e5ee1b.camel@gmail.com>

Hi Liliana,


> > https://github.com/adobe-fonts/source-code-pro")
> >
> > -                      (commit (string-append version "R-ro/1.058R-
> >
> >
> >
> > it/1.018R-VAR"))))
>
> Am I allowed to ask WTF this versioning scheme is? Should we just pin
>
> a hash instead?

Hilarious, right? I agree that a hash commit would be better suited here.

>
> > -                (file-name (git-file-name name version))
> >
> >
> > -                (sha256
> >
> >
> > -                 (base32
> >
> >
> > -                  "00h4v3rmxyyaxni6nywacxvjnji2g2pi0b4js1yx0g67fvrv2ga
> >
> >
> >
> > g"))))
> >
> > -   (build-system font-build-system)
> > -   (synopsis "Font for coding environments")
> > -   (description "Font Source Code Pro is sedigned as a companion to
> >
> >     Source
> >
> >     +Sans.")
>
> This scrediption is not very scrediptive ;) Jokes aside, I'd add "[It]
>
> preserves the design features and vertical proportions of Source Sans,
>
> but alters the glyph widths so that they are uniform across all glyphs
>
> and weights." so that Adobe bois know what they're getting.
>

Thanks for the tip!

> > -   (home-page "https://fonts.google.com/specimen/Source+Code+Pro")
>
> I'm not sure whether linking to Google fonts of all places is good
>
> praxis. Might want to link to Github instead. FWIW the repo
>
> advertises this: https://adobe-fonts.github.io/source-code-pro/
>
> Cheers

Sure, github might be more prefereble.

PS: Though at the end it comes to which is better: Google vs Microsoft ;-)




  reply	other threads:[~2021-11-15 22:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 19:22 [bug#51774] [PATCH] gnu: Add font-source-code-pro phodina via Guix-patches via
2021-11-15 19:56 ` Liliana Marie Prikler
2021-11-15 22:12   ` phodina via Guix-patches via [this message]
2021-11-16 19:07 ` [bug#51774] [PATCH v2] gnu: font-adobe-source-code-pro: Update to 2.032R-ro-1.052R-it-1.012R-VAR phodina via Guix-patches via
2021-11-16 20:29   ` Liliana Marie Prikler
2021-11-17 12:25     ` phodina via Guix-patches via
2021-11-17 17:17       ` bug#51774: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='uCSje6GgDHrqGtaVy7H_PIeQkdIBzHZLuZMXxYd8dRGbc_kfsXlJrrxHWbBt9jGfx2rJb_QaIdPRj9irp5zfPj9AOzHU0q5ZMNThLcbkepY=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=51774@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).