From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AFoGO/CsgmFypQAAgWs5BA (envelope-from ) for ; Wed, 03 Nov 2021 16:38:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id lTqMNvCsgmGYEQAAbx9fmQ (envelope-from ) for ; Wed, 03 Nov 2021 15:38:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 926FB12922 for ; Wed, 3 Nov 2021 16:38:24 +0100 (CET) Received: from localhost ([::1]:53224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miILH-00023y-OA for larch@yhetil.org; Wed, 03 Nov 2021 11:38:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miII2-00077O-Ik for guix-patches@gnu.org; Wed, 03 Nov 2021 11:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miII2-0006hW-9Z for guix-patches@gnu.org; Wed, 03 Nov 2021 11:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miII1-0004d4-UY for guix-patches@gnu.org; Wed, 03 Nov 2021 11:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47754] [PATCH] gnu: transformations: fix with-latest option for git source package. Resent-From: Z572 <873216071@qq.com> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Nov 2021 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 47754@debbugs.gnu.org Received: via spool by 47754-submit@debbugs.gnu.org id=B47754.163595365317714 (code B ref 47754); Wed, 03 Nov 2021 15:35:01 +0000 Received: (at 47754) by debbugs.gnu.org; 3 Nov 2021 15:34:13 +0000 Received: from localhost ([127.0.0.1]:40958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miIHE-0004bd-MB for submit@debbugs.gnu.org; Wed, 03 Nov 2021 11:34:13 -0400 Received: from out203-205-221-233.mail.qq.com ([203.205.221.233]:53099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <873216071@qq.com>) id 1miIH5-0004aq-U0 for 47754@debbugs.gnu.org; Wed, 03 Nov 2021 11:34:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1635953631; bh=boAeYADCeSXqjX4bCqdPXdPIYKm+3LJ9oqaBjjyHR2E=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=XFMuir2gqscshZChTs4RQDbdSvBDUJpwg0Daf3Yt98vFKkMDxAJm9aVYpcMzJuPxz aQA7QMNSr9fufusX+iDlc5RrDeznehcizAEdEYkRZ5W7oqSAor2yTZt1uD1lA6qwJa 6c6hd4nhCpOCHZUD2Hz1HGCY6t3qr+X2LBr4O5VQ= Received: from asus ([2409:8928:1202:1ee0:a576:a4f0:ac3d:afe2]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id 87033A9E; Wed, 03 Nov 2021 23:33:48 +0800 X-QQ-mid: xmsmtpt1635953628t2soa96wb Message-ID: X-QQ-XMAILINFO: M/JROGx4T0PuL52Dc4gWPGlxFWu5UTlPtbGFgfIsJoZjpgU7w4DFG5CU+yVBz1 DloW9N2SimpAc9giWTOhMR30G78DIa8gT0wJjxeTr94k4P+w6nIEWYWBCcMDoTv7z/XnHVjk7wTI io8bJz2XD0mCS0De3PF6E2z0LY4s4liZsUBfmq71dP544jcEPd/xC3HT2QmZRpGh3NifgXUNPx20 8KOJSOPrHJ7UdazZlHnSRznDQhN6ZSg1gfyJKV/u83fBh32opDLclO7glQmxg/hPOIuH0l6BAQMr aYdswR95vnBHSUghgC3QWe2gcV+dyNOXMaIDABRk+ZYjLL4B6t5jjoTBjYm6NB6AZ7RmpxRMztBN mjBCVfqocdThdPA7Z1Ab1H2ockpllMTqIMcdiqjARD+bASV38nM8DuQY5xIWrfR8ElEZq2sp3Dat aoCz/xD8ZLpDiTKVT3By0nfifidXGjbYEurNsSmLeb53eKZ/9KSU+dqFG9GxhWQXcSmALCRZwPed 3nWQ1qlHAAx8s9dKieAc9MhHGM7VgyT7MQZBwwLMJsDqGSwFPmp/fmEFzL17wr4q9oMxi7wnlTTw Ib4ANv/n2Np14LQAJPyljezI7yZqBE6YQ4golcj8sN5gTdENk3kKZMYZUM7dfEU3UwvOAePodeb/ CoBZgIjDCnon7NBbJdEQANy+Q6xmF6zYhgwcunDu9LktuB3SFNL7wTQpeAa9yzWIh8rncUmJdpXo RSXIVcp90D/vE2nwf/htlnKNAf6oqTgxqX0T2yoYO/WjWZsr2AHWWxv87rVL4hmL+lJ5bxJ1/DL/ fswqjQgE7NwhXJFmhlh9jt References: <87y265sfsr.fsf@gmail.com> User-agent: mu4e 1.6.9; emacs 28.0.50 Date: Wed, 03 Nov 2021 22:54:40 +0800 In-reply-to: <87y265sfsr.fsf@gmail.com> Message-ID: <87wnlp45k3.fsf@qq.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Z572 <873216071@qq.com> X-ACL-Warn: , Z572 via Guix-patches From: Z572 via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635953904; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=boAeYADCeSXqjX4bCqdPXdPIYKm+3LJ9oqaBjjyHR2E=; b=lwuHkEi3rbjhHqrolXN5Kyn7bswrXaV9K9jsR8fPdVSRDrEQRuhZXLu5gKQuUknWpB3ynG dNjVwZrsy0KXJABE5UiIX5VORhwK+H0eTsB5z7edLVfi7Xg7/CVzFtvr3/wna8HhfC3fH/ RZI2SmIf0eAtUo/LeJ9cfRvKwOfLbDxw2UWzAqiy236PLnAzQzpORQxE+S2DXSC48gyEWF rJAGTkAmxkt1EaZ3RPQKlAxtBY7SUFLoMclckpZ2hK+yS+7585MrdymlwPEd0PmTORJKmp lT3JRSjqJpklS5Rjm61CmDAN1rSv+i01V74Aa2N43Olf6xGPbGc743SrWl2uGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635953904; a=rsa-sha256; cv=none; b=rWRcwtxRA6NkM9ktLLE3iVuZxnslc/y1XLnp/4l0c82w+AJGYjHFJWRlgXWkSJpzpQZMuI CL7LgXPGVzvadoeGmWCFJlu4iS9IGq3SKLNINJoBvYfsT4aG6tAROCkOqMWzo7/Q8oIB/s SvKou7o0kMS4uGA6fDP46u+kqzwtgULJuNsNKfQBszlYrVKSEe4mS5nYmf206L6wa5YsT8 AWg/RKb/9p3OJ3CxBLIohsgNCddlaZK9gsgZKe9bwyzz5pNcjbYKYeja7BELfMvZj6ubrU 0kCp/tkGqKmTvW0MMf9EJiycDAq5rRiqpnoiPWymisv/09GvVWvinjr0ca7Ltw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=qq.com header.s=s201512 header.b=XFMuir2g; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.98 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=qq.com header.s=s201512 header.b=XFMuir2g; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 926FB12922 X-Spam-Score: 1.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7ER2fjR/XRiu Hi, zimoun writes: > Hi, > > Thanks for the patch. > > On Wed, 14 Apr 2021 at 00:28, Z572 <873216071@qq.com> wrote: > >>>>From 52bd30a6ac967375aa9a178345f1bdea8388457a Mon Sep 17 00:00:00 2001 >> From: Zheng Junjie <873216071@qq.com> >> Date: Tue, 13 Apr 2021 23:00:10 +0800 >> Subject: [PATCH] gnu: transformations: fix with-latest option for git source >> package. >> >> gnu/transformations.scm: (transform-package-latest): (package-with-latest-upstream): >> use git-checkout if p is a git source package. >> --- >> guix/transformations.scm | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) > > [...] > >> #:autoload (guix upstream) (package-latest-release* >> + upstream-source-urls >> upstream-source-version >> upstream-source-signature-urls) >> #:use-module (guix utils) >> @@ -537,7 +539,11 @@ are replaced by their latest upstream version." >> (package >> (inherit p) >> (version (upstream-source-version source)) >> - (source source)))))) >> + (source (cond ((false-if-exception (package-git-url p)) >> + (git-checkout >> + (url (car (upstream-source-urls source))) >> + (recursive? #t))) >> + (else source)))))))) > > Could you provide an example for an use-case? Just try this: ``` bash $ file `guix build fbreader --with-latest=fbreader -S` /gnu/store/rdqkmjpiig9gddzsxj4mdyw8lvn944xg-FBReader: HTML document, UTF-8 Unicode text, with very long lines ``` If a package is a git source package, after use "with-latest" option, it's url will become to it's source. and build will fail. This patch just fix this. But i think this patch not good, maybe need a new patch(use latest version not latest commit). But i'm not familiar with this part. > > Cheers, > simon -- over