unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: raid5atemyhomework via Guix-patches via <guix-patches@gnu.org>
To: "45403@debbugs.gnu.org" <45403@debbugs.gnu.org>
Subject: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions.
Date: Fri, 25 Dec 2020 01:12:12 +0000	[thread overview]
Message-ID: <tQf2iU3qAf-98GzhlfpFdOqngdpcHiunJZYtvDXKOm0vw-1XVHIpAHR72XwU6MsfxE1tf2jt3IcTu1xA1Y00GzHtk_emUTTbyGms936YLq4=@protonmail.com> (raw)
In-Reply-To: <QOni976E4oF_Bx56oc2L5Im9eQEULdkhOEMfWenhX2u8POiAbkToPuAPRxLZt9jwivFuFe10BGkmc_-a1iInMYU9aBNopFeILMWrfzYKhEU=@protonmail.com>

> There are primarily two ways to use Guix with a local Git repo.
>
> First, you can follow the instructions in the manual section Contributing, specifically the sections Building from Git and RunningGuix Before It Is Installed.
>
> Or, you can use something like `guix pull --url=/path/to/my/repo --commit=mycommit`.

Thank you very much, will check.

> Beyond that, does this patch create linux-libre packages with ZFS support compiled in?

No, this patch continues to use the existing technique of downloading ZFS as source and compiling it as a kernel module you have to load in, as per licensing incompatibility.

What it changes is that it compiles kernel modules for all guix-provided kernel versions that ZFS currently is rated to support, rather than compile a kernel module for whatever `(default-linux)` is, which is always the latest and greatest kernel (currently 5.10) which ZFS is currently not rated for.

As Guix goes through the trouble of maintaining a `linux-libre-4.4` package I assume at least one user somewhere is using Linux 4.4, and did not want to prevent that user from using ZFS if they decide to do so someday.

I admit the naming scheme `linux-5.9-zfs` does make it seem like the package contains an entire Linux kernel.
The alternative is to call it `zfs-for-linux-5.9` but that makes the entire package name with version `zfs-for-linux-5.9-0.8.5` which I think is worse, because the version numbers are right next to each other.
What naming scheme would you suggest?

* `linux-5.9-zfs` --- makes it look like it contains a whole Linux kernel.
* `zfs-for-linux-5.9` --- versions are right next to each other: `zfs-for-linux-5.9-0.8.5`, this is bad since some versioning conventions include a `-` in the version naming, so at a glance this makes for a very confusing version.
* `kernelmodule-5.9-zfs` --- makes it clear that it is not an entire kernel, but this package *also* includes userspace utilities not just the kernel module.
* `zfs-for-linux-5.9-version` --- kind of a weird and absurdly lengthy name but maybe palatable?

I imagine a similar problem would occur for other kernel modules --- the internal kernel interfaces are *not* stable at all, so complex external kernel modules like ZFS need to know what kernel version it's being compiled for and include a bunch of `#ifdef`s to compensate.
So we need some decent convention for "how do we name kernel modules so that they are targeted for each kernel version".




  parent reply	other threads:[~2020-12-25  1:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 10:59 [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions raid5atemyhomework via Guix-patches via
2020-12-24 20:41 ` Leo Famulari
2020-12-25  1:12 ` raid5atemyhomework via Guix-patches via [this message]
2020-12-25  4:09   ` Tobias Geerinckx-Rice via Guix-patches via
2021-01-04 13:58     ` Danny Milosavljevic
2021-01-04 15:49       ` raid5atemyhomework via Guix-patches via
2021-01-04 16:07         ` raid5atemyhomework via Guix-patches via
2021-01-04 16:32           ` raid5atemyhomework via Guix-patches via
2021-01-08 15:50 ` bug#45403: " raid5atemyhomework via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='tQf2iU3qAf-98GzhlfpFdOqngdpcHiunJZYtvDXKOm0vw-1XVHIpAHR72XwU6MsfxE1tf2jt3IcTu1xA1Y00GzHtk_emUTTbyGms936YLq4=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=45403@debbugs.gnu.org \
    --cc=raid5atemyhomework@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).