From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id QPMcLbeVH2a7PAAA62LTzQ:P1 (envelope-from ) for ; Wed, 17 Apr 2024 11:26:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QPMcLbeVH2a7PAAA62LTzQ (envelope-from ) for ; Wed, 17 Apr 2024 11:26:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lostca.se header.s=anamika header.b=jfYJ3NHr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713345975; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zO2gouVgLPsjNTfEA2iTa+xPQnXbnzGYQU8rfO0oxs0=; b=QjF7dx1/GjBq8+mCojp1pR6Zw4EW5fI14bTaT8325IenpK42bGViSEPkyHYLT6m1n2su4o Fk4nb6JmTAb8T36iTPazo2OH1Q5+tAWGv4yxXm4dgKgqK46ENubhD3z+RltQ9JSIIJ6RO9 o1H1d5XxBk3fPViLBydQHDlzu0JTkcd+0XwFDKVgeX25E6kDqCPdE0MR10pK/foicn3QI/ zjKZcZWhkZlYh2DApVo6A/zpmdS2i2yNn3f7co6M1Y7ZmUfxYelx2A7XdOc+CtqiCrc+/8 0I8k8kjH9yIvRxRMYcob8t1ABJ0SExhCdTECoyqoX5IgB2JGrSujybqPlPEBmg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713345975; a=rsa-sha256; cv=none; b=LAPVn4i9iXydU/VTzyrEfFyjMdKRkfLBfOBNguZzzpGFoBT43wEoTrlsmfJMmK4l5h38z0 nUi81LCCxlnNN/PZTDowQ11TgPHyCd+HiUxzGLHMkbbkF4q165/PYpeWhRJ8+ewFjuMFlb /QD0xH8ivGJVH/3lkpesIQE2HzsOjZ7/20mV/bNwjjsZfdp7aOajnFpUHtLNYvxw+3TSdE 5LnBFBGN08hBt313h4KR/oEJWlmD2QFbpgN8fyQopIks4otEebHsk81M5ajLeqPJQA3oxM tGWjGdxJ6/eo6mHGVXjOJ+dfU37xF7zPe6jFe9VOcRTk+wzoxtVrpEd9nlSgwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lostca.se header.s=anamika header.b=jfYJ3NHr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B05B3FC1D for ; Wed, 17 Apr 2024 11:26:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx1YN-0007My-L0; Wed, 17 Apr 2024 05:26:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx1Y5-0007LY-VJ for guix-patches@gnu.org; Wed, 17 Apr 2024 05:25:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx1Y5-0002BW-NJ for guix-patches@gnu.org; Wed, 17 Apr 2024 05:25:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rx1YI-0001kD-FP for guix-patches@gnu.org; Wed, 17 Apr 2024 05:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70407] Re: [bug#70407] [PATCH] gnu: Add fnc Resent-From: Ashish Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Apr 2024 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70407 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: dziltener@lyrion.ch, 70407-done@debbugs.gnu.org, 70407@debbugs.gnu.org X-Debbugs-Original-Cc: Daniel Ziltener , 70407-done@debbugs.gnu.org, "ashish.is--- via Guix-patches via" Received: via spool by 70407-done@debbugs.gnu.org id=D70407.17133459616699 (code D ref 70407); Wed, 17 Apr 2024 09:26:02 +0000 Received: (at 70407-done) by debbugs.gnu.org; 17 Apr 2024 09:26:01 +0000 Received: from localhost ([127.0.0.1]:45757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx1YF-0001jl-Iy for submit@debbugs.gnu.org; Wed, 17 Apr 2024 05:26:01 -0400 Received: from anamika.lostca.se ([65.21.75.227]:34830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx1YB-0001iD-4X for 70407-done@debbugs.gnu.org; Wed, 17 Apr 2024 05:25:58 -0400 Received: from chateau.d.if (198.red-81-34-32.dynamicip.rima-tde.net [81.34.32.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: abbe) by anamika.lostca.se (Postfix) with ESMTPSA id 27AC1113E; Wed, 17 Apr 2024 09:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; t=1713345935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zO2gouVgLPsjNTfEA2iTa+xPQnXbnzGYQU8rfO0oxs0=; b=jfYJ3NHrMbU93lEI3tOZVkV9db/nKqD2Jn5RCQrrIIcmGYN7licuvnlh4Tf+ebgSM05xr0 nrs24Um5pwPwU2TPQm7qH4ylaWDV68UgtE9AjyqLbfjCM6jHoYIhlFiCtWsTC+JNSpjvrr aZR3lPLTLKq4GSt7uv2kdy5qWbabZuk= Date: Wed, 17 Apr 2024 09:25:33 +0000 Message-ID: References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@lostca.se> <87msptt0d5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="meqj6nymmrg2mjem" Content-Disposition: inline In-Reply-To: <87msptt0d5.fsf@cbaines.net> User-Agent: NeoMutt/20231221 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Ashish X-ACL-Warn: , Ashish via Guix-patches From: Ashish via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -8.48 X-Spam-Score: -8.48 X-Migadu-Queue-Id: 6B05B3FC1D X-Migadu-Scanner: mx13.migadu.com X-TUID: HqEhrBe4Caqa --meqj6nymmrg2mjem Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2024 at 11:21:26PM +0100, Christopher Baines wrote: > "ashish.is--- via Guix-patches" via writes: >=20 > > From: Ashish SHUKLA > > > > * gnu/packages/version-control.scm (fnc): New variable. > > > > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684 > > Signed-off-by: Ashish SHUKLA > > --- > > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-co= ntrol.scm > > index 96ca1df552..33607940ec 100644 > > --- a/gnu/packages/version-control.scm > > +++ b/gnu/packages/version-control.scm > > @@ -4145,3 +4145,28 @@ (define-public git-sizer > > (description "Compute various size metrics for a Git repository, f= lagging > > those that might cause problems or inconvenience.") > > (license license:expat))) > > + > > +(define-public fnc > > + (package > > + (name "fnc") > > + (version "0.16") > > + (source (origin > > + (method url-fetch) > > + (uri > > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" vers= ion ".tar.gz")) > > + (sha256 > > + (base32 > > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy"= )))) > > + (build-system gnu-build-system) > > + (arguments > > + '(#:phases (modify-phases %standard-phases > > + (delete 'configure)) > > + #:tests? #f > > + #:make-flags (list "CC=3Dgcc" > > + (string-append "PREFIX=3D" (assoc-ref %outputs "out"))))) >=20 > The arguments needed a bit of touching up. Using gexp's is the new > style. It's unclear why the tests are disabled, I guess it's because > there are no tests so I've added a comment to this effect. Hardcoding > CC=3Dgcc also causes problems for cross building, so use (cc-for-target) > instead. Thanks for catching this, it indeed crossed my mind, but I was not sure wha= t to replace it with should someone chose to build with `clang' (or other C= language compiler), and `cc' is not present. > > + (inputs (list ncurses zlib sqlite-next)) > > + (home-page "https://fnc.bsdbox.org") > > + (synopsis "Interactive text-based user interface for Fossil") > > + (description "fnc uses ncurses and libfossil to create a fossil ui= experience in > > +the terminal, and parse local changes at the hunk level to prepare ato= mic commits.") > > + (license license:isc))) > > > > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 >=20 > I did have a quick check over the source, including a concatenated > sqlite seems unusual and not ideal, but I'm not quite sure how it's > used. libfossil is a library implementation of fossil ships with bundled sqlite3,= and the author decide to bundle libfossil, and so sqlite3 comes with it. >=20 > One final change I made was moving the package definition up off the > bottom of the file (as if everyone adds new packages there, it causes > merge conflicts). >=20 > I've pushed this to master with the changes I describe as > a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look. >=20 > Thanks, >=20 > Chris Thanks! --=20 Ashish | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 "If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin) --meqj6nymmrg2mjem Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmYflY1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2 ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP pLBG/w/8C7zElodKXntITeFvcJXYuyI4oW9KufmGcfFWINWeb8szUvi3LmBCegn0 efVIFLRlfW4p46/GxvXzqL3xJUete4wKxwzar19aW7Oc4hAQ5cAb5v3+BNC3sH4a s6OEZoPwVApJNxELK9Jgy01u2iUsN59rn1T7F87tGtqBk694dw1eNzkb5AtmSBVY 4v2NIkYpjHfhz4VdYSGDfxAgyabootFspsvfAPkGvPnyB7xMI+zwHbT7fqrfFxfU BxVgWFwe9NrweGfcpbAyd90uZHs+QiL9NkPFihM3V52o0PVUTAqXIu7VTCa0+h1C eANVjakxCklIY37BiGgOof7yNKBGSMO16qmR3DDGrMp7y6o+oYGA3OPPVr4ElYr2 qv1K693JpQU84+B2sVedvopPrT/XPsMLEcaVsTkbITXCoEjJXVtk6O940ezqbQTh Lo3378lN2yHEdGOc6APgVxAPuiTZ/io6HhaoNLykVmWibTUgUT6j8uoxDr7BMlSq ss8HOD2tBeb/3dEwryP6bC9LbrdKop4ff4y8fmVs/IY64g9UAxaauqXfF7IgA+gk nTIoZrueI/HIfSKrsGQGrU96uPWsPUI4O6rj2RZiKQhyiliN8E5cbFw2rilkfjMo uOt4zj1aajOsFFh6+kl49m1+Avauxt7PGzCyScqn6V0Ayn+UxuI= =ejuW -----END PGP SIGNATURE----- --meqj6nymmrg2mjem--