From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7gC2-0007Dj-W7 for guix-patches@gnu.org; Mon, 08 May 2017 06:47:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7gBy-0006SZ-6t for guix-patches@gnu.org; Mon, 08 May 2017 06:47:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7gBy-0006SS-30 for guix-patches@gnu.org; Mon, 08 May 2017 06:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7gBx-0007JN-MU for guix-patches@gnu.org; Mon, 08 May 2017 06:47:01 -0400 Subject: bug#26803: [PATCH 16/36] gnu: Add java-commons-lang. Resent-Message-ID: References: <20170506153617.3074-1-rekado@elephly.net> <20170506153617.3074-16-rekado@elephly.net> From: Roel Janssen In-reply-to: <20170506153617.3074-16-rekado@elephly.net> Date: Mon, 08 May 2017 12:46:15 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: Hartmut Goebel , 26803@debbugs.gnu.org Ricardo Wurmus writes: > From: Hartmut Goebel > > * gnu/packages/java.scm (java-commons-lang): New variable. > > Co-authored-by: Ricardo Wurmus > --- > gnu/packages/java.scm | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index c9707d0d2..7a68b6bd6 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -1665,3 +1665,58 @@ are many features, including: > (description "Commons-IO contains utility classes, stream implementations, > file filters and endian classes.") > (license license:asl2.0))) > + > +(define-public java-commons-lang > + (package > + (name "java-commons-lang") > + (version "2.6") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://apache/commons/lang/source/" > + "commons-lang-" version "-src.tar.gz")) > + (sha256 > + (base32 "1mxwagqadzx1b2al7i0z1v0r235aj2njdyijf02szq0vhmqrfiq5")))) > + (build-system ant-build-system) > + (outputs '("out" "doc")) > + (arguments > + `(#:test-target "test" > + #:phases > + (modify-phases %standard-phases > + (add-after 'build 'build-javadoc ant-build-javadoc) > + (add-before 'check 'disable-failing-test > + (lambda _ > + ;; Disable a failing test > + (substitute* "src/test/java/org/apache/commons/lang/\ > +time/FastDateFormatTest.java" > + (("public void testFormat\\(\\)") > + "public void disabled_testFormat()")) > + #t)) Since you're renaming the function, I suppose removing the function would also work, which would not create any "dead code". But that probably requires a separate patch file, which will break more easily on an update. So long story short: This is OK to me, even though I don't like producing code that won't be run anyway. > + (replace 'install (install-jars "target")) > + (add-after 'install 'install-doc (install-javadoc "target/apidocs"))))) > + (native-inputs > + `(("java-junit" ,java-junit))) > + (home-page "http://commons.apache.org/lang/") > + (synopsis "Extension of the java.lang package") > + (description "The Commons Lang components contains a set of Java classes > +that provide helper methods for standard Java classes, especially those found > +in the @code{java.lang} package in the Sun JDK. The following classes are > +included: > + > +@itemize > +@item StringUtils - Helper for @code{java.lang.String}. > +@item CharSetUtils - Methods for dealing with @code{CharSets}, which are sets > + of characters such as @code{[a-z]} and @code{[abcdez]}. > +@item RandomStringUtils - Helper for creating randomised strings. > +@item NumberUtils - Helper for @code{java.lang.Number} and its subclasses. > +@item NumberRange - A range of numbers with an upper and lower bound. > +@item ObjectUtils - Helper for @code{java.lang.Object}. > +@item SerializationUtils - Helper for serializing objects. > +@item SystemUtils - Utility class defining the Java system properties. > +@item NestedException package - A sub-package for the creation of nested > + exceptions. > +@item Enum package - A sub-package for the creation of enumerated types. > +@item Builder package - A sub-package for the creation of @code{equals}, > + @code{hashCode}, @code{compareTo} and @code{toString} methods. > +@end itemize\n") > + (license license:asl2.0))) I've seen the '\n' on an earlier patch as well. Why is it neccessary? Otherwise, LGTM! Kind regards, Roel Janssen