From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7g7D-0005eo-3W for guix-patches@gnu.org; Mon, 08 May 2017 06:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7g78-0005AF-IT for guix-patches@gnu.org; Mon, 08 May 2017 06:42:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7g78-0005A9-El for guix-patches@gnu.org; Mon, 08 May 2017 06:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7g78-0007Bp-8p for guix-patches@gnu.org; Mon, 08 May 2017 06:42:02 -0400 Subject: bug#26803: [PATCH 15/36] gnu: Add java-commons-io. Resent-Message-ID: References: <20170506153617.3074-1-rekado@elephly.net> <20170506153617.3074-15-rekado@elephly.net> From: Roel Janssen In-reply-to: <20170506153617.3074-15-rekado@elephly.net> Date: Mon, 08 May 2017 12:41:26 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: Hartmut Goebel , 26803@debbugs.gnu.org Ricardo Wurmus writes: > From: Hartmut Goebel > > * gnu/packages/java.scm (java-commons-io): New variable. > > Co-authored-by: Ricardo Wurmus > --- > gnu/packages/java.scm | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index f595af58c..c9707d0d2 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -1624,3 +1624,44 @@ are many features, including: > such as union, intersection, and closure. > @end itemize\n") > (license license:asl2.0))) > + > +(define-public java-commons-io > + (package > + (name "java-commons-io") > + (version "2.5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://apache/commons/io/source/" > + "commons-io-" version "-src.tar.gz")) > + (sha256 > + (base32 > + "0q5y41jrcjvx9hzs47x5kdhnasdy6rm4bzqd2jxl02w717m7a7v3")))) > + (build-system ant-build-system) > + (outputs '("out" "doc")) > + (arguments > + `(#:test-target "test" > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'symlink-junit.jar > + (lambda* (#:key inputs #:allow-other-keys) > + ;; TODO: don't do this; use make-flags > + ;; The existence of this file is taken as indicator whether test > + ;; dependencies will to be downloaded. > + (let ((junit (assoc-ref inputs "java-junit")) > + (junit-version "4.12")) ; from build.xml > + (mkdir-p "lib") > + (symlink (string-append junit "/share/java/junit.jar") > + (string-append "lib/junit-" junit-version ".jar")) > + #t))) I'm not sure how the result of the code here could be achieved using 'make-flags', so is the TODO item referring to an already-removed piece of code? > + (add-after 'build 'build-javadoc ant-build-javadoc) > + (replace 'install (install-jars "target")) > + (add-after 'install 'install-doc (install-javadoc "target/apidocs"))))) > + (native-inputs > + `(("java-junit" ,java-junit) > + ("java-hamcrest-core" ,java-hamcrest-core))) > + (home-page "http://commons.apache.org/io/") > + (synopsis "Common useful IO related classes") > + (description "Commons-IO contains utility classes, stream implementations, > +file filters and endian classes.") > + (license license:asl2.0))) Otherwise, LGTM! Kind regards, Roel Janssen