From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yBHqDo0/7mKOVgAAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 12:16:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AIX4Do0/7mK26QAA9RJhRA (envelope-from ) for ; Sat, 06 Aug 2022 12:16:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF3F3147C1 for ; Sat, 6 Aug 2022 12:16:44 +0200 (CEST) Received: from localhost ([::1]:35464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKGrL-0006IA-NF for larch@yhetil.org; Sat, 06 Aug 2022 06:16:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKGqg-0006Gb-7t for guix-patches@gnu.org; Sat, 06 Aug 2022 06:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKGqf-0005Sl-Uy for guix-patches@gnu.org; Sat, 06 Aug 2022 06:16:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oKGqf-0000zT-Qg for guix-patches@gnu.org; Sat, 06 Aug 2022 06:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56768] [PATCH] gnu: engineering: Add qucs-s. References: <87ilnlgduf.fsf@gmail.com> In-Reply-To: <87ilnlgduf.fsf@gmail.com> Resent-From: Jean Pierre De Jesus DIAZ Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Aug 2022 10:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56768 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "56768@debbugs.gnu.org" <56768@debbugs.gnu.org> Received: via spool by 56768-submit@debbugs.gnu.org id=B56768.16597809243762 (code B ref 56768); Sat, 06 Aug 2022 10:16:01 +0000 Received: (at 56768) by debbugs.gnu.org; 6 Aug 2022 10:15:24 +0000 Received: from localhost ([127.0.0.1]:32818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKGq3-0000yc-U5 for submit@debbugs.gnu.org; Sat, 06 Aug 2022 06:15:24 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:35929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKGpy-0000yH-9E for 56768@debbugs.gnu.org; Sat, 06 Aug 2022 06:15:23 -0400 Date: Sat, 06 Aug 2022 10:15:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeandudey.tech; s=protonmail3; t=1659780911; x=1660040111; bh=HA0I4AkZXGR0ojiW/sDM6jvYnWee9aT7v4EGiE1ZwKA=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=K7SNge3mUYppotns6pkn1BcLbXKuOekCAIt25AjhZ27yacd6a+/91ejuAs9EnWoVr UhaRJmGVu+e10CmNiV1MuhDwvhpW69VzI6wFO0VFL0rCBkfYptRrdBtR4lPeqGYwVS CwSacXtB/OreEoUnN0u+94ZtyD1WYbA2lv7fKD+y2ARQDK8MP7N28pAWijii57v0n7 q5DSrlDQpeZjPCjLK5Y8EgajQbfn0FLuZQSQ+oxn9q3FDriOmeNQdvm2/DVKaCt7Mq n02N0nj+rGw2g0YJ797CQMq6zjottSYWg8gy2eFFS4DkgsoAYUZYDJkmc0R/fqQ2v9 6KCW6V6ZQElZg== Message-ID: Feedback-ID: 20187791:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Jean Pierre De Jesus DIAZ X-ACL-Warn: , Jean Pierre De Jesus DIAZ via Guix-patches From: Jean Pierre De Jesus DIAZ via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659781005; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HA0I4AkZXGR0ojiW/sDM6jvYnWee9aT7v4EGiE1ZwKA=; b=STDfNAutlFqaX+JxnMvf/LLRgsvzyaAyNlfatxpFP7PLOljHNUEabdNSIHiff9uDN4CJbT D9BXDadxbbKIS9O5MsAWHXzyi5W6EObXcMkBThFoVpmoeOFJIwC+M00WcCnkzweEgvgWQr 7yTdLOYFlm6Ft0oOqG5mCMx28QWl+ePSJUQHESUifHVAv45S/cpmF4iDSIj9HUgwGd+C+N iCre8IKRNc/hm+oG9WzwFdAFnJ8wwUs4yUyteaOYxMcL1Nt9Uy6cJPxJbWOmPHuRaptgTd 2IBk7R4Zs5ekgIufqodFdVemaJgtCH1WZKYIGMcwO3VDI4eft9qsbeen+3CAjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659781005; a=rsa-sha256; cv=none; b=GPYdFSz7KLMCEJek/qmxULNfHdT7gOZVn2CBVKP9Qn92jKUftjkrGRj1SB4Whn1rGemnpL Yzj6as5JtkGo7AEGf6qTp48p6rz3hO8voN6+dhsnZo17mQIX50NO8C8dsVEjqZ7q9G3Fln U+eYY0OgNJKdj7FgEBARn4mOmLmwxry7K7AaljGI0EXtcpOxhCHy0fjB6VCQ86gZ4SJ27V Y2LuQYMmKwzFwAJsZ4YHGfGxNhXcFqY4huqonk9N8q8FS82yzzblJ3eiB0c6bcqnzUJdap 1bvV39bsdC8J9+OYwAP2QcsB3wt2nvO64Ta1CoAt+VV6wbtJ3ZzG0op3VNtCGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=K7SNge3m; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=K7SNge3m; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EF3F3147C1 X-Spam-Score: -4.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0GazbHIc8/Sn Hello Artyom, Just a nitpick: >+ (description >+ "@code{Qucs-S} provides a fancy graphical user interface for a numbe= r of @code{Qucs-S} -> @acronym{Qucs-S, Quite universal circuit simulator with SP= ICE} >Yet at least Qucs-S will always use the right Octave/NGSpice path from >GNU Guix. If the substitute of the binaries path is only done on the `else' block the= n the settings would be respected. For example, on: https://github.com/ra3xdh/qucs_s/blob/master/qucs/main.cpp#L130-L136 > if(settings.contains("NgspiceExecutable")) QucsSettings.NgspiceExecuta= ble =3D settings.value("NgspiceExecutable").toString(); > else { > QString ngsp_exe =3D QCoreApplication::applicationDirPath() + > QDir::separator() + "ngspice" + executableSuffix; > if (!QFile::exists(ngsp_exe)) ngsp_exe =3D QString("ngspice") + ex= ecutableSuffix; > QucsSettings.NgspiceExecutable =3D ngsp_exe; > } Can be substituted to: if(settings.contains("NgspiceExecutable")) QucsSettings.NgspiceExecutab= le =3D settings.value("NgspiceExecutable").toString(); else { QString ngsp_exe =3D "/gnu/store/"; if (!QFile::exists(ngsp_exe)) ngsp_exe =3D QString("ngspice") + exe= cutableSuffix; QucsSettings.NgspiceExecutable =3D ngsp_exe; } Then if `NgspiceExecutable' is present on the configuration that value will= be used, otherwise the default one provided by GNU Guix. Same applies for the other executable files. =E2=80=94 Jean-Pierre De Jesus DIAZ