From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iEHeNN1Pq2LYAwEAbAwnHQ (envelope-from ) for ; Thu, 16 Jun 2022 17:44:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IAvcNN1Pq2IVXwAAauVa8A (envelope-from ) for ; Thu, 16 Jun 2022 17:44:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7377F26C5F for ; Thu, 16 Jun 2022 17:44:29 +0200 (CEST) Received: from localhost ([::1]:45020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1rfY-0005Zi-46 for larch@yhetil.org; Thu, 16 Jun 2022 11:44:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1rf8-0005Z8-EF for guix-patches@gnu.org; Thu, 16 Jun 2022 11:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1rf8-0002YZ-6Q for guix-patches@gnu.org; Thu, 16 Jun 2022 11:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1rf8-0000K7-48 for guix-patches@gnu.org; Thu, 16 Jun 2022 11:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55948] [PATCH 0/2] gnu: Update rocm to 5.1.3. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Jun 2022 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55948 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55948@debbugs.gnu.org, Lars-Dominik Braun Received: via spool by 55948-submit@debbugs.gnu.org id=B55948.16553942411229 (code B ref 55948); Thu, 16 Jun 2022 15:44:02 +0000 Received: (at 55948) by debbugs.gnu.org; 16 Jun 2022 15:44:01 +0000 Received: from localhost ([127.0.0.1]:42898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1rf6-0000Jk-K9 for submit@debbugs.gnu.org; Thu, 16 Jun 2022 11:44:00 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:48030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1rf3-0000JU-1A for 55948@debbugs.gnu.org; Thu, 16 Jun 2022 11:43:59 -0400 Date: Thu, 16 Jun 2022 15:43:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1655394224; x=1655653424; bh=g9ngyLiwt1XSxt+bOxRWWg6IQtbmryHmPNdk18SJ/94=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=T4BBAmx0CU0rXY3yZ/zyAkyyAkAkrvC8fhgcVJSqlRN7g4At2cmi8XhenxjBjd9DH jFTMrPskjQKydZ/QxCg1sUMsnMVOOZHMpYOxuChJNkU9dwtFsEYuQag2z8txflfV57 gNc/uuyg6wuoRXQL2ypbJxYsE0KYgWrTmSYqUQd/v92gfKcvzT4p36wh5Yxb/zFY6Q pa6Y99mJRgb1NUgfap18h1BZiPy5ZsDvo94+u3ZuxxH7T9pudb67Ex4zOGCOrlAz3q AemFlxwiBlR5gugUoErjEtv+YEMj+BKtGjWnSGRFWEwQkxyPCkvCzb5WumqwLR6Jch zhKFtvec71TnQ== Message-ID: In-Reply-To: <87fsk4ls4e.fsf@gnu.org> References: <87sfo4lu22.fsf@gnu.org> <87fsk4ls4e.fsf@gnu.org> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655394269; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=g9ngyLiwt1XSxt+bOxRWWg6IQtbmryHmPNdk18SJ/94=; b=s27g09TyaG06HircIhQN3qYIyugOGE0d4gonEEanx3QLXdAH7WReS6yJuhYa1MNwpQMdOb zBNP5MP41TgAjLx1kBqzz/s+0FtrKLdvdYGfCZGZE+nZGL4x38nt4T2QZd3L98CYytYyGE UAisDYvxg+8OvDBraXqaNUSWiSebJ3xnfe/H8BYAoFitlRFcfGFM4uJVZ2Voie0WZLdelC Id/wFDczwtbuU1JhWpJyMuIGLUOU4mfuV67tnRAJ2gz06+aRUf4rAUD7t3mXk5fZi/xiXd yISqssjfWobnd16ZbIUVOqhAFZntSRDgd4wjgvHxnRhYD2LVVNZMP/pvD2UiuA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655394269; a=rsa-sha256; cv=none; b=W40Q3vT4Ml0esiw6aDpUbYeMzXNfhTXZuyfYZjMQtVBIT7i1ZnF5ZrgMtjiu8xM192SW5d tpljwFYRB4CrNuLIbTRDlwisoMcnxgWmDxlCSjPgfWBicwFkCtf7DVEC0gq/j707necd9J AiU2MLVcm1BqXdp6alckez2D+UqTLnhQ7lA60YrMosYpowiI3iW2kK9dYWNBqNZOt9P7OR hLe+WAH6p7RKtRatj8nsyDwfYOzNdY0aAyOW177rJhJP8wTmq/CLuvRIWWi4qKD4T63kla ikXUQ9WeXtqkPhYvTyJW+Bikl/7T9Li6Shlm8Yq+LkFuMCIP6RgMph6e7E/1Zw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=T4BBAmx0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=T4BBAmx0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7377F26C5F X-Spam-Score: -4.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: KiWYjjKslkd0 Hi Ludo=E2=80=99 and Lars, Thanks for the review and assistance (Lars and I discussed this on IRC a fe= w days ago). ------- Original Message ------- On Thursday, June 16th, 2022 at 8:17 AM, Ludovic Court=C3=A8s wrote: > > diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm > > index 7b197bb67b..f5d3eac588 100644 > > --- a/gnu/packages/llvm.scm > > +++ b/gnu/packages/llvm.scm > > @@ -1127,14 +1127,9 @@ (define-public llvm-for-rocm > > (search-patches "llvm-roc-5.0.0-linkdl.patch" > > "llvm-roc-4.0.0-remove-isystem-usr-include.patch")))) > > (arguments > > - (substitute-keyword-arguments (package-arguments llvm-12) > > - ((#:phases phases '%standard-phases) > > - `(modify-phases ,phases > > - (add-after 'unpack 'chdir > > - (lambda _ > > - (chdir "llvm"))))) > > + (substitute-keyword-arguments (package-arguments llvm-14) > > ((#:configure-flags flags) > > - ''("-DLLVM_ENABLE_PROJECTS=3Dllvm;clang;lld" > > + #~(list"-DLLVM_ENABLE_PROJECTS=3Dllvm;clang;lld" > > "-DLLVM_TARGETS_TO_BUILD=3DAMDGPU;X86" > > "-DCMAKE_SKIP_BUILD_RPATH=3DFALSE" > > "-DCMAKE_BUILD_WITH_INSTALL_RPATH=3DFALSE" > > > John, WDYT? > Fine with me! (I'm assuming Lars had built this version locally as this jus= t seems like a clean up and better inheritance structure.) > > -(define-public rocclr-4 > > - (package > > - (name "rocclr-4") > > - (version "4.3.0") > > Fine with me; John? > Likewise! For some context, Lars and I had discussed on IRC about ROCm drop= ping support in later v4 (and now v5) for hardware he uses. Unfortunately, = figuring out what is supported or works in this space is very difficult as = they cater to more workstation setups. We have time machine and guix past a= t least, though maybe we can keep older versions explicitly. Since Lars mig= ht be one of the few (only?) that uses the older ROCm, I left it to him. ro= cclr v4 is probably not useful on its own, so I'm fine with dropping it. > Lars, feel free to push these if John agrees. > > Ludo=E2=80=99. By the way, I forgot I had to make a kernel change to use this, see https:/= /issues.guix.gnu.org/55111 Let me try again with these patches having lande= d and report back on that issue directly at #55111. Thanks everyone! John