From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id ELcRDoBhymTzbgAASxT56A (envelope-from ) for ; Wed, 02 Aug 2023 16:00:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YMTcDYBhymSObgAAauVa8A (envelope-from ) for ; Wed, 02 Aug 2023 16:00:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F115252517 for ; Wed, 2 Aug 2023 16:00:31 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail2 header.b=c0zJqQdY; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690984832; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aqqwKv/+y68i55hWTTEeXy9dJRgpY+FVKCNEVrHW2Xg=; b=R6lsivFeyY7W1eUKOAwBgAsbnLyDryvSPUJaSuh480oQt+2vw7pEftb9Lm0K5b0EbzgHdH OfDP2o4eGk81YZotjAmom/BqVVPGuuriUMyhGdyBaWh0vZ82oA6hOSlvOsz/PLRvwmJbEh kSX4naAu3c6zZd4HZTZdw3/jzag8YfWNrS0Tjhg1/Kn6Elv4vxvCJ4NXGo7A4qr/yH28AZ UNrZ2LeLildDAIIFUHvWqA9DpXhhSl3z8F4jiXiIArnkYd1yUQpWbxI9Gl8fjjvyKodh7/ b+smlb06UJaK+YSpVeM5vrq44L+pxB5MtOGFAVrSruvDpQJJl0htjv09axSF7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail2 header.b=c0zJqQdY; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690984832; a=rsa-sha256; cv=none; b=Z3mfldNcZJDWV5MrSxbHCVWZ7H1lGByIzk5QGQPEebAdJIAipnax5cmbS+Rjmjbvtw280+ LyFXqU9YDGioad8tIjT8cH5HUd/eWt/CHbMCStqgDbe+sbuSi1kZKB4bpd9Bw5NQmF0dHu VdP3KyO1y9PShwuhGOX7Ik6rsXaurMgWtwFvgtuw/MJ22V6q1L/dkpgCenlgH0h4tMVJTx VeLw7xzNpIT3CJPO/o1+aj4vk9b0DfpSR4t9E3MVPbZHXz+rx8f8nMSTa011NMX+CT3jqw 4qGM1kjRjx0t0YawrkPBmn6oUXF4KwH2c4bOcNGG0GTbkq7S5SzazzqN/iIE8g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRCOW-0004Gm-Ln; Wed, 02 Aug 2023 10:00:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRCOR-0004GR-P4 for guix-patches@gnu.org; Wed, 02 Aug 2023 10:00:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRCOR-0007Qz-9k for guix-patches@gnu.org; Wed, 02 Aug 2023 10:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRCOR-0006kB-1F for guix-patches@gnu.org; Wed, 02 Aug 2023 10:00:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65011] [PATCH] gnu: Add xwinwrap. References: In-Reply-To: Resent-From: Jean Pierre De Jesus DIAZ Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Aug 2023 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65011 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "65011@debbugs.gnu.org" <65011@debbugs.gnu.org> Cc: "sergio.pastorperez@outlook.es" Received: via spool by 65011-submit@debbugs.gnu.org id=B65011.169098478625871 (code B ref 65011); Wed, 02 Aug 2023 14:00:02 +0000 Received: (at 65011) by debbugs.gnu.org; 2 Aug 2023 13:59:46 +0000 Received: from localhost ([127.0.0.1]:49875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRCOA-0006jD-8Q for submit@debbugs.gnu.org; Wed, 02 Aug 2023 09:59:46 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:15853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRCO7-0006iu-Mm for 65011@debbugs.gnu.org; Wed, 02 Aug 2023 09:59:45 -0400 Date: Wed, 02 Aug 2023 13:59:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeandudey.tech; s=protonmail2; t=1690984777; x=1691243977; bh=aqqwKv/+y68i55hWTTEeXy9dJRgpY+FVKCNEVrHW2Xg=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=c0zJqQdYRdpQaZv7Sx19vLRgDn/0jv/e6A/Pv/bSK157gAHzZys4QejUYZsbEhXnh qe20zU5b8eTnXITRNMRrJjmK6zPJpd76ZrOsgsPwfM07Su4ninqEfuChi7iSg1qDbX 7mgwJ55+mbJ3axisgB0oJPgwMVttPByHFks/44JqOnNZzizLgTjLMd2kC3GVo+/Mil KQ3Ygt58TqAjtxcoxaaCPFduoXQ4YvCawwndbqRBI5Y45GFcR4tnSnEND/l6dx4A/w +gB84l3kDx5skxj5YoUuX0k3eSN8yZJCwXh6A0JeMYLFAUiHc+2ngcwTT5wu6c3Lbc SCR2aZHPkUpdg== Message-ID: Feedback-ID: 20187791:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jean Pierre De Jesus DIAZ X-ACL-Warn: , Jean Pierre De Jesus DIAZ via Guix-patches From: Jean Pierre De Jesus DIAZ via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.15 X-Spam-Score: -5.15 X-Migadu-Queue-Id: F115252517 X-Migadu-Scanner: mx1.migadu.com X-TUID: PKtX7SF8ESzQ Hello Sergio, >+ (version "0.0.6") It seems that the project doesn't contain any tag in the upstream repository and doesn't contain mention of any version released. So in that case the common convention is to use 0.0.0 as the version and also it could use (git-version "0.0.0" revision commit) where revision usually starts at 0 and commit is the commit used for the source like other packages do. For example: ``` (define-public xwinwrap (let ((revision "0") (commit "ec32e9b72539de7e1553a4f70345166107b431f7")) (package (version (git-version "0.0.0" revision commit))))) ``` And on the origin's git-reference the string can be simply replaced by the commit variable defined at the top of the package. >+ '(#:phases (modify-phases %standard-phases The new style for defining packages is using G-Expressions, so it would be expressed as: ``` (list #:phases #~(modify-phases %standard-phases ...)) ``` When using G-Exps, this: >+ (mkdir-p (string-append %output "/bin")w Also becomes: ``` (mkdir-p (string-append #$output "/bin")) ``` So, %output can be replaced by #$output in general. >+ (delete 'check) This can be removed and instead the argument `#:tests? #f` could be added, along with an explanation for the motive, i.e. no tests. Cheers, =E2=80=94 Jean-Pierre De Jesus DIAZ