unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jean Pierre De Jesus DIAZ via Guix-patches via <guix-patches@gnu.org>
To: "56959@debbugs.gnu.org" <56959@debbugs.gnu.org>
Cc: "paren@disroot.org" <paren@disroot.org>
Subject: [bug#56959] [PATCH] gnu: packages: Add glad2.
Date: Thu, 11 Aug 2022 14:19:08 +0000	[thread overview]
Message-ID: <oBGDRUVa8Gix79UOFCBCLbx2UY6_idlc_hZsiDO_cc3r68CyVqzFh8M2rbb4Fv9tiuR7BbwcdLZTJp3JfXVTEtFVNb8JQHgbutuUMWKTNd8=@jeandudey.tech> (raw)
In-Reply-To: <20220803194625.6770-1-paren@disroot.org>

Hello,

Small review:

>+                   (lambda* (#:key outputs #:allow-other-keys)
>+                     (let* ((out (assoc-ref outputs "out"))
>+                            (cmake-dir (string-append
>+                                        out "/share/cmake/glad")))

--8<---------------cut here---------------start------------->8---
                   (lambda _
                     (let ((cmake-dir (string-append
                                        #$output "/share/cmake/glad")))
--8<---------------cut here---------------start------------->8---

>+generator. It generates bindings to Vulkan and GL-related APIs from the
>+official Khronos specifications. Among the improvements are:

Missing the additional space after the dots.

—
Jean-Pierre De Jesus DIAZ




  reply	other threads:[~2022-08-11 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 19:46 [bug#56959] [PATCH] gnu: packages: Add glad2 ( via Guix-patches via
2022-08-11 14:19 ` Jean Pierre De Jesus DIAZ via Guix-patches via [this message]
2022-08-12  6:50   ` ( via Guix-patches via
2022-08-12  6:59 ` [bug#56959] [PATCH v2] " ( via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='oBGDRUVa8Gix79UOFCBCLbx2UY6_idlc_hZsiDO_cc3r68CyVqzFh8M2rbb4Fv9tiuR7BbwcdLZTJp3JfXVTEtFVNb8JQHgbutuUMWKTNd8=@jeandudey.tech' \
    --to=guix-patches@gnu.org \
    --cc=56959@debbugs.gnu.org \
    --cc=me@jeandudey.tech \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).