unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#56140] [Patches] Add and update music packages
@ 2022-06-22 12:36 Sughosha via Guix-patches via
  2022-06-24  8:54 ` [bug#56140] Resending the patches with correcting mistakes Sughosha via Guix-patches via
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Sughosha via Guix-patches via @ 2022-06-22 12:36 UTC (permalink / raw)
  To: 56140


[-- Attachment #1.1: Type: text/plain, Size: 13 bytes --]

Empty Message

[-- Attachment #1.2: Type: text/html, Size: 24 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-gnu-Add-fabla.patch --]
[-- Type: text/x-patch; name=0004-gnu-Add-fabla.patch, Size: 1801 bytes --]

From f8fd8c894b62080da31982431550946296e61407 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:32:28 +0200
Subject: [PATCH 4/4] gnu: Add fabla

* gnu/packages/music.scm: add fabla
---
 gnu/packages/music.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a3710adf3a..9f992706b7 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5081,6 +5081,30 @@ (define-public luppp
        "Luppp is a music creation tool, intended for live use. The focus is on real time processing and a fast and intuitive workflow with MIDI mapping support.")
       (license license:gpl3))))
 
+(define-public fabla
+  (let ((revision "18") (commit "10acf03046d980f96ed192d5acb9deb812f5c639"))
+    (package
+      (name "fabla")
+      (version (git-version "1.2.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/openAVproductions/openAV-Fabla")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "0ybbzb86j1n5dfhzc6aa3cibkwi6q3x0c18b1w3anyibanmr1wmc"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f))
+      (native-inputs `(("pkg-config" ,pkg-config) ("lv2" ,lv2)
+                       ("mesa" ,mesa)))
+      (inputs (list ntk cairomm libsndfile))
+      (home-page "http://openavproductions.com/fabla")
+      (synopsis "Drum sampler LV2 plugin")
+      (description "Fabla is a drum sampler LV2 plugin.")
+      (license license:gpl3))))
+
 (define-public sorcer
   (let ((revision "6") (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
     (package
-- 
2.36.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-distrho-ports.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-distrho-ports.patch, Size: 2365 bytes --]

From 98d2fde325564c4a004613546d00a1c6e75502a8 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:31:39 +0200
Subject: [PATCH 2/4] gnu: Add distrho-ports

* gnu/packages/music.scm: add distrho-ports
---
 gnu/packages/music.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 449d4ab250..e691d43d12 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5938,6 +5938,37 @@ (define-public mamba
 ones.")
    (license license:bsd-0)))
 
+(define-public distrho-ports
+  (let ((revision "602") (commit "5907a18cb50dd63d84d37776dfd8e8dcc7f3e378"))
+    (package
+      (name "distrho-ports")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/DISTRHO/DISTRHO-Ports")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1ggl3piwb18gkz3glbqx5h1dcjcc5b9kpssd54fpxddaxagc4pwz"))))
+      (build-system meson-build-system)
+      (native-inputs `(("pkg-config" ,pkg-config) ("cmake" ,cmake-minimal)))
+      (inputs (list fftwf
+                    alsa-lib
+                    freetype
+                    libx11
+                    libxrender
+                    libxext
+                    libxcursor
+                    mesa))
+      (home-page "https://github.com/DISTRHO/DISTRHO-Ports")
+      (synopsis "Linux audio plugins and LV2 ports")
+      (description
+       "This package contains GNU/Linux and LV2 ports of the following plugins: The Function, The Pilgrim, Dexed, dRowAudio plugins (Distortion, Distortion Shaper, Flanger, Reverb, Tremolo), DrumSynth, EasySSP, EQinox, HiReSam, JuceOPL, KlangFalter, LUFS Meter, LUFS Meter (Multichannel), Luftikus, Obxd, PitchedDelay, ReFine, StereoSourceSeperation, Swanky Amp, TAL plugins (Dub-3, Filter, Filter-2, Noize Mak3r, Reverb, Reverb-II, Reverb-III, Vocoder-II), Temper, Vex, Vitalium and Wolpertinger")
+      ;; This package consists of several plugins.
+      ;; Different copyrights and licenses apply to different plugins.
+      (license (list license:gpl2 license:lgpl3)))))
+
 (define-public dpf-plugins
   (package
     (name "dpf-plugins")
-- 
2.36.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: 0001-gnu-Update-sorcer.patch --]
[-- Type: text/x-patch; name=0001-gnu-Update-sorcer.patch, Size: 3204 bytes --]

From ba87d4713da9cc26cc7279c56d287f385bf696bc Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:30:17 +0200
Subject: [PATCH 1/4] gnu: Update sorcer

* gnu/packages/music.scm: updating sorcer to its latest commit fixes its building
---
 gnu/packages/music.scm | 59 ++++++++++++++++--------------------------
 1 file changed, 22 insertions(+), 37 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 60cb176320..449d4ab250 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5055,44 +5055,29 @@ (define-public patchmatrix
     (license license:artistic2.0)))
 
 (define-public sorcer
-  (package
-    (name "sorcer")
-    (version "1.1.3")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/openAVproductions/"
-                                  "openAV-Sorcer/archive/release-"
-                                  version ".tar.gz"))
-              (file-name (string-append name "-" version ".tar.gz"))
-              (sha256
-               (base32
-                "07iyqj28wm0xc4arrq893bm12xjpz65db7ynrlmf6w8krg8wjmd0"))))
-    (build-system cmake-build-system)
-    (arguments
-     `(#:tests? #f                      ; no tests included
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'remove-architecture-specific-flags
-           (lambda _
-             (substitute* "CMakeLists.txt"
-               (("-msse2 -mfpmath=sse") ""))
-             #t))
-         (add-after 'unpack 'build-faust-sources
-           (lambda* (#:key inputs #:allow-other-keys)
-             (with-directory-excursion "faust"
-               (delete-file "main.cpp")
-               (invoke "faust" "-i"
-                       "-a" "lv2synth.cpp"
-                       "-o" "main.cpp" "main.dsp")))))))
-    (inputs
-     (list boost lv2 ntk))
-    (native-inputs
-     (list faust pkg-config))
-    (home-page "http://openavproductions.com/sorcer/")
-    (synopsis "Wavetable LV2 plugin synth")
-    (description "Sorcer is a wavetable LV2 plugin synthesizer, targeted at
+  (let ((revision "6") (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
+    (package
+      (name "sorcer")
+      (version (git-version "1.1.3" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url
+                       "https://github.com/openAVproductions/openAV-Sorcer")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "0ryaglp2pzln2bm0pwc5p9lb2nk0x4wmrs4c4cp6d2m2hhk82yk7"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f)) ;no tests included
+      (inputs (list boost lv2 ntk))
+      (native-inputs (list faust pkg-config))
+      (home-page "http://openavproductions.com/sorcer/")
+      (synopsis "Wavetable LV2 plugin synth")
+      (description "Sorcer is a wavetable LV2 plugin synthesizer, targeted at
 the electronic or dubstep genre.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public sonivox-eas
   (package
-- 
2.36.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #5: 0003-gnu-Add-luppp.patch --]
[-- Type: text/x-patch; name=0003-gnu-Add-luppp.patch, Size: 1862 bytes --]

From e695d37744c81963f22e93af9aafbadd38983b5a Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:32:11 +0200
Subject: [PATCH 3/4] gnu: Add luppp

* gnu/packages/music.scm: add luppp
---
 gnu/packages/music.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index e691d43d12..a3710adf3a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5054,6 +5054,33 @@ (define-public patchmatrix
 OSC connections.")
     (license license:artistic2.0)))
 
+(define-public luppp
+  (let ((revision "29") (commit "23da1497f80dbace48b7807afd3570c57a4d5994"))
+    (package
+      (name "luppp")
+      (version (git-version "1.2.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/openAVproductions/openAV-Luppp")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1rjl7fwnqq1gxa3haw1z0p1mld23i194sc43m03h9isagkwxrx9d"))))
+      (build-system meson-build-system)
+      (native-inputs `(("pkg-config" ,pkg-config) ("cmake-minimal" ,cmake-minimal)))
+      (inputs (list cairo
+                    ntk
+                    liblo
+                    jack-1
+                    libsndfile
+                    libsamplerate))
+      (home-page "http://openavproductions.com/luppp")
+      (synopsis "Live performance tool")
+      (description
+       "Luppp is a music creation tool, intended for live use. The focus is on real time processing and a fast and intuitive workflow with MIDI mapping support.")
+      (license license:gpl3))))
+
 (define-public sorcer
   (let ((revision "6") (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
     (package
-- 
2.36.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56140] Resending the patches with correcting mistakes.
  2022-06-22 12:36 [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
@ 2022-06-24  8:54 ` Sughosha via Guix-patches via
  2022-06-28  7:45 ` [bug#56140] [Patches] Add and update music packages Alice BRENON
  2022-06-28  8:30 ` Sughosha via Guix-patches via
  2 siblings, 0 replies; 5+ messages in thread
From: Sughosha via Guix-patches via @ 2022-06-24  8:54 UTC (permalink / raw)
  To: 56140


[-- Attachment #1.1: Type: text/plain, Size: 123 bytes --]

Sorry that I have not used full sentenses in change log. I came to know about it later. I am sending all the patches again.

[-- Attachment #1.2: Type: text/html, Size: 203 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch1.patch --]
[-- Type: text/x-patch; name=patch1.patch, Size: 3208 bytes --]

From ba87d4713da9cc26cc7279c56d287f385bf696bc Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:30:17 +0200
Subject: [PATCH 1/4] gnu: Update sorcer

* gnu/packages/music.scm: Update sorcer to its latest commit which fixes its building.
---
 gnu/packages/music.scm | 59 ++++++++++++++++--------------------------
 1 file changed, 22 insertions(+), 37 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 60cb176320..449d4ab250 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5055,44 +5055,29 @@ (define-public patchmatrix
     (license license:artistic2.0)))
 
 (define-public sorcer
-  (package
-    (name "sorcer")
-    (version "1.1.3")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/openAVproductions/"
-                                  "openAV-Sorcer/archive/release-"
-                                  version ".tar.gz"))
-              (file-name (string-append name "-" version ".tar.gz"))
-              (sha256
-               (base32
-                "07iyqj28wm0xc4arrq893bm12xjpz65db7ynrlmf6w8krg8wjmd0"))))
-    (build-system cmake-build-system)
-    (arguments
-     `(#:tests? #f                      ; no tests included
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'remove-architecture-specific-flags
-           (lambda _
-             (substitute* "CMakeLists.txt"
-               (("-msse2 -mfpmath=sse") ""))
-             #t))
-         (add-after 'unpack 'build-faust-sources
-           (lambda* (#:key inputs #:allow-other-keys)
-             (with-directory-excursion "faust"
-               (delete-file "main.cpp")
-               (invoke "faust" "-i"
-                       "-a" "lv2synth.cpp"
-                       "-o" "main.cpp" "main.dsp")))))))
-    (inputs
-     (list boost lv2 ntk))
-    (native-inputs
-     (list faust pkg-config))
-    (home-page "http://openavproductions.com/sorcer/")
-    (synopsis "Wavetable LV2 plugin synth")
-    (description "Sorcer is a wavetable LV2 plugin synthesizer, targeted at
+  (let ((revision "6") (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
+    (package
+      (name "sorcer")
+      (version (git-version "1.1.3" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url
+                       "https://github.com/openAVproductions/openAV-Sorcer")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "0ryaglp2pzln2bm0pwc5p9lb2nk0x4wmrs4c4cp6d2m2hhk82yk7"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f)) ;no tests included
+      (inputs (list boost lv2 ntk))
+      (native-inputs (list faust pkg-config))
+      (home-page "http://openavproductions.com/sorcer/")
+      (synopsis "Wavetable LV2 plugin synth")
+      (description "Sorcer is a wavetable LV2 plugin synthesizer, targeted at
 the electronic or dubstep genre.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public sonivox-eas
   (package
-- 
2.36.1

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: patch2.patch --]
[-- Type: text/x-patch; name=patch2.patch, Size: 2365 bytes --]

From 98d2fde325564c4a004613546d00a1c6e75502a8 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:31:39 +0200
Subject: [PATCH 2/4] gnu: Add distrho-ports

* gnu/packages/music.scm: Add distrho-ports.
---
 gnu/packages/music.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 449d4ab250..e691d43d12 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5938,6 +5938,37 @@ (define-public mamba
 ones.")
    (license license:bsd-0)))
 
+(define-public distrho-ports
+  (let ((revision "602") (commit "5907a18cb50dd63d84d37776dfd8e8dcc7f3e378"))
+    (package
+      (name "distrho-ports")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/DISTRHO/DISTRHO-Ports")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1ggl3piwb18gkz3glbqx5h1dcjcc5b9kpssd54fpxddaxagc4pwz"))))
+      (build-system meson-build-system)
+      (native-inputs `(("pkg-config" ,pkg-config) ("cmake" ,cmake-minimal)))
+      (inputs (list fftwf
+                    alsa-lib
+                    freetype
+                    libx11
+                    libxrender
+                    libxext
+                    libxcursor
+                    mesa))
+      (home-page "https://github.com/DISTRHO/DISTRHO-Ports")
+      (synopsis "Linux audio plugins and LV2 ports")
+      (description
+       "This package contains GNU/Linux and LV2 ports of the following plugins: The Function, The Pilgrim, Dexed, dRowAudio plugins (Distortion, Distortion Shaper, Flanger, Reverb, Tremolo), DrumSynth, EasySSP, EQinox, HiReSam, JuceOPL, KlangFalter, LUFS Meter, LUFS Meter (Multichannel), Luftikus, Obxd, PitchedDelay, ReFine, StereoSourceSeperation, Swanky Amp, TAL plugins (Dub-3, Filter, Filter-2, Noize Mak3r, Reverb, Reverb-II, Reverb-III, Vocoder-II), Temper, Vex, Vitalium and Wolpertinger")
+      ;; This package consists of several plugins.
+      ;; Different copyrights and licenses apply to different plugins.
+      (license (list license:gpl2 license:lgpl3)))))
+
 (define-public dpf-plugins
   (package
     (name "dpf-plugins")
-- 
2.36.1

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: patch3.patch --]
[-- Type: text/x-patch; name=patch3.patch, Size: 1862 bytes --]

From e695d37744c81963f22e93af9aafbadd38983b5a Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:32:11 +0200
Subject: [PATCH 3/4] gnu: Add luppp

* gnu/packages/music.scm: Add luppp.
---
 gnu/packages/music.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index e691d43d12..a3710adf3a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5054,6 +5054,33 @@ (define-public patchmatrix
 OSC connections.")
     (license license:artistic2.0)))
 
+(define-public luppp
+  (let ((revision "29") (commit "23da1497f80dbace48b7807afd3570c57a4d5994"))
+    (package
+      (name "luppp")
+      (version (git-version "1.2.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/openAVproductions/openAV-Luppp")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1rjl7fwnqq1gxa3haw1z0p1mld23i194sc43m03h9isagkwxrx9d"))))
+      (build-system meson-build-system)
+      (native-inputs `(("pkg-config" ,pkg-config) ("cmake-minimal" ,cmake-minimal)))
+      (inputs (list cairo
+                    ntk
+                    liblo
+                    jack-1
+                    libsndfile
+                    libsamplerate))
+      (home-page "http://openavproductions.com/luppp")
+      (synopsis "Live performance tool")
+      (description
+       "Luppp is a music creation tool, intended for live use. The focus is on real time processing and a fast and intuitive workflow with MIDI mapping support.")
+      (license license:gpl3))))
+
 (define-public sorcer
   (let ((revision "6") (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
     (package
-- 
2.36.1

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #5: patch4.patch --]
[-- Type: text/x-patch; name=patch4.patch, Size: 1801 bytes --]

From f8fd8c894b62080da31982431550946296e61407 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Wed, 22 Jun 2022 14:32:28 +0200
Subject: [PATCH 4/4] gnu: Add fabla

* gnu/packages/music.scm: Add fabla.
---
 gnu/packages/music.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a3710adf3a..9f992706b7 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5081,6 +5081,30 @@ (define-public luppp
        "Luppp is a music creation tool, intended for live use. The focus is on real time processing and a fast and intuitive workflow with MIDI mapping support.")
       (license license:gpl3))))
 
+(define-public fabla
+  (let ((revision "18") (commit "10acf03046d980f96ed192d5acb9deb812f5c639"))
+    (package
+      (name "fabla")
+      (version (git-version "1.2.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/openAVproductions/openAV-Fabla")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "0ybbzb86j1n5dfhzc6aa3cibkwi6q3x0c18b1w3anyibanmr1wmc"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f))
+      (native-inputs `(("pkg-config" ,pkg-config) ("lv2" ,lv2)
+                       ("mesa" ,mesa)))
+      (inputs (list ntk cairomm libsndfile))
+      (home-page "http://openavproductions.com/fabla")
+      (synopsis "Drum sampler LV2 plugin")
+      (description "Fabla is a drum sampler LV2 plugin.")
+      (license license:gpl3))))
+
 (define-public sorcer
   (let ((revision "6") (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
     (package
-- 
2.36.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56140] [Patches] Add and update music packages
  2022-06-22 12:36 [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
  2022-06-24  8:54 ` [bug#56140] Resending the patches with correcting mistakes Sughosha via Guix-patches via
@ 2022-06-28  7:45 ` Alice BRENON
  2022-06-28  8:30 ` Sughosha via Guix-patches via
  2 siblings, 0 replies; 5+ messages in thread
From: Alice BRENON @ 2022-06-28  7:45 UTC (permalink / raw)
  To: 56140

Hi !

Thanks for submitting this patch ! I'm in no position to provide
a definitive answer to accept or reject this but here are some immediate
things that could be improved.

- your description of Fabla doesn't add much information compared to
  the synopsis. What makes it special ? How is it different from the
  other similar tools ? (see
  https://guix.gnu.org/fr/manual/devel/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions
  for inspiration)
- the other packages seem to have more extensive description, but they
  make very long lines, have you tried formatting your package using
  the `guix style` command ?
  (https://guix.gnu.org/fr/manual/devel/en/html_node/Formatting-Code.html#Formatting-Code)
- you seem to consistently use the "old" syntax for
  packages in native-inputs, as opposed to inputs, is there a good
  reason for that or have you maybe only found examples where the
  native-inputs haven't been modernized ? While it makes sense to
  rename `cmake-minimal` to `cmake` in the definition of
  `distrho-ports` (though I wonder `luppp` didn't require the same
  renaming and keeps the key "cmake-minimal" for `cmake-minimal`, all
  the others occurrences (`("pkg-config" ,pkg-config)`, `("lv2" ,lv2)`…)
  are totally unneeded for as far as I understand and could be
  simplified as `(list pkg-config lv2 mesa)`.

I'm also a bit curious as to why tests need to be explicitly
deactivated in `sorcer`, does running the default cmake command to test
the project result in a failure, not just a NOP ?

I hope some other people will take it over from there because I don't
have much more to contribute : )

Cheers,

Alice




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56140] [Patches] Add and update music packages
  2022-06-22 12:36 [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
  2022-06-24  8:54 ` [bug#56140] Resending the patches with correcting mistakes Sughosha via Guix-patches via
  2022-06-28  7:45 ` [bug#56140] [Patches] Add and update music packages Alice BRENON
@ 2022-06-28  8:30 ` Sughosha via Guix-patches via
  2022-06-28 12:40   ` Maxime Devos
  2 siblings, 1 reply; 5+ messages in thread
From: Sughosha via Guix-patches via @ 2022-06-28  8:30 UTC (permalink / raw)
  To: 56140

[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]

Hi Alice,

First of all, thanks for reviewing my patches :)
> - your description of Fabla doesn't add much information compared to the synopsis. What makes it special ? How is it different from the other similar tools ? (see https://guix.gnu.org/fr/manual/devel/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions for inspiration)
I will improve the descriptions.
> - the other packages seem to have more extensive description, but they make very long lines, have you tried formatting your package using the `guix style` command ? (https://guix.gnu.org/fr/manual/devel/en/html_node/Formatting-Code.html#Formatting-Code)
Sorry that I have forgot this step. I will do it.
> - you seem to consistently use the "old" syntax for packages in native-inputs, as opposed to inputs, is there a good reason for that or have you maybe only found examples where the native-inputs haven't been modernized ? While it makes sense to rename `cmake-minimal` to `cmake` in the definition of `distrho-ports` (though I wonder `luppp` didn't require the same renaming and keeps the key "cmake-minimal" for `cmake-minimal`, all the others occurrences (`("pkg-config" ,pkg config)`, `("lv2" ,lv2)`…) are totally unneeded for as far as I understand and could be simplified as `(list pkg-config lv2 mesa)`.
It's just that I practiced to use the old way for native-inputs. Many packages require to do so, for example `("glib:bin" ,glib "bin")` cannot be declared as somethig like `(list glib)` (as far as I know). It's just that mejority of the packages I defined had required such type of native-inputs, so I practiced it that way.
> I'm also a bit curious as to why tests need to be explicitly deactivated in `sorcer`, does running the default cmake command to test the project result in a failure, not just a NOP ?
`sorcer` was initially not packaged by me. It was failing to build, so I updated it to the most recent commit and removed the commands in the arguments which are no longer required in this commit. Disabling the tests is as it was before, as in the comment it says that tests are not defined in the git repository.

I will improve the patches, fixing mistakes, and then resend the patches.
Thank you.

[-- Attachment #2: Type: text/html, Size: 2999 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56140] [Patches] Add and update music packages
  2022-06-28  8:30 ` Sughosha via Guix-patches via
@ 2022-06-28 12:40   ` Maxime Devos
  0 siblings, 0 replies; 5+ messages in thread
From: Maxime Devos @ 2022-06-28 12:40 UTC (permalink / raw)
  To: Sughosha, 56140

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Sughosha via Guix-patches via schreef op di 28-06-2022 om 08:30
[+0000]:
> glib:bin" ,glib "bin")` cannot be declared as somethig like `(list
> glib)` (as far as I know). 

You can do (list `(,glib "bin") hello other-package etc...) (untested).

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-28 12:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-22 12:36 [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
2022-06-24  8:54 ` [bug#56140] Resending the patches with correcting mistakes Sughosha via Guix-patches via
2022-06-28  7:45 ` [bug#56140] [Patches] Add and update music packages Alice BRENON
2022-06-28  8:30 ` Sughosha via Guix-patches via
2022-06-28 12:40   ` Maxime Devos

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).