From: Gabriel Wicki <gabriel@erlikon.ch>
To: Sughosha <sughosha@disroot.org>
Cc: 74344@debbugs.gnu.org
Subject: [bug#74344] Review
Date: Tue, 26 Nov 2024 23:52:35 +0100 [thread overview]
Message-ID: <nzpu45hnctxowfbkipxsuum5srn5hyc7mejn6fdobffwrqmifg@rmnnx5d2ztgk> (raw)
In-Reply-To: <8682c543b89052ca0f0f76b5159e1da9f43f1ede.1731512783.git.sughosha@disroot.org>
hello there!
thanks for the submission!
general remarks: try not to duplicate the synopsis in the description,
otherwise everything looks fine!
some questions/remarks:
- why disable building examples and demo in qt-advanced-docking-system?
- i am not sure the (chdir "../source") is necessary in qtpromise.
can't you (substitute* "../source/include/QtPromise" ...) directly?
- wouldn't it be nicer to call the variable (and the package)
widget-animation-framework instead of widgetanimationframework?
or qt-widget-animation-framework?
- what does the (snippet ...) do in widgetanimationframework? you
could comment why this is necessary
have a nice week
gabber
next prev parent reply other threads:[~2024-11-26 22:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 15:37 [bug#74344] [PATCH 0/7] gnu: Add jamesdsp Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 1/7] gnu: Add asyncplusplus Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 2/7] gnu: Add qcodeeditor Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 3/7] gnu: Add qt-advanced-docking-system Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 4/7] gnu: Add qtcsv Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 5/7] gnu: Add qtpromise Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 6/7] gnu: Add widgetanimationframework Sughosha via Guix-patches via
2024-11-13 15:46 ` [bug#74344] [PATCH 7/7] gnu: Add jamesdsp Sughosha via Guix-patches via
2024-11-26 22:52 ` Gabriel Wicki [this message]
2024-11-28 8:19 ` [bug#74344] Review Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 0/7] gnu: Add jamesdsp Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 1/7] gnu: Add asyncplusplus Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 2/7] gnu: Add qcodeeditor Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 3/7] gnu: Add qt-advanced-docking-system Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 4/7] gnu: Add qtcsv Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 5/7] gnu: Add qtpromise Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 6/7] gnu: Add qt-widget-animation-framework Sughosha via Guix-patches via
2024-11-28 10:07 ` [bug#74344] [PATCH v2 7/7] gnu: Add jamesdsp Sughosha via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nzpu45hnctxowfbkipxsuum5srn5hyc7mejn6fdobffwrqmifg@rmnnx5d2ztgk \
--to=gabriel@erlikon.ch \
--cc=74344@debbugs.gnu.org \
--cc=sughosha@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).