From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:f42::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oNt+D3xiy2EFfQEAgWs5BA (envelope-from ) for ; Tue, 28 Dec 2021 20:16:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YDZTDHxiy2FxfQAAauVa8A (envelope-from ) for ; Tue, 28 Dec 2021 20:16:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5B9D21CAF for ; Tue, 28 Dec 2021 20:16:11 +0100 (CET) Received: from localhost ([::1]:45800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2HxC-0000he-OS for larch@yhetil.org; Tue, 28 Dec 2021 14:16:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2Hx4-0000hW-5F for guix-patches@gnu.org; Tue, 28 Dec 2021 14:16:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2Hx3-0001WX-Se for guix-patches@gnu.org; Tue, 28 Dec 2021 14:16:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2Hx3-0008Sc-KQ for guix-patches@gnu.org; Tue, 28 Dec 2021 14:16:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52784] [PATCH 0/5] Update XMonad (and add new dependencies) Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Dec 2021 19:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52784 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 52784@debbugs.gnu.org Received: via spool by 52784-submit@debbugs.gnu.org id=B52784.164071892032465 (code B ref 52784); Tue, 28 Dec 2021 19:16:01 +0000 Received: (at 52784) by debbugs.gnu.org; 28 Dec 2021 19:15:20 +0000 Received: from localhost ([127.0.0.1]:47426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2HwO-0008RZ-KH for submit@debbugs.gnu.org; Tue, 28 Dec 2021 14:15:20 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:36392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2HwM-0008RL-MQ for 52784@debbugs.gnu.org; Tue, 28 Dec 2021 14:15:19 -0500 Date: Tue, 28 Dec 2021 19:15:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1640718912; bh=j6hSswuIuLqYr9ROyVKjX1U4YTRa8rWndsYl/qnIlJA=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=OIVFBHqaf8FmTZQruPK6Sw/5QfL9kuSMPpsMqQBj0E3c51OJm9w4rbGS5xQXIrLdp SMoBSXIxTGfmga4ey48gpSlK0o5qtPHEIg0WG+QwAngfiyTMQPCyS2i/+oNWvS7an+ ajchPEm37N0B+YaJpCo7vvnQR3VYNyZ8fmOTzVlu7PS3OdX0iFRUAQ8gD8r10CslTs GUGF9j/IWZ7RBDz84JOR3RZz2dC5h6ahnsyxbFUUrskA1ATIJM6FmaCkahqbqZDKHt yqTn8G4ZzN3eUOWOPYNF3s41WIKEkR2j+YEdpNpc833FDU3qNTWOcF//MgdlDsjgTb waa07N0qAsnlw== Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640718971; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=j6hSswuIuLqYr9ROyVKjX1U4YTRa8rWndsYl/qnIlJA=; b=hzIg6pPBlEN15sKxzlv+kBIP8l1n5eDmvIrP425+C2Y3H+bFS3MCrmiLF8slX93f2C1z79 xlBCRXbn/C9tnI+yUuQwg7IPt6lDy4teyjt6X9G6Jl3NI5/fN/BX0MZ8D3yFRPX/+BEz+H anhiGJUQOj48szXQVocr0/u4sKle4NEew5+ojfV2AvwhRdf5xIYe8Fc84cbWH+C2wQS+ba Ehn34eGzWW6GRVcui0vdX11tXZZi//3PIFF77fTErsDW/udQRZs1BSCShCIRvxWLR/1jxc T5hVtBlfXHdawWd78w1S00IR9qxza6CmDe2TYusdNLB74secvKjd/kkWocXXnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640718971; a=rsa-sha256; cv=none; b=lWuy2Rxqxep+Kt06tLnKUPTJgQ6YXwha82KSuP9h+d/nSpks8Fxje1vvBgEWjdflvKZOq4 9GRBlOCBhCK7XCnJDUZDSiDcMwY41YZTW5SJxt9xqP5ovv51i9dVKUioLHNG0VqEEzKLwM +LdrPv+9tokKDsxDmnUaKTDMhwqcX11dHqWUduiJSssT6WwpjlFtKRswruTcD3yNm9wqch lKIgaKOtoR7acZ6UTEGDyoat0Imsgf3vbxxvP4j3w+4tzbCq0w9Up/3ZnNZAklYNTc73sO tc6d3yESNMdwXqELWg9a+EA8feEeHeez2I37Dpgw3cLGD1/SzVbFfvoX8MSA3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=OIVFBHqa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.57 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=OIVFBHqa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B5B9D21CAF X-Spam-Score: -3.57 X-Migadu-Scanner: scn1.migadu.com X-TUID: OZDE2xUOkW13 Hi Lars, Thanks for taking a look and testing. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Tuesday, December 28th, 2021 at 5:24 AM, Lars-Dominik Braun wrote: > Hi John, > > thanks for your patches. I also upgraded xmonad locally (see > attached patch), but I didn=E2=80=99t need the version bumps/new packages > (i.e. xmonad=E2=80=99s test suite builds and runs fine). Are they really > necessary? > I can confirm your patch also builds and checks fine (though didn't look at= the log in much detail). Taking a quick look at the new dependency, it is for some testing but seems= optional: https://github.com/xmonad/xmonad/commit/031bbd62306e592ddd0768d4= e5b1105bf5e81032 So maybe that's why it builds/checks fine. Since we can ea= sily add the needed packages, I would err on including it, what do you thin= k? I removed/added dependencies based on a fresh guix import and looking at th= e Hackage info for xmonad. I think some of the dependencies that were remov= ed were due to older versions (or to support older GHC?) or I guess librari= es that aren't needed anymore. > > Note that this new version has breaking configuration changes, detailed= in their announcement: https://xmonad.org/news/2021/10/27/xmonad-0-17-0.ht= ml Is that worth a news entry for guix pull? It has been a long time since = xmonad released a new version, for those that stay on the stable release. > > I was also hesitant to push the new version for this reason. Additionally > xmonad is part of Stackage, which we use where possible. How about adding > a xmonad-next package instead and make the switch when Stackage includes > the new version? > We do tend to follow LTS Stackage, but I wasn't sure how something like XMo= nad fits since I imagine most people that use it aren't using Haskell other= wise. Also, since it has been a few years since they had a release, I thoug= ht it would be nice to have it. Anyway, an xmonad-next could make the transition easier for anyone using th= e previous stable release. I've been using cabal but with an update in Guix= would look to make my setup more Guix-y. To summarize, I would opt for the changes in dependencies to follow upstrea= m, and making a separate xmonad-next avoids further disruption anyway. Pers= onally, I also wanted to submit those new packages as part of a whole lot o= f Haskell packages I will be submitting to get haskell-gi and taffybar in G= uix. Thanks, John