From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6IKmBySl5mbGiQAAqHPOHw:P1 (envelope-from ) for ; Sun, 15 Sep 2024 09:13:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 6IKmBySl5mbGiQAAqHPOHw (envelope-from ) for ; Sun, 15 Sep 2024 11:13:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="IW/mZ6lB"; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=GwdD0wBs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726391588; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YiAVkud2j6BuYhU0EMxewsLxlv/jZYx1QPsrkx21EsI=; b=Dejv8r2OJ3QF4bk0y0DXAnzuXcPDJdnZqknvEu7p6a6Om2Z7ci9/RpCfVE4FN4WpshZpvO WyHaNAKVt5JR3a9wt3UVKADUZ7pw5y/AYqrvoYXkne/gWbmCjfGyjyWnZIgSsBQceW6FPW HyQFl/I26+OZLoy24/5QnRSmf1Y/Tk0DkYdGbwrJhSbzewSuGlMv03v1ouvVHRynjPwZkt pcnPRx+6dOAuNsegT4QEjMcYFmApMAnU1c5QvNSJu1U0l4M0PNGW+UH7GexdbrIgRZHiRi 1PcwDgPb9o2PXLEIUevkRoUHNkstQF/7q6L2CblSv3QyhZfPUM8jkpmALEdbyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726391588; a=rsa-sha256; cv=none; b=UfTeY26Q0/U5NVzP8IhSQVdTGsEr+cxvvq5/u7uI5OcCf/T/zIw3M5Z1bfRVgrsocg9hxm dAIB6VypiI3xXKuyUjlnl6UVh3TyIoHRXCpLzrmWGy8zbUu6rqtVNPKvpF+3NWajmQ2Kn/ Gr8ObC3qyYOMe0FYfZ0RWveyJajaEt/btUJ1Xc4PCAjAGmN7nqlI0RMTzALPY92gv/GKJQ 21B8W3LVLs6FSHXmfkUEuMsRVUyxe2snh7o5AWqOw87u4ZL6B8B0VjWTzbwNIi18Noh7vg VF563HK6f7SjmSS9KKvV9vToO74MJyVLNuxLXfkOZ0/4E4DAoAOPX0xHPHqnRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="IW/mZ6lB"; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=GwdD0wBs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A51B8188DB for ; Sun, 15 Sep 2024 11:13:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1splJN-0001Uo-KK; Sun, 15 Sep 2024 05:12:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1splJM-0001Ue-72 for guix-patches@gnu.org; Sun, 15 Sep 2024 05:12:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1splJL-000797-T7 for guix-patches@gnu.org; Sun, 15 Sep 2024 05:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=YiAVkud2j6BuYhU0EMxewsLxlv/jZYx1QPsrkx21EsI=; b=IW/mZ6lBFG+d2/ErmxEgU+MrSQ0zXhkFoz4MJW5ZU0rZz5MV5n5pvvbqajm37DLh9WJR+F9OC5TYS5YMzOjnvtFj0JH+NQ7FKgLXLUedm0+6gdNAcCyqxdqKMVaZAQRnTwm+AGMrPRUTEwcTV8TykS2dJx8S6BTPOVtoafwk7/xIgXC8Bx2xFK4YwORVUtNiGNufQ6e8WqcVhYeL6z6FL/Wv4IYgnrpitEPjis6Rr6r+0ndvqTR9ZBHeyy43kHnCAKKlpw/4Jlywx7mqH+MeF4M/UN7wBb5cc1JhBpLO0LLuaF5R99T3gA/cJLDBzVfT319vgR3EEmGP81E3ewKdeg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1splJW-0006nC-GQ for guix-patches@gnu.org; Sun, 15 Sep 2024 05:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72457] [PATCH v5 00/15] Rewrite bootloader subsystem. References: In-Reply-To: Resent-From: Herman Rimm Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Sep 2024 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72457@debbugs.gnu.org Cc: Lilah Tascheter , Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= , Sergey Trofimov Received: via spool by 72457-submit@debbugs.gnu.org id=B72457.172639158226108 (code B ref 72457); Sun, 15 Sep 2024 09:13:02 +0000 Received: (at 72457) by debbugs.gnu.org; 15 Sep 2024 09:13:02 +0000 Received: from localhost ([127.0.0.1]:48439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1splJV-0006mw-9k for submit@debbugs.gnu.org; Sun, 15 Sep 2024 05:13:01 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:40365 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1splJT-0006ma-11 for 72457@debbugs.gnu.org; Sun, 15 Sep 2024 05:13:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1726391556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YiAVkud2j6BuYhU0EMxewsLxlv/jZYx1QPsrkx21EsI=; b=GwdD0wBsRRjZRrklpa7ZTvH5fZNhpdBbLAmwxMU+zkYmJMzdLidv5eB8LGnXXTHj15G+Jv 06FJ4FojexjEW1nt2PHNsltMbk7UpdtUWJmZuiB9JmB1HW40rJ5W8UshZo21Nr/D2ZL7oo gO/l61RilpPGVfhg+j1jKeGZe9q4/9btFwRjQ0TYhfweyWZ9Ywoq01itFqDOvsh0Ejzqd3 VkM3yGqFW7Fe+0UU48ORkQMEZIieXeVBCcxG52iAGnrwr7+P45zZoC5lcz6Y4kjtYGE8i4 NZMMDCP93TapPWFwtyo6WHrgBxo5l6b8STuO2AGGd8rKCw9QW3qAMLc27+nmRw== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 2aa2de7c (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 15 Sep 2024 09:12:35 +0000 (UTC) Date: Sun, 15 Sep 2024 11:11:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Herman Rimm X-ACL-Warn: , Herman Rimm via Guix-patches From: Herman Rimm via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.50 X-Migadu-Queue-Id: A51B8188DB X-Spam-Score: -6.50 X-TUID: cX8CWR13erg5 Hi, I dislike that so few patches change from revision to revision, according to the diffstat. I like the ratio of discussion to patch submission messages in #68524 more, and I think splitting the patches over multiple series will result in fewer patch submissions overall and discussion that is relevant to every patch in a series. I would like to submit a rewritten patch series. Basically, it would consist of patches #4, #6, #12, #13, and #14. I want to submit #1, #2, #3, #5 and #15 to issue #73202, and #7, #8, #9, #10 (excl. efibootmgr) and #11 to #68524. Parts of patch #4 which fit better with #73202 or function standalone would be submitted to #73202. Finally, #4 will be split into seven to ten patches, hopefully making referring to changes easier and review less demanding. Please let me know what you think about the proposed patch series. By the way, assuming 'herman' is the remote for [1], you can see the current changes of my rewrite by running: git diff herman/bootloader-v5 herman/uki-efi-bootloader. Aside from that, %test-installed-os is broken for (at least) the v5 patch series. It results in [2], after having fixed guix/scripts/system.scm like so: (mlet* %store-monad ((alt -> (generation->boot-alternative profile 1)) (inst (apply install-bootloader local-eval bootloaders - (list alt) #:dry-run (not install-bootloader?) + (list alt) #:dry-run? (not install-bootloader?) #:root-offset target bootmeta))) (maybe-copy (derivation->output-path inst))) The steps I took to get [2] are: create channels.scm for my bootloader branch, git checkout the branch, append %test-installed-os to gnu/tests/install.scm, and run guix time-machine -C channels.scm -- build -f gnu/tests/install.scm. On master (or issue #69343) it seems grub.cfg is built together with the system and provenance derivations, before 'initializing operating system under /mnt'. If anything, let me know if you fail to reproduce [2] with the fixed v5 series or on my branch. I will try fix [2] next weekend, so feel free to look into it this week. Cheers, Herman [1]: https://codeberg.org/herman_rimm/guix [2]: =2E.. guix (GNU Guix) 1022e6330f17bd5fa2cddbc29c7f9bebb9c1fe0e Copyright (C) 2024 the Guix authors License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. + export GUIX_BUILD_OPTIONS=3D--no-grafts + GUIX_BUILD_OPTIONS=3D--no-grafts + guix build isc-dhcp /gnu/store/xai38dx802al26bnxcb788y027r5y7m5-isc-dhcp-4.4.3-P1 [1m[0m+ parted --script /dev/vdb mklabel gpt mkpart primary ext2 1M 3M mkpa= rt primary ext2 3M 1.6G set 1 boot on set 1 bios_grub on [ 62.769814] vdb: vdb1 vdb2 + mkfs.ext4 -L my-root /dev/vdb2 mke2fs 1.47.0 (5-Feb-2023) Discarding device blocks: 0/389888=08=08=08=08=08=08=08=08=08=08=08=08= =08 =08=08=08=08=08=08=08=08=08=08=08=08=08done = =20 Creating filesystem with 389888 4k blocks and 97536 inodes Filesystem UUID: 043cc525-a895-466f-9265-b5aeea921454 Superblock backups stored on blocks:=20 32768, 98304, 163840, 229376, 294912 Allocating group tables: 0/12=08=08=08=08=08 =08=08=08=08=08done = =20 Writing inode tables: 0/12=08=08=08=08=08 =08=08=08=08=08done = =20 Creating journal (8192 blocks): done Writing superblocks and filesystem accounting information: 0/12=08=08=08= =08=08 =08=08=08=08=08done + mount /dev/vdb2 /mnt [ 63.052091] EXT4-fs (vdb2): mounted filesystem 043cc525-a895-466f-9265-b= 5aeea921454 r/w with ordered data mode. Quota mode: none. + df -h /mnt Filesystem Size Used Avail Use% Mounted on /dev/vdb2 1.5G 404K 1.4G 1% /mnt + herd start cow-store /mnt Service user-homes has been started. Starting service cow-store... Service cow-store has been started. + mkdir /mnt/etc + cp /etc/target-config.scm /mnt/etc/config.scm + guix system init /mnt/etc/config.scm /mnt --no-substitutes [1;35mThe following derivations will be built: [0m [2m/gnu/store/gs0rca6bwf8q6qd3x1k01bsp55g2i3hr-[0msystem.drv [2m/gnu/store/xvzfxgrsjch583l28davaz2wi80nzvkj-[0mprovenance.drv [1m[0m [Kbuilding /gnu/store/xvzfxgrsjch583l28davaz2wi80nzvkj-provenance.drv... [K [Kbuilding /gnu/store/gs0rca6bwf8q6qd3x1k01bsp55g2i3hr-system.drv... [K/gnu/store/77pr7kifgjypha2hy0r1yxwmcg8aq9jn-system initializing operating system under '/mnt'... populating '/mnt'... [1;35mThe following derivations will be built: [0m [2m/gnu/store/zvn5lrkaxfv4nj60v8h1fqqy4g1akybh-[0mmodule-import.drv [2m/gnu/store/k93g3ifqka252zb72kl433wh7fw8nicq-[0mmodule-import-compiled.= drv [2m/gnu/store/1sgmdnq6zpdsmycbmssd7980fs8y45s8-[0minstall-bootloader.scm.= drv [2m/gnu/store/5r4h565d6i8kx1ym0w2ynnzidggk0yg1-[0mmodule-import.drv [2m/gnu/store/6pmgvmr1hwj7pz7k4nxl899rjpn5g259-[0mmodule-import-compiled.= drv [2m/gnu/store/hdv9h1ncyadn4k3vl0ls5mlzh75d16ka-[0mcore.img.drv [2m/gnu/store/3ik7z6x0kd140rdzsp9g6kd8dpk22syp-[0mcore.cfg.drv [2m/gnu/store/ln9848cyw0dkvnihvxkxbs05sakqd8la-[0mgrub.dir.drv [2m/gnu/store/3vl0qggja79733r1dsc5mjfj888cj13y-[0mgrub.cfg.drv [2m/gnu/store/a6vnyj0s34w9ad962h8g2g98ihkql7zm-[0mgrub-image.png.drv [2m/gnu/store/53fady56y14p4y0a7aw8rypc3qwbb1xs-[0mguile-cairo-1.11.2.drv [2m/gnu/store/09cwfzjgg02zcf66361qhxsfcanim7zl-[0mmake-4.4.1.drv [2m/gnu/store/09kis2ig2xk8xrgwzh2y42ya0jwkmc4a-[0mbzip2-boot0-1.0.8.drv [2m/gnu/store/0vnv3n7vllwb4672rxsd6xkfx50lz2is-[0mxz-mesboot-5.4.5.drv =2E..=20 [1m[0m [Kbuilding /gnu/store/zvn5lrkaxfv4nj60v8h1fqqy4g1akybh-module-import.drv... [K [Kbuilding /gnu/store/hx1w3j5icxgrhjhvkvs8cc00iag88cay-CPAN-Meta-2.150010.t= ar.gz.drv... [K\ [K| =2E.. [K/builder for `/gnu/store/hx1w3j5icxgrhjhvkvs8cc00iag88cay-CPAN-Meta-2.150= 010.tar.gz.drv' failed to produce output path `/gnu/store/vbcdsc51aypfxaw6n= f2qcdn3kyfx4ixb-CPAN-Meta-2.150010.tar.gz' [K[31;1mbuild of /gnu/store/hx1w3j5icxgrhjhvkvs8cc00iag88cay-CPAN-Meta-2.15= 0010.tar.gz.drv failed[0m [1mView build log at '/var/log/guix/drvs/hx/1w3j5icxgrhjhvkvs8cc00iag88cay-= CPAN-Meta-2.150010.tar.gz.drv.gz'.[0m [Kbuilding /gnu/store/1498qsnrk07npvl4sblvlrpc1nhssjj9-CPAN-Meta-Requiremen= ts-2.140.tar.gz.drv... cannot build derivation `/gnu/store/6lxv0agdrs4xfg4kjw4fakmsdsy83l5i-perl-c= pan-meta-2.150010.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/acys5h6lbbrf66jssw3081saxc9g1mn4-perl-p= arse-cpan-meta-2.150010.drv': 1 dependencies couldn't be built [Kbuilding /gnu/store/qnrf3grnxbb3z9a05jd77lbjry7xk5mv-Cython-0.29.32.tar.g= z.drv... cannot build derivation `/gnu/store/5qnifhvpm2zlm7wic44z06qih5mw337h-perl-t= est-pod-1.52.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/wikxyp9h4a21j3k0wvpl8pq0wzfz4zmd-perl-u= nicode-utf8-0.62.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/j0bv34d7z1wi0w79ggvmrq71yjklv46x-perl-p= ath-tiny-0.118.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/4064nhqy89x4va9dryq9mi5fprp8b61d-perl-x= ml-xpath-1.48.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/103sn6krasxcca0wm4s1w4lhvqhj8j44-docboo= k-xsl-1.79.2-0.fe16c90.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/c8pfxw2akqj6za5vs1xdhci1zvjfjiji-vala-0= =2E56.16.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/68i1misqx2w581cylh3hzkr7v6a0hws7-librsv= g-2.56.4.drv': 1 dependencies couldn't be built [Kbuilding /gnu/store/83y4zf06iqv3xjz3pjzhmdim76bs53p2-Python-3.10.7.tar.xz= =2Edrv... cannot build derivation `/gnu/store/6csl2268yhidg8vddy6nb32623fxkypk-guile-= rsvg-2.18.1-0.05c6a2f.drv': 1 dependencies couldn't be built [Kbuilding /gnu/store/3ik7z6x0kd140rdzsp9g6kd8dpk22syp-core.cfg.drv... cannot build derivation `/gnu/store/a6vnyj0s34w9ad962h8g2g98ihkql7zm-grub-i= mage.png.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/ln9848cyw0dkvnihvxkxbs05sakqd8la-grub.d= ir.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/1sgmdnq6zpdsmycbmssd7980fs8y45s8-instal= l-bootloader.scm.drv': 1 dependencies couldn't be built guix system: [1;31merror: [0mbuild of `/gnu/store/1sgmdnq6zpdsmycbmssd7980f= s8y45s8-install-bootloader.scm.drv' failed environment variable `PATH' set to `/gnu/store/h6n705ghnl1qi7p4xm7z796nx7cl= 7dv0-qemu-minimal-8.2.2/bin' QEMU runs as PID 22 connected to QEMU's monitor read QEMU monitor prompt connected to guest REPL marionette is ready ;;; (uname #("Linux" "gnu" "6.10.7-gnu" "#1 SMP PREEMPT_DYNAMIC 1" "x86_64"= ))