From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id eM4+IPZh7GYOzwAA62LTzQ:P1 (envelope-from ) for ; Thu, 19 Sep 2024 17:40:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id eM4+IPZh7GYOzwAA62LTzQ (envelope-from ) for ; Thu, 19 Sep 2024 19:40:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=GYnmJ0ZX; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=DoOih+Di; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726767606; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QTDgF0FqBnC94qCJiTvXZVlMTlUs07Vm7JLdNOXI1jE=; b=AWLwCU3CvbzmyZlkNKmH1QeOcEo0+JVBGmjbqtGrk64cgBaUMF0cXSZsx2TMzxe7NlIxpS MW/OOJUYPKhoXh5c0qVW0c6mfXQuNHGJGiGwhnVBUpwcNlBdn5SFOnZuPliq0eUt+cou1p LLjkFrjWYkDB78LO4kNYufW++CiDvzwSpbEyr+RHCOFoT2PB99RBML0B0+ZmbU8I4OpzlA zImyFfjLcaVTkAQEQKaf+Vg/wYYMtiuTPQTZaYrL4aaLzc/pjeChh5bOFdzwBNKD3cnLlD KSNcw1VwPkhf3CFILPzniuYnW+aUXDAUhCx4w5unPv1BnzV8uHXKHS772wJtdA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726767606; a=rsa-sha256; cv=none; b=sbQLsETB+x+UY03qVS36r02n/Zmdw2O6wSRhSG4ytSo1eEYJ7I6K/nKG8Q2lqI+REdcFLo Dyp5Gx9XlTVf03BsrU9Z5fCSVd7ZIoL+6cxxDMvN+aFuVzEnRetCEZ68p3DNA22ixPSvEc UJkTOxRSuxkWOn1AYuLp2VDN5JIYRWEdd/J7kC3fmw4NFaGhNSzeUfkGvBqI+961SHvrzw HZ7B7opkPfTIoiPSYSJjbOt9HUBVQXWWv+R0lwNBH7JTym069Yx9n7Luz8SKfkjW/At8LT Ke1b1jC6bXY3yC+Y3g5yHWfI6WRUBpA60bPtVMPpG2tbKoupJnYHEWTObnrKaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=GYnmJ0ZX; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=DoOih+Di; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8EE2D59AA6 for ; Thu, 19 Sep 2024 19:40:04 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srL8C-0003T7-0F; Thu, 19 Sep 2024 13:39:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srL85-0003Qd-9l for guix-patches@gnu.org; Thu, 19 Sep 2024 13:39:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srL84-0000JF-S9 for guix-patches@gnu.org; Thu, 19 Sep 2024 13:39:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=QTDgF0FqBnC94qCJiTvXZVlMTlUs07Vm7JLdNOXI1jE=; b=GYnmJ0ZXt+frdK3EIecGnSo6WqkpVc8YVHHeRJ5UgGkCxBzReMiL3qiBsQq0FfKuC58Aljk3hQwy0UOB4OdYD+8am6SZlIPjCCPD+brW/C9TmHYYcvw3m5othfecyvC9+sKm6UuHfYz6HwukRhB2wUcqf6L7qaH9sm5A0eIOhf8gYSJN39frhwHsUpWi8s85uX7qmWABpjp/1SrbGzzuiCAxQHt+n975Bqugbq1FhILBQmoJUyyRub/DqF4K55mC+zy4ooggFAqH+Tw7TysC/CWOHCB69d8Aad6StsHKDRVhuM39vToK813o6b3GK8zZ1rtGe17/FYf4OPt4c6aL3Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srL8M-0004kS-4W for guix-patches@gnu.org; Thu, 19 Sep 2024 13:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72457] [PATCH v5 00/15] Rewrite bootloader subsystem. Resent-From: Herman Rimm Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Sep 2024 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72457@debbugs.gnu.org Cc: Lilah Tascheter Received: via spool by 72457-submit@debbugs.gnu.org id=B72457.172676759518229 (code B ref 72457); Thu, 19 Sep 2024 17:40:02 +0000 Received: (at 72457) by debbugs.gnu.org; 19 Sep 2024 17:39:55 +0000 Received: from localhost ([127.0.0.1]:33463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srL8E-0004jx-Kn for submit@debbugs.gnu.org; Thu, 19 Sep 2024 13:39:55 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:34181 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srL8B-0004ji-Na for 72457@debbugs.gnu.org; Thu, 19 Sep 2024 13:39:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1726767566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QTDgF0FqBnC94qCJiTvXZVlMTlUs07Vm7JLdNOXI1jE=; b=DoOih+DiM7zBOT4y91rVNoOXTF4FMeRTZD4lfNtR6ADeb+pjh0E6Tem2OE7XrEDVU0tJzJ 9rHSVxmYzCkDYzi8359bh/qt1aCsy3X0iR6D25bgv1sjAOW7WZPuCGEQAPv+BXErFdM+S8 mg3q8Ba0uPNB9nfrwiWxG0pxtRTVn7n68+T8BMf5J+nkl+3ItI6UAj5a1uSpiRbna088Xm +XZcLhybodjDYr8RTyysO+r4TlS/ot1r80GIZxg7Kd56gsIGtGya0qbjy3HkK64l3DDZ4I 3quOSed6aoPZC3Kb+mMq0owOTyo4dkkvlpP1aGEvtGIf9nzXj0d/kv0m2NSgQQ== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id cbd6894a (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 19 Sep 2024 17:39:25 +0000 (UTC) Date: Thu, 19 Sep 2024 19:38:52 +0200 Message-ID: References: <6v2spbtqb66twxchy4wkmoq6fyjqtrr2g3mhotwignplqwjxl4@qpeqf5d6hxow> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6v2spbtqb66twxchy4wkmoq6fyjqtrr2g3mhotwignplqwjxl4@qpeqf5d6hxow> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Herman Rimm X-ACL-Warn: , Herman Rimm via Guix-patches From: Herman Rimm via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.41 X-Spam-Score: -4.41 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Queue-Id: 8EE2D59AA6 X-TUID: lPw/mfJeTDyA Hello, On Thu, Sep 19, 2024 at 05:35:42PM +0200, Herman Rimm wrote: > Anyway, maybe you can send a diff based on/relative to: > Include something like this, to get code that actually compiles and is not extremely fragile: diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 73176bddff..ee0fe450ba 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -495,14 +495,14 @@ (define (report-duplicate-type-field targets) (seen '())) (match targets ((target rest ...) - (let (type (bootloader-target-type target))) + (let ((type (bootloader-target-type target))) (when (memq type seen) (error loc (G_ "target with duplicate type~%") duplicate)) - (loop rest (cons type seen))) + (loop rest (cons type seen)))) (() #t)))) -(define-with-syntax-properties (warn-update-targets (targets properties)) - (let ((targets (if (list? targets) targets (list targets))) +(define-with-syntax-properties (warn-update-targets (value properties)) + (let ((targets (if (list? value) value (list value))) (loc (source-properties->location properties))) (define string->target (match-lambda Cheers, Herman