From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0A7iKl2dlF/VVAAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 21:32:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +MLNJl2dlF/QVwAA1q6Kng (envelope-from ) for ; Sat, 24 Oct 2020 21:32:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0977F940439 for ; Sat, 24 Oct 2020 21:32:13 +0000 (UTC) Received: from localhost ([::1]:57392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWR92-0000NI-0A for larch@yhetil.org; Sat, 24 Oct 2020 17:32:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWR8t-0000Mx-EC for guix-patches@gnu.org; Sat, 24 Oct 2020 17:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWR8t-0002UA-4M for guix-patches@gnu.org; Sat, 24 Oct 2020 17:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWR8t-0007HC-1s for guix-patches@gnu.org; Sat, 24 Oct 2020 17:32:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44170] [PATCH] gnu: Correct Inkscape extension dependencies Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 21:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: "44170@debbugs.gnu.org" <44170@debbugs.gnu.org> Received: via spool by 44170-submit@debbugs.gnu.org id=B44170.160357509927923 (code B ref 44170); Sat, 24 Oct 2020 21:32:03 +0000 Received: (at 44170) by debbugs.gnu.org; 24 Oct 2020 21:31:39 +0000 Received: from localhost ([127.0.0.1]:35345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWR8V-0007GJ-Ej for submit@debbugs.gnu.org; Sat, 24 Oct 2020 17:31:39 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:11196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWR8Q-0007G0-P4 for 44170@debbugs.gnu.org; Sat, 24 Oct 2020 17:31:37 -0400 Date: Sat, 24 Oct 2020 21:31:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail2; t=1603575087; bh=deeQYD3zSUzbPWtOznq8tAvpIbjz0YXOqzdTLeJqUUo=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=XLwO3O729WGEtD5+P2PdT0eKjXFnMUwcJaSF973pqFZRRk5gvOHd0qUv2AQP9WQaE I2JNOACIQyglJg89ln1unYkDEu7KzEZDefSzuLxbVscLjPzDKLIn2j68IXlcQ3mgHM Es1bDQV+sY+6tlgicZwdKr201z8TA9IBncdKvv8EpyYhJwJcSJEvao9QGQzYTtK/0d iWAq8tXCjaeeaB5q9QEu6RgBC69EjPsyD0176n/aOuV5XV9GkZIS9gEoRPukv5faO7 mVc6RnCtTzeFirYWmlJf4nE3QuwPxi5e+5ZSUSDKTtV4+6DhEp391moG0J8z65DB8D vMwmRfzG+N6Ng== From: Ekaitz Zarraga Message-ID: In-Reply-To: <87mu0bbdqx.fsf@cbaines.net> References: <87mu0bbdqx.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=elenq.tech header.s=protonmail2 header.b=XLwO3O72; dmarc=fail reason="SPF not aligned (relaxed)" header.from=elenq.tech (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: ghhDwE3FnYAA Hi, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Saturday, October 24, 2020 9:55 PM, Christopher Baines wrote: > > > Ekaitz Zarragaekaitz@elenq.tech writes: > > > Updated with file-name thanks to Christopher Baines' help. > > Guix lint is not complaining anymore about the file name. > > (it complains about the version but it's because of a bad naming system > > upstream) > > I've had a proper look at this patch now. In general, especially for > adding new packages, do one thing per commit. I've split out the > addition of python-scour in to it's own commit and pushed that now. Thanks. I'll take that in account in the future. > I had some thoughts on the inkscape changes though. I had some too, thanks for elaborating. > > > > - (,(string-append python "/bin:"))))) > > The : after /bin is unnecessary. I copied all this from Kicad's package because it's a software that has a similar python plugin style. > Also, it looks like python-wrapper is already referenced lots in the > output, did you have a specific reason why wrapping inkscape with the > PATH was useful? Not really. I just copied it from kicad and followed the discussion at guix-devel... I thought it was necessary but watching what python-wrapper does it's probably not necessary. I'll try it without the PATH and remove it if it's not useful. I'll compare with kicad's package too, because they are very similar so they should have some relation on this too. > > > > > > So, before python-wrapper was a native-input, and you've added some > Python packages as native inputs. > > The distinction for inkscape between an input and a native input is > mostly academic at this point, because the meson build system doesn't > support cross builds. > > However, inkscape already uses references python-wrapper in its output, > so it should probably be an input. With this change, you're also setting > out that inkscape should be able to use these Python libraries at > runtime, hence they should be inputs (matching the architecture you're > building for), rather than native inputs (matching the architecture > you're building on). > > Does that make sense? Something obviously doesn't. :) In my understanding, python should be an `input` but it was already in `native-inputs`, I don't know why. So I considered all the rest of the python-related packages should be in the same block. If I did this package I would add python-* and python itself as inputs. So, I follow your explanation and it's what I understood, but I don't get why were python related things in native-inputs before. That confused me. I'll move those to inputs. Could you explain or find a reason why python wasn't an input before? is it just an error? > > Thanks, > > Chris Thank you for your time and for the explanations. Really helpful. I'll follow up with the updated patch soonish. Only with the Inkscape part. Best, Ekaitz