From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WG2ZAGVPZ2Wo7AAA9RJhRA:P1 (envelope-from ) for ; Wed, 29 Nov 2023 15:49:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WG2ZAGVPZ2Wo7AAA9RJhRA (envelope-from ) for ; Wed, 29 Nov 2023 15:49:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90164239F8 for ; Wed, 29 Nov 2023 15:49:08 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701269348; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=TNUJLW52wqnHGy9vNI98e9APpeIOZnLOTgiRAoUNTws=; b=T/9ZUhFz16R+UmIhgE+y+LF7XFGUPMwwYQUX3ANwDM9/9ls4zCWXig9DDI+SpkDOC/oIqP eNS6OLguDVMJalP1UceRZd+GCNl30atoa3MZOtttKt0vHoR7jVPCbffAHUxUHNN0kqfPtz 8N75dQ6b1zt51y9Vl0Xe+W2PC3tJxbytdLqbfzNXScCBEnAz3ybbRg8YZoGB/30o5z7xNB UlgGPeozNa7/7M9YhXttMd63g+AqyCzri252iVU5tTuPqGvl72Z8huj7Buj1Ky8YiS+a2U vTtqasHPPmDuYSSmhHcwLuCbaNRcnQLWgL+4UQcO3rp/nYr542IHmeAxI/rPNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701269348; a=rsa-sha256; cv=none; b=hu2kEPBXwuyOvqGcNNEgjytGIdKEFcmqTfs3dPTzTIfN7T9SNtx74mo9pep48IHp72quup UyJG42tc7pVUUfSLq/7jucxJK5/rvlrdWmQwElHT8W6Og3OPg9r8xC7w+S4T2UcuNC9WE7 a0a/zc2yc7SIGVMmAGjGA92Ax20A0FSppLtEgfFxp8X05QDC6bqOwLYq4+r4FPM9H1qn65 w5QkhAYfvKdyfFsfOGRTFU/l22xdfZkHrNwVtoefaYi7SYGTbSHLkg8AT3ht5ZnTidobY1 Jpu5nEej/lbIMxXRLInHX5vwFzQPA8E30NoIjrEEb8S5PrZOawYHNmLK2zhWtg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8Ls2-0004Mh-0y; Wed, 29 Nov 2023 09:48:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8Lrz-0004MO-D3 for guix-patches@gnu.org; Wed, 29 Nov 2023 09:48:55 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8Lrz-00060r-5F for guix-patches@gnu.org; Wed, 29 Nov 2023 09:48:55 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8Ls6-0003DW-C5 for guix-patches@gnu.org; Wed, 29 Nov 2023 09:49:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66870] Review Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Nov 2023 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66870 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sughosha Cc: 66870@debbugs.gnu.org Received: via spool by 66870-submit@debbugs.gnu.org id=B66870.170126933312315 (code B ref 66870); Wed, 29 Nov 2023 14:49:02 +0000 Received: (at 66870) by debbugs.gnu.org; 29 Nov 2023 14:48:53 +0000 Received: from localhost ([127.0.0.1]:49271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Lrw-0003CX-H9 for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:48:52 -0500 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:45193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Lrv-0003Bh-0r for 66870@debbugs.gnu.org; Wed, 29 Nov 2023 09:48:51 -0500 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by cotopaxi.ee.ethz.ch (Postfix) with ESMTP id A222F20AE8; Wed, 29 Nov 2023 15:48:35 +0100 (CET) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10028) with ESMTP id VTap1DP2AU2z; Wed, 29 Nov 2023 15:48:34 +0100 (CET) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA; Wed, 29 Nov 2023 15:48:33 +0100 (CET) Date: Wed, 29 Nov 2023 15:48:31 +0100 From: Gabriel Wicki Message-ID: References: <2460289E-B408-41CD-B44B-8DCCB638A482@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2460289E-B408-41CD-B44B-8DCCB638A482@disroot.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 90164239F8 X-Spam-Score: -5.64 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.64 X-TUID: SgDTQANYDAKY Hi So i've de-frizzled the patches by renaming #66870 to "[PATCH 0/6] Add yabridge." [PATCH 1/6] looks good to me! Have you checked the packages depending on asio still build and work? You can check the dependents with this command: $ guix refresh -l asio Building the following 8 packages would ensure 16 dependent packages are rebuilt: emacs-ob-sclang@0.1-1.cd3f3c8 cl-collider@2018.7.15-0.a469088 ecl-cl-collider@2018.7.15-0.a469088 gnome-arcade@0.240 widelands@1.1 musikcube@3.0.1 jami@20230323.0 restbed@4.8 I checked and they all still build fine :) [PATCH 2/6] LGTM. [PATCH 3/6] Looks goot, although I am a bit confused WRT the comment for the (recursive #t) clause in the (source ..) field (indicating we need to recursively copy the repo for the tests to complete) and argument (#:tests? #f) indicating that the tests wouldn't be run. [PATCH 4/6] LGTM. [PATCH 5/6] LGTM. [PATCH 6/6] Wow, now this is a big one! Apart from the following comments this looks good to me! - I'm not sure whether your (let ((arch))) clause isn't an abuse; you test whether (%current-system) is either x86_64-linux or aarch64-linux and set it to x86_64-unix and i386-unix otherwise. Does this actually work for aarch64-linux systems? You could make use of the target-64-bit? function in (guix utils) and only allow the package to build on x86 systems. Also, you inherit wine64's supported-systems field - which only lists x86_64-linux. Building for i368 seems to be unsupported by our wine packages (or wine in general?) - I'm a bit confused about your patch series adding clap 1.1.9 - although yabridge seems to need 1.1.7. Why not add clap@1.1.7 with this series and with the next upgrade of yabridge also update clap? - Similar with input vst3sdk: Why not add it as a separate package? If I interpret the situation correctly, using default definitions of these inputs could also let you simplify your native-inputs list to the new style. All packages built fine and running $(guix style) didn't change anything. $(guix lint) on the patched packages gave the following output: ~/src/guix/gnu/packages/networking.scm:3431:15: asio@1.28.0: permanent redirect from https://think-async.com/Asio to https://think-async.com/Asio/ fetching CVE database for 2023... ~/src/guix/gnu/packages/networking.scm:3417:5: asio@1.28.0: source not archived on Software Heritage and missing from the Disarchive database ~/src/guix/gnu/packages/cpp.scm:2311:13: function2@4.2.3: can be upgraded to 4.2.4 ~/src/guix/gnu/packages/audio.scm:2724:13: clap@1.1.9: can be upgraded to 1.1.10 ~/src/guix/gnu/packages/audio.scm:6002:0: yabridge@5.0.5: line 6002 is way too long (95 characters) ~/src/guix/gnu/packages/audio.scm:6013:0: yabridge@5.0.5: line 6013 is way too long (100 characters) Please send in a updated patch-set. Thanks for your time and effort! g