From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59540) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRKIw-0003Co-OF for guix-patches@gnu.org; Wed, 22 Apr 2020 14:41:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRKIw-0000oI-1M for guix-patches@gnu.org; Wed, 22 Apr 2020 14:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRKIv-0000nL-Kz for guix-patches@gnu.org; Wed, 22 Apr 2020 14:41:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRKIv-0004fB-Hb for guix-patches@gnu.org; Wed, 22 Apr 2020 14:41:01 -0400 Subject: [bug#40492] [PATCH] gnu: Add meshlab Resent-Message-ID: Date: Wed, 22 Apr 2020 18:40:31 +0000 From: Ekaitz Zarraga Message-ID: In-Reply-To: <87a733v3hh.fsf@gnu.org> References: <_UXapokzwPRYl41j0bjkPGSDUNXahWNWsEn72py7ch7Rd6DBsxW9B8rw8wTbmzj1O2HfWXz7XLbEdWCYQsFCa5DgMlGn0CKVPr779J2PFuo=@elenq.tech> <87a733v3hh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "40492@debbugs.gnu.org" <40492@debbugs.gnu.org> =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Wednesday, April 22, 2020 7:23 PM, Ludovic Court=C3=A8s w= rote: > Hi, > > Ekaitz Zarraga ekaitz@elenq.tech skribis: > > > I wrote a package to add meshlab but I'm not sure if I did it right: > > > > - It doesn't have tests so I removed the testing. > > Please add a short comment in the code saying this so that people > touching the package in the future will know. > > > - It fails to check RUNPATH, but I don't really know why so I disable= d > > it at the moment. It fails while searching for meshlab core librari= es > > but the search path is correct (it misses a /meshlab at the end). > > > > Could you show the error message? It may be that the build system fails > to pass the right -Wl,-rpath or even the right -L/-l flags at link time. > > > > From d9020d7e64020dc7eea1bd46af184856d568ca7d Mon Sep 17 00:00:00 200= 1 > > > From: Ekaitz Zarraga ekaitz@elenq.tech > > > Date: Tue, 7 Apr 2020 18:56:06 +0200 > > > Subject: [PATCH] gnu: Add meshlab > > > > gnu/packages/engineering.scm | 39 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > Bonus points if you can provide a commit log that follows our > conventions. :-) See > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html and > =E2=80=98git log=E2=80=99 for examples. > > > +(define-public meshlab > > > > - (let ((commit-ref "Meshlab-2020.04")) > > - (package > > - (name "meshlab") > > > > > > - (version commit-ref) > > > > > > The version field should be =E2=80=9C2020.04=E2=80=9D. You can construct = the commit > from that: > > (string-append "Meshlab-" version) > > > - (synopsis > > > > > > - "The open source system for processing and editing 3D triang= ular meshes.") > > > > > > - (home-page "http://www.meshlab.net/") > > > > > > - (description "MeshLab is an open source, portable, and extensi= ble system > > > > > > Two comments: > > 1. Everything in Guix is free software, you can remove the =E2=80=9Copen > source=E2=80=9D mention. > > 2. Please make sure to run =E2=80=98guix lint=E2=80=99 and check the gui= delines at > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.ht= ml. > > > Could you send an updated patch? > > Thanks in advance! > > Ludo=E2=80=99. Hi Ludo, Thanks for the detailed answer. I'll check the formatting errors. About the RUNPATH checks, I isolated one of the errors and I don't know wha= t to change. This is the error of the file libsamplefilter.so during the runpath check: /gnu/store/lcpp0gpispfqw8zna2mjrr6cwj3ih133-meshlab-Meshlab-2020.04/lib/mes= hlab/plugins/libsamplefilter.so: error: depends on 'libmeshlab-common.so', = which cannot be found in RUNPATH ("/gnu/store/lcpp0gpispfqw8zna2mjrr6cwj3ih= 133-meshlab-Meshlab-2020.04/lib" "/gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4= pj-glibc-2.29/lib" "/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-l= ib/lib" "/gnu/store/n6ji2fxg1cn6abd2bn2jd14pglyblysr-qtbase-5.12.7/lib" "/g= nu/store/qbq794vbw5scpxvnzlnyvdkqfr9163rk-qtscript-5.12.7/lib" "/gnu/store/= 2k1bsh663bilxndca4gx4zrdp7m63fjb-qtxmlpatterns-5.12.7/lib" "/gnu/store/2mf0= clz9w64diy0kz11qcs4q5wg9hc6z-mesa-19.3.4/lib" "/gnu/store/2plcy91lypnbbysb1= 8ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/gcc/x86_64-unknown-linux-gnu/7.4.0/../../= ..") /gnu/store/lcpp0gpispfqw8zna2mjrr6cwj3ih133-meshlab-Meshlab-2020.04/lib/mes= hlab/plugins/libsamplefilterdyn.so: error: depends on 'libmeshlab-common.so= ', which cannot be found in RUNPATH ("/gnu/store/lcpp0gpispfqw8zna2mjrr6cwj= 3ih133-meshlab-Meshlab-2020.04/lib" "/gnu/store/ahqgl4h89xqj695lgqvsaf6zh2n= hy4pj-glibc-2.29/lib" "/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.= 0-lib/lib" "/gnu/store/n6ji2fxg1cn6abd2bn2jd14pglyblysr-qtbase-5.12.7/lib" = "/gnu/store/qbq794vbw5scpxvnzlnyvdkqfr9163rk-qtscript-5.12.7/lib" "/gnu/sto= re/2k1bsh663bilxndca4gx4zrdp7m63fjb-qtxmlpatterns-5.12.7/lib" "/gnu/store/2= mf0clz9w64diy0kz11qcs4q5wg9hc6z-mesa-19.3.4/lib" "/gnu/store/2plcy91lypnbby= sb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/gcc/x86_64-unknown-linux-gnu/7.4.0/../= ../..") validating RUNPATH of 2 binaries in "/gnu/store/lcpp0gpispfqw8zna2mjrr6cwj3= ih133-meshlab-Meshlab-2020.04/bin"... But the first element in the RUNPATH is the place where the library is. Thi= s is the library's path: /gnu/store/lcpp0gpispfqw8zna2mjrr6cwj3ih133-meshlab-Meshlab-2020.04/lib/mes= hlab/libmeshlab-common.so This is the linking of the libsamplefilter.so file: [ 98%] Linking CXX shared module ../../distrib/plugins/libsamplefilter.so cd /tmp/guix-build-meshlab-Meshlab-2020.04.drv-0/source/build/sampleplugins= /samplefilter && /gnu/store/iz9500ssxcqlyr74hg1jq10ycrh42yq1-cmake-minimal-= 3.15.1/bin/cmake -E cmake_link_script CMakeFiles/samplefilter.dir/link.txt = --verbose=3D1 /gnu/store/x3jx25cd3q363mr7nbgzrhrv1vza6cf7-gcc-7.4.0/bin/c++ -fPIC -O2 -g = -DNDEBUG -Wl,--no-undefined -shared -o ../../distrib/plugins/libsamplefil= ter.so CMakeFiles/samplefilter.dir/samplefilter_autogen/mocs_compilation.cp= p.o CMakeFiles/samplefilter.dir/samplefilter.cpp.o -Wl,-rpath,/tmp/guix-bui= ld-meshlab-Meshlab-2020.04.drv-0/source/build/common:::::: ../../common/lib= meshlab-common.so /gnu/store/n6ji2fxg1cn6abd2bn2jd14pglyblysr-qtbase-5.12.7= /lib/libQt5OpenGL.so.5.12.7 /gnu/store/qbq794vbw5scpxvnzlnyvdkqfr9163rk-qts= cript-5.12.7/lib/libQt5Script.so.5.12.7 /gnu/store/n6ji2fxg1cn6abd2bn2jd14p= glyblysr-qtbase-5.12.7/lib/libQt5Widgets.so.5.12.7 /gnu/store/n6ji2fxg1cn6a= bd2bn2jd14pglyblysr-qtbase-5.12.7/lib/libQt5Gui.so.5.12.7 /gnu/store/n6ji2f= xg1cn6abd2bn2jd14pglyblysr-qtbase-5.12.7/lib/libQt5Xml.so.5.12.7 /gnu/store= /2k1bsh663bilxndca4gx4zrdp7m63fjb-qtxmlpatterns-5.12.7/lib/libQt5XmlPattern= s.so.5.12.7 /gnu/store/n6ji2fxg1cn6abd2bn2jd14pglyblysr-qtbase-5.12.7/lib/l= ibQt5Network.so.5.12.7 /gnu/store/n6ji2fxg1cn6abd2bn2jd14pglyblysr-qtbase-5= .12.7/lib/libQt5Core.so.5.12.7 ../../libexternal-glew.a /gnu/store/2mf0clz9= w64diy0kz11qcs4q5wg9hc6z-mesa-19.3.4/lib/libGL.so The -rpath and -Wl are set to /tmp/guix-build-meshlab-Meshlab-2020.04.drv-0= /source/build/common but it should be set to the directory it showed previously, right? If I need to change that, what do I have to do? Sorry for the inconvenience, but I'm a little bit lost on this. Thank you, Ekaitz