unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ryan Prior via Guix-patches via <guix-patches@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: "43840@debbugs.gnu.org" <43840@debbugs.gnu.org>
Subject: [bug#43840] [PATCH] gnu: Add esbuild.
Date: Sun, 11 Oct 2020 16:15:56 +0000	[thread overview]
Message-ID: <impJSqTruwGOFiNbNOpGCv26lJXzeDb0kcRXhSvTNX-FoS2SybRjbQXf3gbgkeok8YdEmJftvGfxjLPQjmds8HwEp4rShLmCuxU_VtXW0g8=@protonmail.com> (raw)
In-Reply-To: <20201011102853.GB1301@E5400>

On Sunday, October 11th, 2020 at 10:28 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> It's important to not ship any precompiled binaries so go ahead and
> remove them in a snippet.

You got it.

> I was able to run some of the test suite with the following arguments section:
> [snip]
> Unfortunately it also depends on github.com/kylelemons/godebug/diff, but
> it doesn't look like it has any dependants. With that added as a
> native-input I think it's ready.

I do have a package for godebug. If you want to run all the tests, it goes in to the `scripts` module and runs `npm install` to pull in various test dependencies: https://github.com/evanw/esbuild/blob/master/scripts/package.json

But running just the "test-go" target seems like a good compromise for now! Maybe we can revisit this once node packaging in Guix is in a better state (which esbuild may help us with.)

I'll send my godebug package and an updated esbuild package with the code to run the tests.

Ryan




  reply	other threads:[~2020-10-11 16:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  2:31 [bug#43840] [PATCH] gnu: Add esbuild Ryan Prior via Guix-patches via
2020-10-07  6:34 ` Efraim Flashner
2020-10-08  2:08   ` Ryan Prior via Guix-patches via
2020-10-11 10:28     ` Efraim Flashner
2020-10-11 16:15       ` Ryan Prior via Guix-patches via [this message]
2020-10-11 16:16 ` [bug#43840] [PATCH 1/2] gnu: Add go-github-com-kylelemons-godebug Ryan Prior via Guix-patches via
2020-10-11 16:16   ` [bug#43840] [PATCH 2/2] gnu: Add esbuild Ryan Prior via Guix-patches via
2020-10-12  6:41     ` bug#43840: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='impJSqTruwGOFiNbNOpGCv26lJXzeDb0kcRXhSvTNX-FoS2SybRjbQXf3gbgkeok8YdEmJftvGfxjLPQjmds8HwEp4rShLmCuxU_VtXW0g8=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=43840@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=rprior@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).