From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: MadalinIonel.Patrascu@mdc-berlin.de
Cc: 32587@debbugs.gnu.org
Subject: [bug#32587] [PATCH] gnu: Add r-pore.
Date: Mon, 3 Sep 2018 17:22:29 +0200 [thread overview]
Message-ID: <idjpnxu38sq.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <20180830103703.10473-1-madalinionel.patrascu@mdc-berlin.de>
Hi,
thanks for the patch!
> +
> +(define-public r-pore
> + (package
> + (name "r-pore")
> + (version "0.24")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://sourceforge.net/projects/rpore/files/"version"/poRe_"version".tar.gz"))
Please use mirror://sourceforge/ here.
> + (sha256
> + (base32 "0pih9nljbv8g4x8rkk29i7aqq681b782r5s5ynp4nw9yzqnmmksv"))))
> + (properties `((upstream-name . "poRe")))
> + (build-system r-build-system)
> + (native-inputs
> + `(("r-rhdf5" ,r-rhdf5)
> + ("r-shiny" ,r-shiny)
> + ("r-svdialogs" ,r-svdialogs)
> + ("r-data-table" ,r-data-table)
> + ("r-bit64" ,r-bit64)))
Are you sure these should be native-inputs? They probably should be
propagated inputs, because they should be installed together with the
“r-pore” package.
Please also sort these inputs alphabetically.
> + (home-page "https://sourceforge.net/projects/rpore/files/")
Please use “https://sourceforge.net/projects/rpore”.
> + (synopsis "This R package enable visualisation of nanopore sequencing data")
Please use “Visualize Nanopore sequencing data”.
> + (description
> + "The Oxford Nanopore MinION is a revolutionary sequencer with a unique model of data
> +delivery, requiring novel tools for the novice user. This package enables
> +organisation and visualisation of MinION data.")
Please try to avoid marketing terms such as “revolutionary”, “unique”,
“novel” etc. Could you try to come up with a description that better
describes the features of the poRe package?
Here’s a draft:
This package provides graphical user interfaces to organize and
visualize Nanopore sequencing data.
> + (license license:gpl3)))
I don’t think this is correct. The DESCRIPTION file says “BSD”, but
fails to state the variant. I have opened an issue about this here:
https://github.com/mw55309/poRe_docs/issues/10
Could you please send an updated patch?
--
Ricardo
next prev parent reply other threads:[~2018-09-03 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 10:37 [bug#32587] [PATCH] gnu: Add r-pore pimi
2018-09-03 15:22 ` Ricardo Wurmus [this message]
2018-09-11 14:54 ` pimi
2018-09-21 12:29 ` bug#32587: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjpnxu38sq.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=32587@debbugs.gnu.org \
--cc=MadalinIonel.Patrascu@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).