From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58695)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fwqwV-0007pF-0r
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:39:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fwqwQ-00066S-5B
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:39:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:39513)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fwqwQ-00066J-01
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:39:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fwqwP-0005y1-T8
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:39:01 -0400
Subject: [bug#32585] [PATCH] gnu: Add r-svgui.
References: <20180830101632.9950-1-madalinionel.patrascu@mdc-berlin.de>
In-Reply-To: <20180830101632.9950-1-madalinionel.patrascu@mdc-berlin.de>
Resent-Message-ID: <handler.32585.B32585.153598910922876@debbugs.gnu.org>
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 3 Sep 2018 17:38:20 +0200
Message-ID: <idjk1o2382b.fsf@bimsb-sys02.mdc-berlin.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 32585@debbugs.gnu.org
Cc: pimi <madalinionel.patrasc@mdc-berlin.de>

Hi,

> gnu/packages/cran.scm (r-svgui): New variable
> ---
>  gnu/packages/cran.scm | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)

> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 016d1b1e4..e6fb6b8f7 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -41,7 +41,9 @@
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages statistics)
>    #:use-module (gnu packages tls)
> -  #:use-module (gnu packages web))
> +  #:use-module (gnu packages web)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages gnome))

It looks like these changes belong to another patch as the package added
by this patch doesn=E2=80=99t have any inputs.

> +(define-public r-svgui
> +  (package
> +    (name "r-svgui")
> +    (version "1.0.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "svGUI" version))
> +       (sha256
> +        (base32 "1r7ab0p4yr8q03gj02hmj7k1ghksgkg4nx750c0ajfs2q9y1dxfc"))=
))
> +    (properties `((upstream-name . "svGUI")))
> +    (build-system r-build-system)
> +    (home-page "https://github.com/SciViews/svGUI/")
> +    (synopsis "Functions for managing GUI client in R")

=E2=80=9Cclients"

> +    (description
> +     "The SciViews @code{svGUI} package eases the management of Graphica=
l User Interfaces
> +(GUI) in R.  It is independent from any particular GUI widgets (Tk, Gtk2,
> +native, ...).  It centralizes info about GUI elements currently used, an=
d it
> +dispatches GUI calls to the particular toolkits in use in function of the
> +context (is R run at the terminal, within a Tk application, a HTML page?=
).")

Please reflow the description =E2=80=94 the first line looks unusually long.

> +    (license license:gpl2)))

This is correct.

Could you please send an updated patch?

Thanks!

--
Ricardo