From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fn0Yx-0007jj-D1
	for guix-patches@gnu.org; Tue, 07 Aug 2018 07:54:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fn0Yu-0006Gb-BO
	for guix-patches@gnu.org; Tue, 07 Aug 2018 07:54:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38188)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fn0Yt-0006GS-W8
	for guix-patches@gnu.org; Tue, 07 Aug 2018 07:54:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fn0Yt-0002aD-Ml
	for guix-patches@gnu.org; Tue, 07 Aug 2018 07:54:03 -0400
Subject: bug#32364: [PATCH] gnu: Add mozjs-52.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.32364.D32364.15336428399915.done@debbugs.gnu.org>
References: <20180803161542.26246-1-ricardo.wurmus@mdc-berlin.de>
	<20180805175726.GA32130@macbook41> <87sh3s1slh.fsf@posteo.net>
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
In-Reply-To: <87sh3s1slh.fsf@posteo.net>
Date: Tue, 7 Aug 2018 13:53:49 +0200
Message-ID: <idj600m8kaa.fsf@bimsb-sys02.mdc-berlin.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 32364-done@debbugs.gnu.org


Kei Kebreau <kkebreau@posteo.net> writes:

> Efraim Flashner <efraim@flashner.co.il> writes:
>
>> On Fri, Aug 03, 2018 at 06:15:42PM +0200, Ricardo Wurmus wrote:
>>> + ;; No releases yet at
>>> <https://archive.mozilla.org/pub/spidermonkey/releases/>.
>>> + ;; While we could take a snapshot of the complete mozilla-esr52
>>> repository at
>>> + ;;
>>> <https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr52&filter-searchStr=sm-tc>,
>>> +  ;; we take the Debian version instead, because it is easier to work with.
>>> +  (let ((commit "6507e63cc416fd7a3269e390efe712f8b56f374a")
>>> +        (revision "1"))
>>> +    (package (inherit mozjs-38)
>>
>> Do the other ones have their name listed? I had to build 'mozjs@52'
>> instead of 'mozjs-52'
>>
>
> I mangaged to build this with just 'mozjs'.
>
>>> +      (version (git-version "52.0-0." revision commit))
>>> +      (source (origin
>>> +                (method git-fetch)
>>> +                (uri (git-reference
>>
>>
>> This built with no problems on aarch64 and the package looks good. It
>> also built with '--system=armhf-linux' on my aarch64 board.
>
> I built this successfully for x86_64-linux, i686-linux, and armhf-linux
> on a x86_64-linux computer.

Thank you both for testing the patch.

I pushed a slightly modified version of this patch to
wip-gnome-upgrades, which is supposed to be merged into core-updates
soon.

The patch that I sent here results in a package that cannot be used with
GJS (it segfaults).  I had to apply a patch that is included in the
Debian copy of the source code.

--
Ricardo