unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 32364-done@debbugs.gnu.org
Subject: bug#32364: [PATCH] gnu: Add mozjs-52.
Date: Tue, 7 Aug 2018 13:53:49 +0200	[thread overview]
Message-ID: <idj600m8kaa.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87sh3s1slh.fsf@posteo.net>


Kei Kebreau <kkebreau@posteo.net> writes:

> Efraim Flashner <efraim@flashner.co.il> writes:
>
>> On Fri, Aug 03, 2018 at 06:15:42PM +0200, Ricardo Wurmus wrote:
>>> + ;; No releases yet at
>>> <https://archive.mozilla.org/pub/spidermonkey/releases/>.
>>> + ;; While we could take a snapshot of the complete mozilla-esr52
>>> repository at
>>> + ;;
>>> <https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr52&filter-searchStr=sm-tc>,
>>> +  ;; we take the Debian version instead, because it is easier to work with.
>>> +  (let ((commit "6507e63cc416fd7a3269e390efe712f8b56f374a")
>>> +        (revision "1"))
>>> +    (package (inherit mozjs-38)
>>
>> Do the other ones have their name listed? I had to build 'mozjs@52'
>> instead of 'mozjs-52'
>>
>
> I mangaged to build this with just 'mozjs'.
>
>>> +      (version (git-version "52.0-0." revision commit))
>>> +      (source (origin
>>> +                (method git-fetch)
>>> +                (uri (git-reference
>>
>>
>> This built with no problems on aarch64 and the package looks good. It
>> also built with '--system=armhf-linux' on my aarch64 board.
>
> I built this successfully for x86_64-linux, i686-linux, and armhf-linux
> on a x86_64-linux computer.

Thank you both for testing the patch.

I pushed a slightly modified version of this patch to
wip-gnome-upgrades, which is supposed to be merged into core-updates
soon.

The patch that I sent here results in a package that cannot be used with
GJS (it segfaults).  I had to apply a patch that is included in the
Debian copy of the source code.

--
Ricardo

      reply	other threads:[~2018-08-07 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 16:15 [bug#32364] [PATCH] gnu: Add mozjs-52 Ricardo Wurmus
2018-08-05 17:57 ` Efraim Flashner
2018-08-05 20:11   ` Kei Kebreau
2018-08-07 11:53     ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idj600m8kaa.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=32364-done@debbugs.gnu.org \
    --cc=kkebreau@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).